From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.5 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 72822C432BE for ; Wed, 28 Jul 2021 18:46:02 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 5BD6D6056C for ; Wed, 28 Jul 2021 18:46:02 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230091AbhG1SqC (ORCPT ); Wed, 28 Jul 2021 14:46:02 -0400 Received: from mail.kernel.org ([198.145.29.99]:35816 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229565AbhG1SqA (ORCPT ); Wed, 28 Jul 2021 14:46:00 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 939516023B; Wed, 28 Jul 2021 18:45:57 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1627497958; bh=AGvqkwV9OjaqEJNQNzy5jf5UNN74DbHUMIEiFgrsVGU=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=kZSgyhG3eLa4XizSP156vF5jNbRODIEdiCvbS2XCrIX6ig5SPxb4vSBB+ScjHLGNs KGq/UfdGENY1FNqUF378LulYtNJmI2I8JSquMYR+bbEsTsGGH22FLQZ8z+a6Xx9DqE eeR2b61O16/Cq2233ylmgJwa7YoImmctEe3wTHEE= Date: Wed, 28 Jul 2021 20:45:55 +0200 From: Greg KH To: Ojaswin Mujoo Cc: nsaenz@kernel.org, stefan.wahren@i2se.com, dan.carpenter@oracle.com, phil@raspberrypi.com, linux-arm-kernel@lists.infradead.org, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Subject: Re: [PATCH 1/2] staging: vchiq: Set $CONFIG_VCHIQ_CDEV to be enabled by default Message-ID: References: <70d91b0482e19d7551d3258ea54c970c1b996317.1627495116.git.ojaswin98@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <70d91b0482e19d7551d3258ea54c970c1b996317.1627495116.git.ojaswin98@gmail.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Jul 29, 2021 at 12:07:16AM +0530, Ojaswin Mujoo wrote: > Before this config was defined, the cdev used to be created > unconditionally. When an earlier commit introduced this config, the > default behavior was set to disabled, which might surprise some > unsuspecting users. Hence, make this config default to 'Y' to be more > backward consistent. > > Signed-off-by: Ojaswin Mujoo > --- > drivers/staging/vc04_services/Kconfig | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/staging/vc04_services/Kconfig b/drivers/staging/vc04_services/Kconfig > index 63caa6818d37..2b70c37cdd09 100644 > --- a/drivers/staging/vc04_services/Kconfig > +++ b/drivers/staging/vc04_services/Kconfig > @@ -23,6 +23,7 @@ if BCM2835_VCHIQ > > config VCHIQ_CDEV > bool "VCHIQ Character Driver" > + default y default y is only if the machine will not work without this option. Is that the case here? If not, then please do not have this as the default. thanks, greg k-h From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-14.5 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 485B1C4338F for ; Wed, 28 Jul 2021 18:48:15 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 070B96056C for ; Wed, 28 Jul 2021 18:48:15 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 070B96056C Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linuxfoundation.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=mjzSAbGS7oWvmP7gj/LuxJow55P9aScmQlclrz71yxY=; b=qf3tFNEA3RsNr7 gnNlj/VmysWpsHP9RKpEB4MoFOBEd2XJVlVZNwZdfLlRpz6tk26mQMpaSfF50dg7NlwtEL2V6xw7l bxkzjOahysnnu8RG3E6JrL0B6UTDwFLTO07b04zAlnPQ/3mYCT5xW63IUZb4XdgkeEAhnpW+E/hTR et7IG0gqXoyqh5hibuNMZDaJi/+RwlAeTgOiGoFQzloAi2szzPNPZ26NMHjDjg5XdB7cKAzZlg6rq UIk10HlRfOA44rC9Uc3ucQKNjlNcPksXISPR8PzvfkkxGuGdmTs9RvVgDecgvz1GSEGXUctq9dX+O Q8v8+SASgp88DyId+JpQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1m8oZ8-0027eU-3G; Wed, 28 Jul 2021 18:46:02 +0000 Received: from mail.kernel.org ([198.145.29.99]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1m8oZ4-0027e4-Ja for linux-arm-kernel@lists.infradead.org; Wed, 28 Jul 2021 18:45:59 +0000 Received: by mail.kernel.org (Postfix) with ESMTPSA id 939516023B; Wed, 28 Jul 2021 18:45:57 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1627497958; bh=AGvqkwV9OjaqEJNQNzy5jf5UNN74DbHUMIEiFgrsVGU=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=kZSgyhG3eLa4XizSP156vF5jNbRODIEdiCvbS2XCrIX6ig5SPxb4vSBB+ScjHLGNs KGq/UfdGENY1FNqUF378LulYtNJmI2I8JSquMYR+bbEsTsGGH22FLQZ8z+a6Xx9DqE eeR2b61O16/Cq2233ylmgJwa7YoImmctEe3wTHEE= Date: Wed, 28 Jul 2021 20:45:55 +0200 From: Greg KH To: Ojaswin Mujoo Cc: nsaenz@kernel.org, stefan.wahren@i2se.com, dan.carpenter@oracle.com, phil@raspberrypi.com, linux-arm-kernel@lists.infradead.org, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Subject: Re: [PATCH 1/2] staging: vchiq: Set $CONFIG_VCHIQ_CDEV to be enabled by default Message-ID: References: <70d91b0482e19d7551d3258ea54c970c1b996317.1627495116.git.ojaswin98@gmail.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <70d91b0482e19d7551d3258ea54c970c1b996317.1627495116.git.ojaswin98@gmail.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210728_114558_702512_3BEBCE39 X-CRM114-Status: GOOD ( 14.35 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, Jul 29, 2021 at 12:07:16AM +0530, Ojaswin Mujoo wrote: > Before this config was defined, the cdev used to be created > unconditionally. When an earlier commit introduced this config, the > default behavior was set to disabled, which might surprise some > unsuspecting users. Hence, make this config default to 'Y' to be more > backward consistent. > > Signed-off-by: Ojaswin Mujoo > --- > drivers/staging/vc04_services/Kconfig | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/staging/vc04_services/Kconfig b/drivers/staging/vc04_services/Kconfig > index 63caa6818d37..2b70c37cdd09 100644 > --- a/drivers/staging/vc04_services/Kconfig > +++ b/drivers/staging/vc04_services/Kconfig > @@ -23,6 +23,7 @@ if BCM2835_VCHIQ > > config VCHIQ_CDEV > bool "VCHIQ Character Driver" > + default y default y is only if the machine will not work without this option. Is that the case here? If not, then please do not have this as the default. thanks, greg k-h _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel