From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.6 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_ADSP_CUSTOM_MED,DKIM_SIGNED,DKIM_VALID,FSL_HELO_FAKE, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B263AC432BE for ; Thu, 29 Jul 2021 14:01:48 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 7EF8960238 for ; Thu, 29 Jul 2021 14:01:48 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 7EF8960238 Authentication-Results: mail.kernel.org; dmarc=fail (p=reject dis=none) header.from=google.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=QgZBCRVp3rEgnt/RQc4Jz2Zw89K9HmF+MIHG73ue01c=; b=TNq+I/+pwO+hYs Zm4H48lghZ3wtxAqGnMxosMGLfOd3qGNARfnE7PVNfR+fKp/o60eIHthE2Me15P1WRfWQ3UVmg8tP HPeLAGXC5KpPGC82kxvyghyw8kBPXeYNTDBa6Fupz4+3tYNkICw79Lwn/kW4FYZ++4N+iclS7qkpj gPgTUBMkQaO2S7UQJj/0u8a0rByJzsP7Nt7bwJ4fZ62QxjPzcFQvFIfldgo3mlTyd2Q0Q2wn3zScl 3kp1uV2E7lZwkrZs9kneddVDSmHljHGA+bRxLnDeXXXdfRshdN32QJK4A63XD7dlLnvcPglD7VG41 NtYA/88Y9PZFmCpgbrWQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1m96aB-004R5J-3x; Thu, 29 Jul 2021 14:00:19 +0000 Received: from mail-wr1-x429.google.com ([2a00:1450:4864:20::429]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1m96a7-004R2Y-SE for linux-arm-kernel@lists.infradead.org; Thu, 29 Jul 2021 14:00:17 +0000 Received: by mail-wr1-x429.google.com with SMTP id h14so7053925wrx.10 for ; Thu, 29 Jul 2021 07:00:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=liO5wucVGjUgl66CCyk5eCr9ee7CWFbOuaagBW74+qs=; b=EJ2F3ITFwEJ9rcPEvHQ6lQ2DOZnQ5vBtGtiPUiaEaUYZAeiKbLrc61I8wPZVT0mmce oMnATeCgB3nMSCmOY6JYICgTkdxdCA6cizvZWmE5FXgzbr/++FZUo4NbEvGTfoaVyNo1 0azpBzwCzgho7Xydbwqhu4X7ssL0HYuQtBhcVrHshYeuX/tgsNM/hwhRAfj6VPIYKcNn SRdE5PgOBshCvRabzbztBxFP+svsg33eT/iYXEhNAvgVqbLfjYJ27YSZ+f2oEjLm1yDO AhQLpqmc/tmy1CFjkjoE2k7ynXOGtOgA9wC8FJHeG8CjoVUhMUY8rhuJgR4gWWk4TaFx BLGw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=liO5wucVGjUgl66CCyk5eCr9ee7CWFbOuaagBW74+qs=; b=Q9igtSQR3WKY2+zKGIciWG3yLiIbZHynPgcLjpxiOVIdgnIEvqBF+KCQbSrNRQI9Yo flNLvGLFZNROPYBPghaaP0Zi0n9yZ/z2jj/PR6voX9pUienBmH/Mig9Nx6KKRsBCuWpl u5chCLAnaILQoKftMWX13BjArsTuG4N14KeO+u2Q/zqD4SA9OGIPDbFYv6xAyInUtTS7 XylHkCG8nuSUBz6Xat2OScBwERV/xQQwoIfO4/aZUtt1L4Nf1GOxn2Zeh9p+uuSZRMdx Iw7M+MPJg/DuruXd+ZQnVVzb/rsh43/+31uR05TQc93DTcROzTQxqXryDWASNbNNbztI Hl+Q== X-Gm-Message-State: AOAM531hf/lXDvUMqX9hFcq08mMOnLsjBhZby9tMSh5kI+AWk7Md/4ew YTWBByHd6Z21X3jgwflOO7JXlQ== X-Google-Smtp-Source: ABdhPJzb3jcmoJ3eeO2z7wKiK0sm764dKThMtyfcXT/S/xhsz1jMXke7rkEjfqjma4uFzTs051Dz9A== X-Received: by 2002:a5d:64ac:: with SMTP id m12mr4942109wrp.89.1627567209287; Thu, 29 Jul 2021 07:00:09 -0700 (PDT) Received: from google.com ([2a00:79e0:d:210:293a:bc89:7514:5218]) by smtp.gmail.com with ESMTPSA id l18sm9913097wmq.0.2021.07.29.07.00.08 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 29 Jul 2021 07:00:09 -0700 (PDT) Date: Thu, 29 Jul 2021 15:00:05 +0100 From: Quentin Perret To: Marc Zyngier Cc: kvmarm@lists.cs.columbia.edu, kvm@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Will Deacon , James Morse , Suzuki K Poulose , Alexandru Elisei , kernel-team@android.com, Catalin Marinas , stable@vger.kernel.org Subject: Re: [PATCH] KVM: arm64: Unregister HYP sections from kmemleak in protected mode Message-ID: References: <20210729135016.3037277-1-maz@kernel.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20210729135016.3037277-1-maz@kernel.org> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210729_070015_962876_AF9E2756 X-CRM114-Status: GOOD ( 19.76 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thursday 29 Jul 2021 at 14:50:16 (+0100), Marc Zyngier wrote: > Booting a KVM host in protected mode with kmemleak quickly results > in a pretty bad crash, as kmemleak doesn't know that the HYP sections > have been taken away. > > Make the unregistration from kmemleak part of marking the sections > as HYP-private. The rest of the HYP-specific data is obtained via > the page allocator, which is not subjected to kmemleak. > > Fixes: 90134ac9cabb ("KVM: arm64: Protect the .hyp sections from the host") > Signed-off-by: Marc Zyngier > Cc: Quentin Perret > Cc: Catalin Marinas > Cc: stable@vger.kernel.org # 5.13 > --- > arch/arm64/kvm/arm.c | 7 ++++++- > 1 file changed, 6 insertions(+), 1 deletion(-) > > diff --git a/arch/arm64/kvm/arm.c b/arch/arm64/kvm/arm.c > index e9a2b8f27792..23f12e602878 100644 > --- a/arch/arm64/kvm/arm.c > +++ b/arch/arm64/kvm/arm.c > @@ -15,6 +15,7 @@ > #include > #include > #include > +#include > #include > #include > #include > @@ -1960,8 +1961,12 @@ static inline int pkvm_mark_hyp(phys_addr_t start, phys_addr_t end) > } > > #define pkvm_mark_hyp_section(__section) \ > +({ \ > + u64 sz = __section##_end - __section##_start; \ > + kmemleak_free_part(__section##_start, sz); \ > pkvm_mark_hyp(__pa_symbol(__section##_start), \ > - __pa_symbol(__section##_end)) > + __pa_symbol(__section##_end)); \ > +}) At some point we should also look into unmapping these sections from EL1 stage-1 as well, as that should lead to better error messages in case the host accesses hyp-private memory some other way. But this patch makes sense on its own, so: Reviewed-by: Quentin Perret Thanks, Quentin _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.7 required=3.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED,DKIM_INVALID,DKIM_SIGNED,FSL_HELO_FAKE, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4AFB3C4338F for ; Thu, 29 Jul 2021 14:00:14 +0000 (UTC) Received: from mm01.cs.columbia.edu (mm01.cs.columbia.edu [128.59.11.253]) by mail.kernel.org (Postfix) with ESMTP id BE7E261059 for ; Thu, 29 Jul 2021 14:00:13 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org BE7E261059 Authentication-Results: mail.kernel.org; dmarc=fail (p=reject dis=none) header.from=google.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=lists.cs.columbia.edu Received: from localhost (localhost [127.0.0.1]) by mm01.cs.columbia.edu (Postfix) with ESMTP id 3A55A4B0CE; Thu, 29 Jul 2021 10:00:13 -0400 (EDT) X-Virus-Scanned: at lists.cs.columbia.edu Authentication-Results: mm01.cs.columbia.edu (amavisd-new); dkim=softfail (fail, message has been altered) header.i=@google.com Received: from mm01.cs.columbia.edu ([127.0.0.1]) by localhost (mm01.cs.columbia.edu [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id HvTWXN4Pvyal; Thu, 29 Jul 2021 10:00:12 -0400 (EDT) Received: from mm01.cs.columbia.edu (localhost [127.0.0.1]) by mm01.cs.columbia.edu (Postfix) with ESMTP id 1025B4B0C6; Thu, 29 Jul 2021 10:00:12 -0400 (EDT) Received: from localhost (localhost [127.0.0.1]) by mm01.cs.columbia.edu (Postfix) with ESMTP id 9F6FF4B0B6 for ; Thu, 29 Jul 2021 10:00:11 -0400 (EDT) X-Virus-Scanned: at lists.cs.columbia.edu Received: from mm01.cs.columbia.edu ([127.0.0.1]) by localhost (mm01.cs.columbia.edu [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id uk51yQMRhr9B for ; Thu, 29 Jul 2021 10:00:10 -0400 (EDT) Received: from mail-wr1-f50.google.com (mail-wr1-f50.google.com [209.85.221.50]) by mm01.cs.columbia.edu (Postfix) with ESMTPS id 82D704B0BC for ; Thu, 29 Jul 2021 10:00:10 -0400 (EDT) Received: by mail-wr1-f50.google.com with SMTP id r2so7119420wrl.1 for ; Thu, 29 Jul 2021 07:00:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=liO5wucVGjUgl66CCyk5eCr9ee7CWFbOuaagBW74+qs=; b=EJ2F3ITFwEJ9rcPEvHQ6lQ2DOZnQ5vBtGtiPUiaEaUYZAeiKbLrc61I8wPZVT0mmce oMnATeCgB3nMSCmOY6JYICgTkdxdCA6cizvZWmE5FXgzbr/++FZUo4NbEvGTfoaVyNo1 0azpBzwCzgho7Xydbwqhu4X7ssL0HYuQtBhcVrHshYeuX/tgsNM/hwhRAfj6VPIYKcNn SRdE5PgOBshCvRabzbztBxFP+svsg33eT/iYXEhNAvgVqbLfjYJ27YSZ+f2oEjLm1yDO AhQLpqmc/tmy1CFjkjoE2k7ynXOGtOgA9wC8FJHeG8CjoVUhMUY8rhuJgR4gWWk4TaFx BLGw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=liO5wucVGjUgl66CCyk5eCr9ee7CWFbOuaagBW74+qs=; b=SSb1Cum28JqlGXnJESUtd47yYtTEFg9wKIXbveCC8eByO3sAsbISPDRZPC5u4q/cLE NW5WaMxtfbKsEYvKjNTJIWcDyDMhFEcM4Nz+wlKai7NcfdE8cqToda1yUIWliJCzdV6r jcrpeqHkzRBX0RU8QDQGI7wLNIG9n45O5wU1uEVfd0F8r0W0Szit2YLaAZxXqimNTF6v I3dvhxRrpmVuRh1gFjCBDkQG95xtrv7+Drf5xiVnUzqTBCQFaNU08TE+03+0jTMjN55e 34U8D0MmpgDWFyba5UhA2qV7pNJr2Ws4Z7VZwWAZnaO2Jtp1yCyGjorQTRHC6h9xuS6l sgFQ== X-Gm-Message-State: AOAM532YeQZIxTLSJZdwq610wvK0trem9donwyQXZ96V0N85AL0lHNtF 03DWwaitvQu5+5qWiW2/shGS9A== X-Google-Smtp-Source: ABdhPJzb3jcmoJ3eeO2z7wKiK0sm764dKThMtyfcXT/S/xhsz1jMXke7rkEjfqjma4uFzTs051Dz9A== X-Received: by 2002:a5d:64ac:: with SMTP id m12mr4942109wrp.89.1627567209287; Thu, 29 Jul 2021 07:00:09 -0700 (PDT) Received: from google.com ([2a00:79e0:d:210:293a:bc89:7514:5218]) by smtp.gmail.com with ESMTPSA id l18sm9913097wmq.0.2021.07.29.07.00.08 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 29 Jul 2021 07:00:09 -0700 (PDT) Date: Thu, 29 Jul 2021 15:00:05 +0100 From: Quentin Perret To: Marc Zyngier Subject: Re: [PATCH] KVM: arm64: Unregister HYP sections from kmemleak in protected mode Message-ID: References: <20210729135016.3037277-1-maz@kernel.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20210729135016.3037277-1-maz@kernel.org> Cc: kernel-team@android.com, kvm@vger.kernel.org, stable@vger.kernel.org, Catalin Marinas , Will Deacon , kvmarm@lists.cs.columbia.edu, linux-arm-kernel@lists.infradead.org X-BeenThere: kvmarm@lists.cs.columbia.edu X-Mailman-Version: 2.1.14 Precedence: list List-Id: Where KVM/ARM decisions are made List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: kvmarm-bounces@lists.cs.columbia.edu Sender: kvmarm-bounces@lists.cs.columbia.edu On Thursday 29 Jul 2021 at 14:50:16 (+0100), Marc Zyngier wrote: > Booting a KVM host in protected mode with kmemleak quickly results > in a pretty bad crash, as kmemleak doesn't know that the HYP sections > have been taken away. > > Make the unregistration from kmemleak part of marking the sections > as HYP-private. The rest of the HYP-specific data is obtained via > the page allocator, which is not subjected to kmemleak. > > Fixes: 90134ac9cabb ("KVM: arm64: Protect the .hyp sections from the host") > Signed-off-by: Marc Zyngier > Cc: Quentin Perret > Cc: Catalin Marinas > Cc: stable@vger.kernel.org # 5.13 > --- > arch/arm64/kvm/arm.c | 7 ++++++- > 1 file changed, 6 insertions(+), 1 deletion(-) > > diff --git a/arch/arm64/kvm/arm.c b/arch/arm64/kvm/arm.c > index e9a2b8f27792..23f12e602878 100644 > --- a/arch/arm64/kvm/arm.c > +++ b/arch/arm64/kvm/arm.c > @@ -15,6 +15,7 @@ > #include > #include > #include > +#include > #include > #include > #include > @@ -1960,8 +1961,12 @@ static inline int pkvm_mark_hyp(phys_addr_t start, phys_addr_t end) > } > > #define pkvm_mark_hyp_section(__section) \ > +({ \ > + u64 sz = __section##_end - __section##_start; \ > + kmemleak_free_part(__section##_start, sz); \ > pkvm_mark_hyp(__pa_symbol(__section##_start), \ > - __pa_symbol(__section##_end)) > + __pa_symbol(__section##_end)); \ > +}) At some point we should also look into unmapping these sections from EL1 stage-1 as well, as that should lead to better error messages in case the host accesses hyp-private memory some other way. But this patch makes sense on its own, so: Reviewed-by: Quentin Perret Thanks, Quentin _______________________________________________ kvmarm mailing list kvmarm@lists.cs.columbia.edu https://lists.cs.columbia.edu/mailman/listinfo/kvmarm From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-20.4 required=3.0 tests=BAYES_00,DKIMWL_WL_MED, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,FSL_HELO_FAKE, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_IN_DEF_DKIM_WL autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9C4B5C43216 for ; Thu, 29 Jul 2021 14:10:08 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 864EE601FF for ; Thu, 29 Jul 2021 14:10:08 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S239111AbhG2OKJ (ORCPT ); Thu, 29 Jul 2021 10:10:09 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55620 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S238665AbhG2OHd (ORCPT ); Thu, 29 Jul 2021 10:07:33 -0400 Received: from mail-wr1-x434.google.com (mail-wr1-x434.google.com [IPv6:2a00:1450:4864:20::434]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 3EB00C0619EB for ; Thu, 29 Jul 2021 07:00:12 -0700 (PDT) Received: by mail-wr1-x434.google.com with SMTP id r2so7119561wrl.1 for ; Thu, 29 Jul 2021 07:00:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=liO5wucVGjUgl66CCyk5eCr9ee7CWFbOuaagBW74+qs=; b=EJ2F3ITFwEJ9rcPEvHQ6lQ2DOZnQ5vBtGtiPUiaEaUYZAeiKbLrc61I8wPZVT0mmce oMnATeCgB3nMSCmOY6JYICgTkdxdCA6cizvZWmE5FXgzbr/++FZUo4NbEvGTfoaVyNo1 0azpBzwCzgho7Xydbwqhu4X7ssL0HYuQtBhcVrHshYeuX/tgsNM/hwhRAfj6VPIYKcNn SRdE5PgOBshCvRabzbztBxFP+svsg33eT/iYXEhNAvgVqbLfjYJ27YSZ+f2oEjLm1yDO AhQLpqmc/tmy1CFjkjoE2k7ynXOGtOgA9wC8FJHeG8CjoVUhMUY8rhuJgR4gWWk4TaFx BLGw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=liO5wucVGjUgl66CCyk5eCr9ee7CWFbOuaagBW74+qs=; b=qu+hId/BSn+F7gvKs9c5yEj9KqWTHL8Q03zNa4LOr1XQIIM+qwVC14UWNrMxtgLjyS myx4a/C7G0sieA9NokZHAewVqMpMy2vaYx63CvJdFlvBxb7VrZfdw08vSES0vaMvdW32 h6OHzX2vrjuaRbH0d4Ehe2UyPf0fQB+C9emBarc6tC0AJsbsGGdY0nZlYWQMvEprbX64 FU+Gtd6fFkWIhuiMyuMcrA98jPKbVTirCXUWbU0NpyS2zaQt0O1EmTX/f40aaIk9IY4s K9fvcB1M7xSrSptzWSfBYJSGBGDvZOgJ/DLpH1Qs22ksJpVFkRZhywRtku66Aaob68nc JeZw== X-Gm-Message-State: AOAM533EcGlmPEf1T3C/uucx83IJSe/i1uvytIxDU6nARoQLkxnWXQfx cT6Jeu95uIzL9v5mcuuggfM1Iw== X-Google-Smtp-Source: ABdhPJzb3jcmoJ3eeO2z7wKiK0sm764dKThMtyfcXT/S/xhsz1jMXke7rkEjfqjma4uFzTs051Dz9A== X-Received: by 2002:a5d:64ac:: with SMTP id m12mr4942109wrp.89.1627567209287; Thu, 29 Jul 2021 07:00:09 -0700 (PDT) Received: from google.com ([2a00:79e0:d:210:293a:bc89:7514:5218]) by smtp.gmail.com with ESMTPSA id l18sm9913097wmq.0.2021.07.29.07.00.08 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 29 Jul 2021 07:00:09 -0700 (PDT) Date: Thu, 29 Jul 2021 15:00:05 +0100 From: Quentin Perret To: Marc Zyngier Cc: kvmarm@lists.cs.columbia.edu, kvm@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Will Deacon , James Morse , Suzuki K Poulose , Alexandru Elisei , kernel-team@android.com, Catalin Marinas , stable@vger.kernel.org Subject: Re: [PATCH] KVM: arm64: Unregister HYP sections from kmemleak in protected mode Message-ID: References: <20210729135016.3037277-1-maz@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210729135016.3037277-1-maz@kernel.org> Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org On Thursday 29 Jul 2021 at 14:50:16 (+0100), Marc Zyngier wrote: > Booting a KVM host in protected mode with kmemleak quickly results > in a pretty bad crash, as kmemleak doesn't know that the HYP sections > have been taken away. > > Make the unregistration from kmemleak part of marking the sections > as HYP-private. The rest of the HYP-specific data is obtained via > the page allocator, which is not subjected to kmemleak. > > Fixes: 90134ac9cabb ("KVM: arm64: Protect the .hyp sections from the host") > Signed-off-by: Marc Zyngier > Cc: Quentin Perret > Cc: Catalin Marinas > Cc: stable@vger.kernel.org # 5.13 > --- > arch/arm64/kvm/arm.c | 7 ++++++- > 1 file changed, 6 insertions(+), 1 deletion(-) > > diff --git a/arch/arm64/kvm/arm.c b/arch/arm64/kvm/arm.c > index e9a2b8f27792..23f12e602878 100644 > --- a/arch/arm64/kvm/arm.c > +++ b/arch/arm64/kvm/arm.c > @@ -15,6 +15,7 @@ > #include > #include > #include > +#include > #include > #include > #include > @@ -1960,8 +1961,12 @@ static inline int pkvm_mark_hyp(phys_addr_t start, phys_addr_t end) > } > > #define pkvm_mark_hyp_section(__section) \ > +({ \ > + u64 sz = __section##_end - __section##_start; \ > + kmemleak_free_part(__section##_start, sz); \ > pkvm_mark_hyp(__pa_symbol(__section##_start), \ > - __pa_symbol(__section##_end)) > + __pa_symbol(__section##_end)); \ > +}) At some point we should also look into unmapping these sections from EL1 stage-1 as well, as that should lead to better error messages in case the host accesses hyp-private memory some other way. But this patch makes sense on its own, so: Reviewed-by: Quentin Perret Thanks, Quentin