From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6033AC43216 for ; Fri, 30 Jul 2021 18:25:06 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 478E260F4B for ; Fri, 30 Jul 2021 18:25:06 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230184AbhG3SZK (ORCPT ); Fri, 30 Jul 2021 14:25:10 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46926 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230349AbhG3SZH (ORCPT ); Fri, 30 Jul 2021 14:25:07 -0400 Received: from mail-ot1-x32b.google.com (mail-ot1-x32b.google.com [IPv6:2607:f8b0:4864:20::32b]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5D39BC0613C1 for ; Fri, 30 Jul 2021 11:25:02 -0700 (PDT) Received: by mail-ot1-x32b.google.com with SMTP id x15-20020a05683000cfb02904d1f8b9db81so10440873oto.12 for ; Fri, 30 Jul 2021 11:25:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=XpB+LNmPBgnS5Lf6x+b5cG5d1sMq85HwbCnNpZE2zYo=; b=FLU28j8+ohjlgupR219GFzrIl9IH9/YzqxQJSUxHtE5VtGLhrgsFSje8to6mUj/aga x8nInA/4b1SZwqh/E285vMfeKvkbUkoZiHeV5oxS8JUVQLxRozEbb1HUzzi845CHrDBt bH1RLWLP2fGKQKmFMPdNozclJavXJ1RtQ9W1Ruat6YfxfmKna0mnbxpgJnpnz+MApimw JFI1/pM187pK04w61eo5JjNf2ZlDqDzDfs7YLwOWOmHFCAK24b6vFe2/nSOx/nPPc7fP IASY8hUWbtG53IMu3z7y0g2dS8huQ1EQq2BfmjIjTt84iWoT2Jk2MUoYLWoy37YbYT79 fwaA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=XpB+LNmPBgnS5Lf6x+b5cG5d1sMq85HwbCnNpZE2zYo=; b=L7QjOVtAKBPpYGj1ccCzl+j6YGswMuf1Lvg51e61gYHcKzUegIqujml3fPVqxkvhSN NdWBzdilNH0pn40HD7aq5tnFgwQVnSAcA/d2ivOJRTQg+PAN6bGoLnjn/YRt57ZIrs9W BnObdJgHJL2rI9c4RCDWPwWFscOLJIQmkQaO8HqmjcmWHKk2pg9rzkmFke1G31Jfg1SF Q6Ec10+gJ0MShDta+0L0kLqjbdJt+OBF4SC7r0MpYsE9amJfZ/pGXvk088oUHVfS5Uc4 vN8/1MW/HwLmY3ZZ0tJdGTqdzIAbpWymT9b0v+cDj0GY0U2j9axlh7wDrvHpSWRNEJXA 7UXQ== X-Gm-Message-State: AOAM530w5DUOWzQzA23J8HP03dpeGotlgayQIE6XuaMw72YW3/Vd1Zy3 52EbsOzwRyOahPBDNiwKcU99zw== X-Google-Smtp-Source: ABdhPJx4vNZHT6X7wQKRFb2JUuvmKANycbmxpNeZfUiQDWntbLArDTfaRDIDFIss/nuk9dA3LyoMKw== X-Received: by 2002:a05:6830:25c6:: with SMTP id d6mr3126063otu.226.1627669501571; Fri, 30 Jul 2021 11:25:01 -0700 (PDT) Received: from builder.lan (104-57-184-186.lightspeed.austtx.sbcglobal.net. [104.57.184.186]) by smtp.gmail.com with ESMTPSA id i10sm357103ood.48.2021.07.30.11.25.00 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 30 Jul 2021 11:25:01 -0700 (PDT) Date: Fri, 30 Jul 2021 13:24:58 -0500 From: Bjorn Andersson To: Sibi Sankar Cc: Matthias Kaehlcke , robh+dt@kernel.org, will@kernel.org, saiprakash.ranjan@codeaurora.org, ohad@wizery.com, agross@kernel.org, mathieu.poirier@linaro.org, robin.murphy@arm.com, joro@8bytes.org, p.zabel@pengutronix.de, linux-arm-msm@vger.kernel.org, linux-remoteproc@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, evgreen@chromium.org, dianders@chromium.org, swboyd@chromium.org Subject: Re: [PATCH 6/9] arm64: dts: qcom: sc7280: Update reserved memory map Message-ID: References: <1624564058-24095-1-git-send-email-sibis@codeaurora.org> <1624564058-24095-7-git-send-email-sibis@codeaurora.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed 30 Jun 15:02 CDT 2021, Sibi Sankar wrote: > On 2021-06-28 23:41, Matthias Kaehlcke wrote: > > On Fri, Jun 25, 2021 at 01:17:35AM +0530, Sibi Sankar wrote: > > > > > Subject: arm64: dts: qcom: sc7280: Update reserved memory map > > > > That's very vague. Also personally I'm not a fan of patches that touch > > SoC and board files with a commit message that only mentions the SoC, as > > is frequently done for IDP boards. Why not split this in (at least) two, > > one for adding the missing memory regions to the SoC, and one for the > > IDP. > > > > sure will split this up. > > > > Add missing regions and remove unused regions from the reserved memory > > > map, as described in version 1. > > > > What is this 'version 1'? > > lol, it's the memory map version number > and it's not entirely internal to qc so > we have been mentioning them in commit > messages from older SoCs. I'll just drop > it when I re-spin the series since it > doesn't add much value. > Every now and then we run into issues with the reserved-memory layout, where knowing were the numbers comes from is useful information to have in order to characterize the issue and come up with a fix. So including information about where those numbers came from is useful, even if it's referencing a version of a document that's not public. Regards, Bjorn From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.5 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id ABE95C432BE for ; Fri, 30 Jul 2021 18:27:56 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 707C260C3F for ; Fri, 30 Jul 2021 18:27:56 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 707C260C3F Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=CEuEXIp3Rice9bURiiudMxq7Di8DZT3mqxQrFyj5M/k=; b=NV85LfmJRdEfew jzIwpUWylDy1dx9u2A5VyFg7SRoDQwKPy7GJRhz3ZS5Ws0P81+mrQjNPo3A6RFLU4grRtXbwy2tmM d1auTPxCKmbRMLtjJj95byjwXAoe1hb0X3Kpj5j8RBAblAP1QyDTTa1fmB39h5llzxQYto5eefioa XMVVBlTf+C35RAuOzo75B1Zw8N4qb5toFcQ4SLp47DjaPpI15ur3JbMZt+04cTPMLlDaKQJ9CRObC b8c9twQksMnc8ca+IuLphEfIL02MEn71l80mQJlL9CkLWqbT9g90W3jnzAYS4DYJebm5rpdfmymVd 5gwfITM7mikGUhNLCecQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1m9XCM-009wBe-93; Fri, 30 Jul 2021 18:25:30 +0000 Received: from mail-ot1-x32f.google.com ([2607:f8b0:4864:20::32f]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1m9XBv-009w7v-77 for linux-arm-kernel@lists.infradead.org; Fri, 30 Jul 2021 18:25:04 +0000 Received: by mail-ot1-x32f.google.com with SMTP id h63-20020a9d14450000b02904ce97efee36so10461154oth.7 for ; Fri, 30 Jul 2021 11:25:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=XpB+LNmPBgnS5Lf6x+b5cG5d1sMq85HwbCnNpZE2zYo=; b=FLU28j8+ohjlgupR219GFzrIl9IH9/YzqxQJSUxHtE5VtGLhrgsFSje8to6mUj/aga x8nInA/4b1SZwqh/E285vMfeKvkbUkoZiHeV5oxS8JUVQLxRozEbb1HUzzi845CHrDBt bH1RLWLP2fGKQKmFMPdNozclJavXJ1RtQ9W1Ruat6YfxfmKna0mnbxpgJnpnz+MApimw JFI1/pM187pK04w61eo5JjNf2ZlDqDzDfs7YLwOWOmHFCAK24b6vFe2/nSOx/nPPc7fP IASY8hUWbtG53IMu3z7y0g2dS8huQ1EQq2BfmjIjTt84iWoT2Jk2MUoYLWoy37YbYT79 fwaA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=XpB+LNmPBgnS5Lf6x+b5cG5d1sMq85HwbCnNpZE2zYo=; b=ZulWAi1Z7V1jXBRa46dG6fL5VotSLEDLKBErqTGNMR0zIGbdQlXIqIHqWDdW14idYo dPYe7UY6OB162iOjQW8GfC8Gofxt6ksNn+yWgQqhJEjD8PYvt8cq8Co1dgnJP9B+mcdt ooMhK5fFRFXf5RmywuwISp57D7ILepZDqgR7/E8bNZkONnwpIT6FItN6jF1EXwyk04MD KZtYPWC6PgX4hMXkCuFMMdeLxYMcx3JDQlj4FRsRWhvNWI+7OyK3Kux3DxX5EAz3JkSW 8kmxLKjbu5Joygtx6dGZtnMwxoRGSmmOQknE96PYCSZ9e6XNCgBeIWp1jgHhl636Wuzy qZgQ== X-Gm-Message-State: AOAM5326pg2tg3nmlhUzCAz4LisHh94Gj7xMz3YLjp3jkFvJ/f2JGj/y VROqhvYmXqJP/gR0RGa2+1QX2A== X-Google-Smtp-Source: ABdhPJx4vNZHT6X7wQKRFb2JUuvmKANycbmxpNeZfUiQDWntbLArDTfaRDIDFIss/nuk9dA3LyoMKw== X-Received: by 2002:a05:6830:25c6:: with SMTP id d6mr3126063otu.226.1627669501571; Fri, 30 Jul 2021 11:25:01 -0700 (PDT) Received: from builder.lan (104-57-184-186.lightspeed.austtx.sbcglobal.net. [104.57.184.186]) by smtp.gmail.com with ESMTPSA id i10sm357103ood.48.2021.07.30.11.25.00 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 30 Jul 2021 11:25:01 -0700 (PDT) Date: Fri, 30 Jul 2021 13:24:58 -0500 From: Bjorn Andersson To: Sibi Sankar Cc: Matthias Kaehlcke , robh+dt@kernel.org, will@kernel.org, saiprakash.ranjan@codeaurora.org, ohad@wizery.com, agross@kernel.org, mathieu.poirier@linaro.org, robin.murphy@arm.com, joro@8bytes.org, p.zabel@pengutronix.de, linux-arm-msm@vger.kernel.org, linux-remoteproc@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, evgreen@chromium.org, dianders@chromium.org, swboyd@chromium.org Subject: Re: [PATCH 6/9] arm64: dts: qcom: sc7280: Update reserved memory map Message-ID: References: <1624564058-24095-1-git-send-email-sibis@codeaurora.org> <1624564058-24095-7-git-send-email-sibis@codeaurora.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210730_112503_301875_E9C03859 X-CRM114-Status: GOOD ( 23.22 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed 30 Jun 15:02 CDT 2021, Sibi Sankar wrote: > On 2021-06-28 23:41, Matthias Kaehlcke wrote: > > On Fri, Jun 25, 2021 at 01:17:35AM +0530, Sibi Sankar wrote: > > > > > Subject: arm64: dts: qcom: sc7280: Update reserved memory map > > > > That's very vague. Also personally I'm not a fan of patches that touch > > SoC and board files with a commit message that only mentions the SoC, as > > is frequently done for IDP boards. Why not split this in (at least) two, > > one for adding the missing memory regions to the SoC, and one for the > > IDP. > > > > sure will split this up. > > > > Add missing regions and remove unused regions from the reserved memory > > > map, as described in version 1. > > > > What is this 'version 1'? > > lol, it's the memory map version number > and it's not entirely internal to qc so > we have been mentioning them in commit > messages from older SoCs. I'll just drop > it when I re-spin the series since it > doesn't add much value. > Every now and then we run into issues with the reserved-memory layout, where knowing were the numbers comes from is useful information to have in order to characterize the issue and come up with a fix. So including information about where those numbers came from is useful, even if it's referencing a version of a document that's not public. Regards, Bjorn _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel