From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.4 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7D90CC432BE for ; Wed, 11 Aug 2021 07:29:09 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 6177F60FC0 for ; Wed, 11 Aug 2021 07:29:09 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231539AbhHKH3b (ORCPT ); Wed, 11 Aug 2021 03:29:31 -0400 Received: from mail.kernel.org ([198.145.29.99]:44628 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235502AbhHKH33 (ORCPT ); Wed, 11 Aug 2021 03:29:29 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 1D7DC60EBD; Wed, 11 Aug 2021 07:29:05 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1628666946; bh=pRQZSx3XWLGdwaXfIsQOAgpolYggzCai5Yf7G6+I4ag=; h=Date:From:To:Subject:References:In-Reply-To:From; b=HJA5LvM/i3BqBPc0dBTDDcqyEil40lAoi5lhKt3nl0kUiSf7BrKaJZqixpXnjyyT1 uvxNCbWv5PaeaXFRE5hsl32ls5IGhlgdEcb5efJLARVrSkic4nb/eL20xHwOIvFFXH xR8ExmJX0IJrIbhbr9qOP+UAW7v5NF+P0oGg+p6s= Date: Wed, 11 Aug 2021 09:29:04 +0200 From: Greg Kroah-Hartman To: Wolfram Sang , linux-i2c@vger.kernel.org, linux-kernel@vger.kernel.org, Eric Dumazet , Dan Carpenter , stable Subject: Re: [PATCH v2] i2c: dev: zero out array used for i2c reads from userspace Message-ID: References: <20210729143532.47240-1-gregkh@linuxfoundation.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Aug 10, 2021 at 10:55:11PM +0200, Wolfram Sang wrote: > On Thu, Jul 29, 2021 at 04:35:32PM +0200, Greg Kroah-Hartman wrote: > > If an i2c driver happens to not provide the full amount of data that a > > user asks for, it is possible that some uninitialized data could be sent > > to userspace. While all in-kernel drivers look to be safe, just be sure > > by initializing the buffer to zero before it is passed to the i2c driver > > so that any future drivers will not have this issue. > > > > Also properly copy the amount of data recvieved to the userspace buffer, > > as pointed out by Dan Carpenter. > > > > Reported-by: Eric Dumazet > > Cc: Dan Carpenter > > Cc: stable > > Signed-off-by: Greg Kroah-Hartman > > Fixed checkpatch warning "WARNING: Invalid email format for stable: > 'stable ', prefer 'stable@vger.kernel.org' " and > applied to for-current, thanks! That is a crazy warning, never even knew it was there. But as the stable maintainer, it does not look correct as both are just fine... Anyway, thanks for taking the patch! greg k-h