From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Cai Huoqing <caihuoqing@baidu.com>
Cc: Rob Herring <robh+dt@kernel.org>,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-staging@lists.linux.dev
Subject: Re: [PATCH v3 1/3] staging: zynpu: Add driver support for ARM(China) ZHOUYI AI accelerator
Date: Fri, 26 Nov 2021 07:43:34 +0100 [thread overview]
Message-ID: <YaCCFv2DLzeng+UE@kroah.com> (raw)
In-Reply-To: <20211126021904.32325-2-caihuoqing@baidu.com>
On Fri, Nov 26, 2021 at 10:18:59AM +0800, Cai Huoqing wrote:
> ZHOUYI NPU is an AI accelerator chip which is integrated into ARM SOC,
> such as Allwinner R329 SOC.
> Add driver support for this AI accelerator here.
>
> This driver is not standard linux style, there are some clean up works,
> fixing code style, refactorring.
> And it only works with a closed source usermode driver, so need to
> reverse the libraries, and impelement it, then open source
> the usermode driver.
> So add this driver to linux-staging
Sorry, but no, I can not take this driver into the kernel tree until
there is an open source user of the new api that you are creating with
this driver. This was discussed many times on the linux-kernel mailing
list and at the Linux kernel summit a few months ago (see the summary at
lwn.net about it.)
So please work on that first, and then we will be glad to revisit taking
this kernel driver into the tree.
Also, it is much simpler just to take a few hours and clean up the
coding style issues yourself rather than relying on the community to do
it for you over a few months.
thanks,
greg k-h
next prev parent reply other threads:[~2021-11-26 6:45 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-26 2:18 [PATCH v3 0/3] staging: zynpu: Add driver support for ARM(China) ZHOUYI AI accelerator Cai Huoqing
2021-11-26 2:18 ` [PATCH v3 1/3] " Cai Huoqing
2021-11-26 6:43 ` Greg Kroah-Hartman [this message]
2021-11-26 7:14 ` Cai Huoqing
2021-12-01 3:15 ` Cai Huoqing
2021-11-26 2:19 ` [PATCH v3 2/3] dt-bindings: staging: Add the binding documentation for " Cai Huoqing
2021-11-26 6:44 ` Greg Kroah-Hartman
2021-11-29 1:12 ` Rob Herring
2021-11-26 2:19 ` [PATCH v2 3/3] MAINTAINERS: Add the driver info of the " Cai Huoqing
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YaCCFv2DLzeng+UE@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=caihuoqing@baidu.com \
--cc=devicetree@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.