From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3B316C433FE for ; Thu, 3 Feb 2022 19:34:45 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S237774AbiBCTen (ORCPT ); Thu, 3 Feb 2022 14:34:43 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44750 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234820AbiBCTek (ORCPT ); Thu, 3 Feb 2022 14:34:40 -0500 Received: from bombadil.infradead.org (bombadil.infradead.org [IPv6:2607:7c80:54:e::133]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 014FDC06173D; Thu, 3 Feb 2022 11:34:39 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=Sender:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=YFLdf+yXWDyqnOqAs6w9z7uJ08NBv+2fURUugK0F1GY=; b=QQoe4UndTJBd/gJfKiwRzpeeet 4JmUN6YpnNX9DYIvdhEW4gGAmzAY4iJcrT9+yl+7RzK9VJRfM6X00mNxkFqcYaMpmB9Au9hsgWlZD ngUcGTa0+FogmMxQCXHNIL1F42PEbXs8Dq3IqSgYJKGdCSESKgpRydfKBWHGQQgemhvrjmcYCl0cx swBpj2g5oWkXqtlDRS1EyJVf3Cqs+N53XPhC8TLYUZk1qdQbnnwAN8ZRRpI3s8GI9soK4wlp0kc6Z eTKXzrjjQbuiQC+xv1PdI0pTr+z6M50XJHX3xneAkraCF4vlAV9pBIkIU8SJGKKLMQF2JJikhHnss OQit0XrQ==; Received: from mcgrof by bombadil.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1nFhsB-002b1R-NQ; Thu, 03 Feb 2022 19:34:27 +0000 Date: Thu, 3 Feb 2022 11:34:27 -0800 From: Luis Chamberlain To: Christoph Hellwig , Keith Busch Cc: Adam Manzanares , Vincent Fu , Mikulas Patocka , Javier =?iso-8859-1?Q?Gonz=E1lez?= , Chaitanya Kulkarni , "linux-block@vger.kernel.org" , "linux-scsi@vger.kernel.org" , "dm-devel@redhat.com" , "linux-nvme@lists.infradead.org" , linux-fsdevel , Jens Axboe , "msnitzer@redhat.com >> msnitzer@redhat.com" , Bart Van Assche , "martin.petersen@oracle.com >> Martin K. Petersen" , "roland@purestorage.com" , Hannes Reinecke , "kbus @imap.gmail.com>> Keith Busch" , "Frederick.Knight@netapp.com" , "zach.brown@ni.com" , "osandov@fb.com" , "lsf-pc@lists.linux-foundation.org" , "djwong@kernel.org" , "josef@toxicpanda.com" , "clm@fb.com" , "dsterba@suse.com" , "tytso@mit.edu" , "jack@suse.com" , Kanchan Joshi Subject: Re: [RFC PATCH 3/3] nvme: add the "debug" host driver Message-ID: References: <20220201102122.4okwj2gipjbvuyux@mpHalley-2> <20220202060154.GA120951@bgt-140510-bm01> <20220203160633.rdwovqoxlbr3nu5u@garbanzo> <20220203161534.GA15366@lst.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220203161534.GA15366@lst.de> Sender: Luis Chamberlain Precedence: bulk List-ID: X-Mailing-List: linux-block@vger.kernel.org On Thu, Feb 03, 2022 at 05:15:34PM +0100, Christoph Hellwig wrote: > On Thu, Feb 03, 2022 at 08:06:33AM -0800, Luis Chamberlain wrote: > > On Wed, Feb 02, 2022 at 06:01:13AM +0000, Adam Manzanares wrote: > > > BTW I think having the target code be able to implement simple copy without > > > moving data over the fabric would be a great way of showing off the command. > > > > Do you mean this should be implemented instead as a fabrics backend > > instead because fabrics already instantiates and creates a virtual > > nvme device? And so this would mean less code? > > It would be a lot less code. In fact I don't think we need any new code > at all. Just using nvme-loop on top of null_blk or brd should be all > that is needed. Mikulas, That begs the question why add this instead of using null_blk with nvme-loop? Luis From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id E4E6FC433EF for ; Thu, 3 Feb 2022 19:55:41 +0000 (UTC) Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-361-nKgEgtgeMyav6L0-ruvLsQ-1; Thu, 03 Feb 2022 14:55:39 -0500 X-MC-Unique: nKgEgtgeMyav6L0-ruvLsQ-1 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 5C329851A18; Thu, 3 Feb 2022 19:55:33 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.20]) by smtp.corp.redhat.com (Postfix) with ESMTPS id A19A9D4BE6; Thu, 3 Feb 2022 19:55:32 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id E1CDB1809CB8; Thu, 3 Feb 2022 19:55:29 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx09.intmail.prod.int.rdu2.redhat.com [10.11.54.9]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id 213JtRPu009722 for ; Thu, 3 Feb 2022 14:55:27 -0500 Received: by smtp.corp.redhat.com (Postfix) id 1D8A5492CA8; Thu, 3 Feb 2022 19:55:27 +0000 (UTC) Received: from mimecast-mx02.redhat.com (mimecast07.extmail.prod.ext.rdu2.redhat.com [10.11.55.23]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 19C3A492D54 for ; Thu, 3 Feb 2022 19:55:27 +0000 (UTC) Received: from us-smtp-1.mimecast.com (us-smtp-delivery-1.mimecast.com [207.211.31.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id F36CB3C01C25 for ; Thu, 3 Feb 2022 19:55:26 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-349-eLNgnjCcM4SFmNCAwRBfvQ-1; Thu, 03 Feb 2022 14:55:24 -0500 X-MC-Unique: eLNgnjCcM4SFmNCAwRBfvQ-1 Received: from mcgrof by bombadil.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1nFhsB-002b1R-NQ; Thu, 03 Feb 2022 19:34:27 +0000 Date: Thu, 3 Feb 2022 11:34:27 -0800 From: Luis Chamberlain To: Christoph Hellwig , Keith Busch Message-ID: References: <20220201102122.4okwj2gipjbvuyux@mpHalley-2> <20220202060154.GA120951@bgt-140510-bm01> <20220203160633.rdwovqoxlbr3nu5u@garbanzo> <20220203161534.GA15366@lst.de> MIME-Version: 1.0 In-Reply-To: <20220203161534.GA15366@lst.de> X-Mimecast-Impersonation-Protect: Policy=CLT - Impersonation Protection Definition; Similar Internal Domain=false; Similar Monitored External Domain=false; Custom External Domain=false; Mimecast External Domain=false; Newly Observed Domain=false; Internal User Name=false; Custom Display Name List=false; Reply-to Address Mismatch=false; Targeted Threat Dictionary=false; Mimecast Threat Dictionary=false; Custom Threat Dictionary=false X-Scanned-By: MIMEDefang 2.85 on 10.11.54.9 X-loop: dm-devel@redhat.com Cc: Vincent Fu , "djwong@kernel.org" , "linux-nvme@lists.infradead.org" , "clm@fb.com" , "dm-devel@redhat.com" , Adam Manzanares , "osandov@fb.com" , Javier =?iso-8859-1?Q?Gonz=E1lez?= , Bart Van Assche , "linux-scsi@vger.kernel.org" , "roland@purestorage.com" , "zach.brown@ni.com" , "dsterba@suse.com" , Chaitanya Kulkarni , "msnitzer@redhat.com >> msnitzer@redhat.com" , "josef@toxicpanda.com" , "linux-block@vger.kernel.org" , Mikulas Patocka , "kbus @imap.gmail.com>> Keith Busch" , "Frederick.Knight@netapp.com" , Jens Axboe , "tytso@mit.edu" , Kanchan Joshi , "martin.petersen@oracle.com >> Martin K. Petersen" , "jack@suse.com" , linux-fsdevel , "lsf-pc@lists.linux-foundation.org" Subject: Re: [dm-devel] [RFC PATCH 3/3] nvme: add the "debug" host driver X-BeenThere: dm-devel@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: device-mapper development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: dm-devel-bounces@redhat.com Errors-To: dm-devel-bounces@redhat.com X-Scanned-By: MIMEDefang 2.79 on 10.5.11.15 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=dm-devel-bounces@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Disposition: inline Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit On Thu, Feb 03, 2022 at 05:15:34PM +0100, Christoph Hellwig wrote: > On Thu, Feb 03, 2022 at 08:06:33AM -0800, Luis Chamberlain wrote: > > On Wed, Feb 02, 2022 at 06:01:13AM +0000, Adam Manzanares wrote: > > > BTW I think having the target code be able to implement simple copy without > > > moving data over the fabric would be a great way of showing off the command. > > > > Do you mean this should be implemented instead as a fabrics backend > > instead because fabrics already instantiates and creates a virtual > > nvme device? And so this would mean less code? > > It would be a lot less code. In fact I don't think we need any new code > at all. Just using nvme-loop on top of null_blk or brd should be all > that is needed. Mikulas, That begs the question why add this instead of using null_blk with nvme-loop? Luis -- dm-devel mailing list dm-devel@redhat.com https://listman.redhat.com/mailman/listinfo/dm-devel