From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id A7506C433EF for ; Mon, 27 Jun 2022 08:39:46 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 49FBF82064; Mon, 27 Jun 2022 10:39:44 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (2048-bit key; unprotected) header.d=linaro.org header.i=@linaro.org header.b="pzBd7NMD"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 8207A820B3; Mon, 27 Jun 2022 10:39:42 +0200 (CEST) Received: from mail-wm1-x32b.google.com (mail-wm1-x32b.google.com [IPv6:2a00:1450:4864:20::32b]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 11C87801C3 for ; Mon, 27 Jun 2022 10:39:40 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=lee.jones@linaro.org Received: by mail-wm1-x32b.google.com with SMTP id o19-20020a05600c4fd300b003a0489f414cso1589152wmq.4 for ; Mon, 27 Jun 2022 01:39:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to; bh=m8zyGouK+jYbu84Ek7YSt5Cu0Iq/4HFH2eIwspEbTI4=; b=pzBd7NMDK0BBZDqrigXvvwv4w8gChmuPXXDlPPZo1RM5o9fE0RHfAhhPoSR4NRVcuO CuAjKrb98Rg/Us+WY72qvF+6RzUvaQaGcNJV2klp9Kqay71MXKGHeRG4amKgsY3nhmR7 8IXaf56Pmt5OAWzxxaGhukRTKUQXDJWHcnZ9QpOEH4A5PuwO/nl4hz6wTCQWLru69vEl FQkLnRGVI7WU5bbPNPoSXC4ryd6mePOwjxwBPeabLO/AjOZLlBLCYsvgluludXRRmop7 sTPwHFhyMmqxyMfoZPGtnyZRRPwz2SVBczfJfl51oOUuj1W4KIJEN7lvTgYQDZB2YtWo ZLCw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to; bh=m8zyGouK+jYbu84Ek7YSt5Cu0Iq/4HFH2eIwspEbTI4=; b=p66SqjTby0FN3wQNsJSwBEX85oaxZpN5VFhbuRJDXrPlh8Z1nyj1yMfA+7NBAclIcn c/K/yVL6dProIz8UOZkx0QGYkInb3gwRJW7BuNuZO+EmiO9KnTcBObXAkED4VuLbJs7H i/+S5nW/v28GZfrbzVtYzYmLWWsdxjUPXSp8BfYyCDwl30PJ8uBUNZKW1aOXn2qSQnwK DhdSvUFHLE29oVA3cbKYKQZVH/O+fr91DYZH6HFduWbgDteiiBywxFV2O6c2GeXN+FCd OhiSY/51isLgtIqRFLiSUmsQziMNRUjmrOS+8VnjxDcDKLtq3zLLeQExbXBTOOf36gtw OMSQ== X-Gm-Message-State: AJIora8ZKc/hEahBdTO21xZmfXX2MjyyY5FhefCbQSfS9ot1VKQKaff3 r6hmESQ1K6y7O0VskiruPlYkY1L4TDRJ2A== X-Google-Smtp-Source: AGRyM1u5ou6TWFjMUV0lzAlhDmlCVmb67ra0b1F8maaEp93Q5Gk36VyWtta6gLRVzn43rO0C0e8S/g== X-Received: by 2002:a7b:c242:0:b0:3a0:3ba5:81fd with SMTP id b2-20020a7bc242000000b003a03ba581fdmr18030310wmj.47.1656319179545; Mon, 27 Jun 2022 01:39:39 -0700 (PDT) Received: from google.com (cpc155339-bagu17-2-0-cust87.1-3.cable.virginm.net. [86.27.177.88]) by smtp.gmail.com with ESMTPSA id j22-20020a05600c485600b0039aef592ca0sm12480030wmo.35.2022.06.27.01.39.38 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 27 Jun 2022 01:39:38 -0700 (PDT) Date: Mon, 27 Jun 2022 09:39:37 +0100 From: Lee Jones To: sjg@chromium.org, philipp.tomsich@vrull.eu, kever.yang@rock-chips.com Cc: cym@rock-chips.com, u-boot@lists.denx.de Subject: Re: [PATCH 1/3] ram: rk3399: Fix .set_rate_index() error handling Message-ID: References: <20220621100729.979275-1-lee.jones@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20220621100729.979275-1-lee.jones@linaro.org> X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.6 at phobos.denx.de X-Virus-Status: Clean On Tue, 21 Jun 2022, Lee Jones wrote: > Functions pointed to by this op pointer can return non-zero values > indicating an error. Ensure any error value is propagated back up the > call-chain. > > Signed-off-by: Lee Jones > --- > drivers/ram/rockchip/sdram_rk3399.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) Weekly check-in: Are these still on someone's radar, or would you like me to [RESEND]? > diff --git a/drivers/ram/rockchip/sdram_rk3399.c b/drivers/ram/rockchip/sdram_rk3399.c > index c0a06dcaed..0af0fa9e7b 100644 > --- a/drivers/ram/rockchip/sdram_rk3399.c > +++ b/drivers/ram/rockchip/sdram_rk3399.c > @@ -3005,7 +3005,9 @@ static int sdram_init(struct dram_info *dram, > params->base.stride = calculate_stride(params); > dram_all_config(dram, params); > > - dram->ops->set_rate_index(dram, params); > + ret = dram->ops->set_rate_index(dram, params); > + if (ret) > + return ret; > > debug("Finish SDRAM initialization...\n"); > return 0; -- Lee Jones [李琼斯] Principal Technical Lead - Developer Services Linaro.org │ Open source software for Arm SoCs Follow Linaro: Facebook | Twitter | Blog