From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id D59BEC43334 for ; Mon, 4 Jul 2022 09:24:03 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id AF89D84307; Mon, 4 Jul 2022 11:24:00 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (2048-bit key; unprotected) header.d=linaro.org header.i=@linaro.org header.b="U+GUB1Mm"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id E61D384307; Mon, 4 Jul 2022 11:23:59 +0200 (CEST) Received: from mail-wr1-x42d.google.com (mail-wr1-x42d.google.com [IPv6:2a00:1450:4864:20::42d]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 849B784335 for ; Mon, 4 Jul 2022 11:23:55 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=lee.jones@linaro.org Received: by mail-wr1-x42d.google.com with SMTP id n4so5160332wru.11 for ; Mon, 04 Jul 2022 02:23:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to; bh=bZY2B46vgtp/CWwuF2pJdhjfIFbzgjE35xykYt6Gkn0=; b=U+GUB1Mmn6vCkeOfkfbjEPd4z1OqhKHa4f27y1VWi2zGbqzhGOKYG/Bqkzgt1vzpvf tfEWI9uED8hjAZBmhQH5T9jkjdwXulIHfQqYYML3WyGDreYL16u7GXFowVRA/nhYbaSD GcFXwFFVZXbXvRwtbJ2YW4EMiq+UwimERpRwVCbQTptnS96pW4zDMoKO34pIN1y5WQXH byi5t8y9qi8uRHzHZYrYLlUhXkpBmpOSQpGQ/EGkvRwJqljcK326FRrk9XQ2NjAE6YR1 kqIS4KQVMvhmGlpW3q3tEGjB4Kwc+DsIZzfOoJEwJ10X5UAhS0mb/l+8PZI8H8MJLsU2 28fw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to; bh=bZY2B46vgtp/CWwuF2pJdhjfIFbzgjE35xykYt6Gkn0=; b=7gCqU940qEqriDP7cRK0nJbXfiwBRjzXr9l+hq1gbk6yBIrZHbQp7ZvkS6zTwq2bk9 BMZX0+rYMN9o1HDyZ3GEb0lt9evrUP92WO9Odlxi7+yxuETdrWIohVj5CqEICaH/dOy1 hJgeap0p0T8ELXllLAFXKzgLGU+UAnPq9XkMhgLP+nBMsojVo2tsvI6FmJqWlwIpU/1v E18IgO85pP0fjYmlWoE2QE1YeQAyZzrZclO6qRnVhe4vMxzZZ0FisRXc/QGeEx6jjMh1 WERceu2cdVflNsD9fRbJ9l4FxKpxepVcCGPuif4bKSzk2GdpadlSuU9FpU2TH1sKMLRb ggVw== X-Gm-Message-State: AJIora8KaQMxRegx83/4O5j0e/QFaX0CXnX+Wn60z4Uyp8WAt2pxHweE BeR288mQhWYJSxokq0fD3fJimA== X-Google-Smtp-Source: AGRyM1v3kleAmBISUTq9UweKY3Dsn2Gd1ZwdFoK96+ObYoFx0hKlBkvrzHVSkhUSSReAK9MscLgrjg== X-Received: by 2002:a05:6000:107:b0:21b:8ef9:96cb with SMTP id o7-20020a056000010700b0021b8ef996cbmr25518880wrx.709.1656926634947; Mon, 04 Jul 2022 02:23:54 -0700 (PDT) Received: from google.com (cpc155339-bagu17-2-0-cust87.1-3.cable.virginm.net. [86.27.177.88]) by smtp.gmail.com with ESMTPSA id n5-20020a1ca405000000b0039c587342d8sm14936321wme.3.2022.07.04.02.23.54 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 04 Jul 2022 02:23:54 -0700 (PDT) Date: Mon, 4 Jul 2022 10:23:52 +0100 From: Lee Jones To: Kever Yang Cc: sjg@chromium.org, philipp.tomsich@vrull.eu, cym@rock-chips.com, u-boot@lists.denx.de Subject: Re: [PATCH 1/3] ram: rk3399: Fix .set_rate_index() error handling Message-ID: References: <20220621100729.979275-1-lee.jones@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.6 at phobos.denx.de X-Virus-Status: Clean On Fri, 01 Jul 2022, Kever Yang wrote: > Hi Lee Jones, > > > On 2022/6/27 16:39, Lee Jones wrote: > > On Tue, 21 Jun 2022, Lee Jones wrote: > > > > > Functions pointed to by this op pointer can return non-zero values > > > indicating an error. Ensure any error value is propagated back up the > > > call-chain. > > > > > > Signed-off-by: Lee Jones > > > --- > > > drivers/ram/rockchip/sdram_rk3399.c | 4 +++- > > > 1 file changed, 3 insertions(+), 1 deletion(-) > > Weekly check-in: > > > > Are these still on someone's radar, or would you like me to [RESEND]? > > It would be better to add leading message "rockchip:" in the subject. That would be highly unusual. Patch subjects are usually formed, as follows: ": : " I only see 2 RAM-only patches (out of the 91 that touch this file) that do as you suggested and you were the author of both of them. :) -- Lee Jones [李琼斯] Principal Technical Lead - Developer Services Linaro.org │ Open source software for Arm SoCs Follow Linaro: Facebook | Twitter | Blog