From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5AC37C25B08 for ; Wed, 17 Aug 2022 08:50:16 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235502AbiHQIuO (ORCPT ); Wed, 17 Aug 2022 04:50:14 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50466 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230514AbiHQIuL (ORCPT ); Wed, 17 Aug 2022 04:50:11 -0400 Received: from mail.skyhub.de (mail.skyhub.de [IPv6:2a01:4f8:190:11c2::b:1457]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7D0406A489; Wed, 17 Aug 2022 01:50:10 -0700 (PDT) Received: from zn.tnic (p200300ea971b9855329c23fffea6a903.dip0.t-ipconnect.de [IPv6:2003:ea:971b:9855:329c:23ff:fea6:a903]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.skyhub.de (SuperMail on ZX Spectrum 128k) with ESMTPSA id BFF501EC04F0; Wed, 17 Aug 2022 10:50:04 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=alien8.de; s=dkim; t=1660726204; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:in-reply-to:in-reply-to: references:references; bh=1Nc9t7mJDNJm7tX2tDtri09eHBfV+Ex+cKn6gDnLpQc=; b=GcbLLw8ZpGKMrGQvsebCopv6bxKAXNMYcNfrs/TS+KIQqjHHVTyMTCVsFZ8if02hCMOvYR aNEOyZ/tUNxQbGU9Y+dJCxmS1HzRbnYVUvKQswbw1s/TfpbCdWF71i138SESUjd56D1C0n L0ynhx3AO0JdOJsu3Jwtf+RshCVT0Sw= Date: Wed, 17 Aug 2022 10:50:00 +0200 From: Borislav Petkov To: "Kani, Toshi" Cc: Justin He , Ard Biesheuvel , Len Brown , James Morse , Tony Luck , Mauro Carvalho Chehab , Robert Richter , Robert Moore , "linux-acpi@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "linux-edac@vger.kernel.org" , "devel@acpica.org" , "Rafael J . Wysocki" , Shuai Xue , Jarkko Sakkinen , "linux-efi@vger.kernel.org" , nd , "stable@kernel.org" Subject: Re: [PATCH 2/2] EDAC/ghes: Modularize ghes_edac driver to remove the dependency on ghes Message-ID: References: <20220811091713.10427-1-justin.he@arm.com> <20220811091713.10427-3-justin.he@arm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Aug 17, 2022 at 01:39:32AM +0000, Kani, Toshi wrote: > Yes, but the impact is not necessarily limited to these modules. The impact is limited only to the modules which would otherwise potentially load on a HP system which advertizes as "HPE ", "Server ". You're the only user of ghes_edac. So please state which drivers you want blocked from loading on those platforms and where ghes_edac should load instead. >From looking at 301375e76432 ("EDAC: Add owner check to the x86 platform drivers") it is 4 drivers. > I think a new check with ghes_get_device() can replace the owner check > in xx_init(). The owner thing should not be touched now - it can be a cleanup ontop if you - Justin - feel like doing it afterwards. Thx. -- Regards/Gruss, Boris. https://people.kernel.org/tglx/notes-about-netiquette