From: Mark Brown <broonie@kernel.org>
To: "Martin Povišer" <povik+lin@cutebit.org>
Cc: devicetree@vger.kernel.org, alsa-devel@alsa-project.org,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Sven Peter <sven@svenpeter.dev>, Hector Martin <marcan@marcan.st>,
Liam Girdwood <lgirdwood@gmail.com>,
linux-kernel@vger.kernel.org, Rob Herring <robh+dt@kernel.org>,
asahi@lists.linux.dev, Philipp Zabel <p.zabel@pengutronix.de>,
Alyssa Rosenzweig <alyssa@rosenzweig.io>
Subject: Re: [PATCH v2 4/4] ASoC: apple: mca: Add locks on foreign cluster access
Date: Mon, 22 Aug 2022 18:45:25 +0100 [thread overview]
Message-ID: <YwPAtY1kp5tU/isF@sirena.org.uk> (raw)
In-Reply-To: <20220819125430.4920-5-povik+lin@cutebit.org>
[-- Attachment #1: Type: text/plain, Size: 570 bytes --]
On Fri, Aug 19, 2022 at 02:54:30PM +0200, Martin Povišer wrote:
> In DAI ops, accesses to the native cluster (of the DAI), and to data of
> clusters related to it by a DPCM frontend-backend link, should have
> been synchronized by the 'pcm_mutex' lock at ASoC level.
>
> What is not covered are the 'port_driver' accesses on foreign clusters
> to which the current cluster has no a priori relation, so fill in
> locking for that. (This should only matter in bizarre configurations of
> sharing one MCA peripheral between ASoC cards.)
This also looks good.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: Mark Brown <broonie@kernel.org>
To: "Martin Povišer" <povik+lin@cutebit.org>
Cc: Liam Girdwood <lgirdwood@gmail.com>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Hector Martin <marcan@marcan.st>, Sven Peter <sven@svenpeter.dev>,
Philipp Zabel <p.zabel@pengutronix.de>,
Alyssa Rosenzweig <alyssa@rosenzweig.io>,
asahi@lists.linux.dev, alsa-devel@alsa-project.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 4/4] ASoC: apple: mca: Add locks on foreign cluster access
Date: Mon, 22 Aug 2022 18:45:25 +0100 [thread overview]
Message-ID: <YwPAtY1kp5tU/isF@sirena.org.uk> (raw)
In-Reply-To: <20220819125430.4920-5-povik+lin@cutebit.org>
[-- Attachment #1: Type: text/plain, Size: 570 bytes --]
On Fri, Aug 19, 2022 at 02:54:30PM +0200, Martin Povišer wrote:
> In DAI ops, accesses to the native cluster (of the DAI), and to data of
> clusters related to it by a DPCM frontend-backend link, should have
> been synchronized by the 'pcm_mutex' lock at ASoC level.
>
> What is not covered are the 'port_driver' accesses on foreign clusters
> to which the current cluster has no a priori relation, so fill in
> locking for that. (This should only matter in bizarre configurations of
> sharing one MCA peripheral between ASoC cards.)
This also looks good.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2022-08-22 17:46 UTC|newest]
Thread overview: 40+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-19 12:54 [PATCH v2 0/4] ASoC platform driver for Apple MCA Martin Povišer
2022-08-19 12:54 ` Martin Povišer
2022-08-19 12:54 ` [PATCH v2 1/4] dt-bindings: sound: Add Apple MCA I2S transceiver Martin Povišer
2022-08-19 12:54 ` Martin Povišer
2022-08-19 12:58 ` Martin Povišer
2022-08-19 12:58 ` Martin Povišer
2022-08-19 13:08 ` Krzysztof Kozlowski
2022-08-19 13:08 ` Krzysztof Kozlowski
2022-08-19 13:09 ` Krzysztof Kozlowski
2022-08-19 13:09 ` Krzysztof Kozlowski
2022-08-19 14:14 ` Martin Povišer
2022-08-19 14:14 ` Martin Povišer
2022-08-19 14:17 ` Krzysztof Kozlowski
2022-08-19 14:17 ` Krzysztof Kozlowski
2022-08-22 18:59 ` Rob Herring
2022-08-22 18:59 ` Rob Herring
2022-08-19 12:54 ` [PATCH v2 2/4] arm64: dts: apple: t8103: Add MCA and its support Martin Povišer
2022-08-19 12:54 ` Martin Povišer
2022-08-19 13:12 ` Krzysztof Kozlowski
2022-08-19 13:12 ` Krzysztof Kozlowski
2022-08-19 14:24 ` Martin Povišer
2022-08-19 14:24 ` Martin Povišer
2022-08-23 11:02 ` Krzysztof Kozlowski
2022-08-23 11:02 ` Krzysztof Kozlowski
2022-08-19 12:54 ` [PATCH v2 3/4] ASoC: apple: mca: Start new platform driver Martin Povišer
2022-08-19 12:54 ` Martin Povišer
2022-08-22 17:39 ` Mark Brown
2022-08-22 17:39 ` Mark Brown
2022-08-23 7:33 ` Martin Povišer
2022-08-23 7:33 ` Martin Povišer
2022-08-23 11:31 ` Mark Brown
2022-08-23 11:31 ` Mark Brown
2022-08-23 11:51 ` Martin Povišer
2022-08-23 11:51 ` Martin Povišer
2022-08-23 11:53 ` Martin Povišer
2022-08-23 11:53 ` Martin Povišer
2022-08-19 12:54 ` [PATCH v2 4/4] ASoC: apple: mca: Add locks on foreign cluster access Martin Povišer
2022-08-19 12:54 ` Martin Povišer
2022-08-22 17:45 ` Mark Brown [this message]
2022-08-22 17:45 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YwPAtY1kp5tU/isF@sirena.org.uk \
--to=broonie@kernel.org \
--cc=alsa-devel@alsa-project.org \
--cc=alyssa@rosenzweig.io \
--cc=asahi@lists.linux.dev \
--cc=devicetree@vger.kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=marcan@marcan.st \
--cc=p.zabel@pengutronix.de \
--cc=povik+lin@cutebit.org \
--cc=robh+dt@kernel.org \
--cc=sven@svenpeter.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.