From: Petr Vorel <pvorel@suse.cz>
To: Alejandro Colomar <alx.manpages@gmail.com>
Cc: linux-man@vger.kernel.org, Michael Kerrisk <mtk.manpages@gmail.com>
Subject: Re: Revert 70ac1c478 ("src.mk, All pages: Move man* to man/")
Date: Tue, 6 Sep 2022 18:09:38 +0200 [thread overview]
Message-ID: <YxdwwgtQjSOqMkbG@pevik> (raw)
In-Reply-To: <f8f6d1ba-5820-d238-4627-446d715fcf6f@gmail.com>
Hi Alejandro,
thanks a lot for your feedback.
> Hi Petr,
> On 9/6/22 11:41, Petr Vorel wrote:
> > Hi Alejandro,
> > yesterday you merged this commit (without sending it to ML):
> > 70ac1c478 ("src.mk, All pages: Move man* to man/")
> It's good to know that someone realized immediately after my patch. I
> wanted to know how much it would really hurt others' habits, and a
> discussion about it would probably have been too artificial. That's why I
> did it without prior discussion.
> > Although I agree that number of man* is quite high and single man directory
> > looks nicer, from practical reasons I'd prefer to revert this commit.
> > Because saving one extra cd is IMHO more important.
> I rarely cd. I edit pages from the root of the repo with (in my example,
> I'll pretend to edit membarrier(2)):
I also rarely cd. Both cd and editing from the git root directory use using tab
autocompletion as you note below.
> (previous to subsections):
> vi m[TAB]2[TAB]memb[TAB]
> (after subsections were introduced, but before this change):
> vi m[TAB]2/memb[TAB]
> (after this patch):
> vi m[TAB]m[TAB]2/memb[TAB]
> I agree it's two more keystrokes, and it took me so long to decide to change
> it because two keystrokes all the time are not the most friendly thing in
> the world, but I think I could live with them.
> Do you still think I should revert it?
I'd wait for more feedback, maybe others will like it.
Sure, I can live with it if I'm alone who even noticed :).
> I guess I'll receive a lot more emails like that in the following days, so
> I'll wait a little bit more before considering reverting it, but yeah, I may
> do it; I'm still unsure about what to do.
No matter how you finally decide, the most important lesson is that tree wide
changes, although they look trivial are safer to post to ML to get feedback
before (and obviously anything which looks controversial).
Kind regards,
Petr
> Kind regards,
> Alex
next prev parent reply other threads:[~2022-09-06 16:34 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-06 9:41 Revert 70ac1c478 ("src.mk, All pages: Move man* to man/") Petr Vorel
2022-09-06 11:19 ` Alejandro Colomar
2022-09-06 11:57 ` Alejandro Colomar
2022-09-06 11:58 ` Alejandro Colomar
2022-09-06 16:09 ` Petr Vorel [this message]
2022-09-07 20:53 ` Jakub Wilk
2022-09-07 22:11 ` Alejandro Colomar
2022-09-08 12:42 ` Stefan Puiu
2022-09-09 8:46 ` Petr Vorel
2022-09-15 13:40 ` Alex Colomar
2022-09-15 13:48 ` Petr Vorel
2023-08-02 21:38 ` Alejandro Colomar
2023-08-02 21:45 ` Alejandro Colomar
2024-03-26 1:28 ` Move man* to man/ (was: Revert 70ac1c478 ("src.mk, All pages: Move man* to man/")) Alejandro Colomar
2024-04-26 12:43 ` Ping: " Alejandro Colomar
2024-04-26 18:03 ` Petr Vorel
2024-04-26 20:19 ` Alejandro Colomar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YxdwwgtQjSOqMkbG@pevik \
--to=pvorel@suse.cz \
--cc=alx.manpages@gmail.com \
--cc=linux-man@vger.kernel.org \
--cc=mtk.manpages@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.