From: Jiri Olsa <olsajiri@gmail.com>
To: "Masami Hiramatsu (Google)" <mhiramat@kernel.org>
Cc: Alexei Starovoitov <ast@kernel.org>,
Daniel Borkmann <daniel@iogearbox.net>,
Andrii Nakryiko <andrii@kernel.org>,
bpf@vger.kernel.org, Martin KaFai Lau <kafai@fb.com>,
Song Liu <songliubraving@fb.com>, Yonghong Song <yhs@fb.com>,
John Fastabend <john.fastabend@gmail.com>,
KP Singh <kpsingh@chromium.org>,
Stanislav Fomichev <sdf@google.com>, Hao Luo <haoluo@google.com>,
Peter Zijlstra <peterz@infradead.org>
Subject: Re: [PATCHv2 bpf-next 1/6] kprobes: Add new KPROBE_FLAG_ON_FUNC_ENTRY kprobe flag
Date: Thu, 8 Sep 2022 10:26:12 +0200 [thread overview]
Message-ID: <YxmnJBEhQ7x2Yy+H@krava> (raw)
In-Reply-To: <Yw4n/NmFRuYivgi6@krava>
ping, thanks
On Tue, Aug 30, 2022 at 05:08:44PM +0200, Jiri Olsa wrote:
> Masami,
> could you please check on this one?
>
> thanks,
> jirka
>
> On Thu, Aug 11, 2022 at 11:15:21AM +0200, Jiri Olsa wrote:
> > Adding KPROBE_FLAG_ON_FUNC_ENTRY kprobe flag to indicate that
> > attach address is on function entry. This is used in following
> > changes in get_func_ip helper to return correct function address.
> >
> > Signed-off-by: Jiri Olsa <jolsa@kernel.org>
> > ---
> > include/linux/kprobes.h | 1 +
> > kernel/kprobes.c | 6 +++++-
> > 2 files changed, 6 insertions(+), 1 deletion(-)
> >
> > diff --git a/include/linux/kprobes.h b/include/linux/kprobes.h
> > index 55041d2f884d..a0b92be98984 100644
> > --- a/include/linux/kprobes.h
> > +++ b/include/linux/kprobes.h
> > @@ -103,6 +103,7 @@ struct kprobe {
> > * this flag is only for optimized_kprobe.
> > */
> > #define KPROBE_FLAG_FTRACE 8 /* probe is using ftrace */
> > +#define KPROBE_FLAG_ON_FUNC_ENTRY 16 /* probe is on the function entry */
> >
> > /* Has this kprobe gone ? */
> > static inline bool kprobe_gone(struct kprobe *p)
> > diff --git a/kernel/kprobes.c b/kernel/kprobes.c
> > index f214f8c088ed..a6b1b5c49d92 100644
> > --- a/kernel/kprobes.c
> > +++ b/kernel/kprobes.c
> > @@ -1605,9 +1605,10 @@ int register_kprobe(struct kprobe *p)
> > struct kprobe *old_p;
> > struct module *probed_mod;
> > kprobe_opcode_t *addr;
> > + bool on_func_entry;
> >
> > /* Adjust probe address from symbol */
> > - addr = kprobe_addr(p);
> > + addr = _kprobe_addr(p->addr, p->symbol_name, p->offset, &on_func_entry);
> > if (IS_ERR(addr))
> > return PTR_ERR(addr);
> > p->addr = addr;
> > @@ -1627,6 +1628,9 @@ int register_kprobe(struct kprobe *p)
> >
> > mutex_lock(&kprobe_mutex);
> >
> > + if (on_func_entry)
> > + p->flags |= KPROBE_FLAG_ON_FUNC_ENTRY;
> > +
> > old_p = get_kprobe(p->addr);
> > if (old_p) {
> > /* Since this may unoptimize 'old_p', locking 'text_mutex'. */
> > --
> > 2.37.1
> >
next prev parent reply other threads:[~2022-09-08 8:26 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-11 9:15 [PATCHv2 bpf-next 0/6] bpf: Fixes for CONFIG_X86_KERNEL_IBT Jiri Olsa
2022-08-11 9:15 ` [PATCHv2 bpf-next 1/6] kprobes: Add new KPROBE_FLAG_ON_FUNC_ENTRY kprobe flag Jiri Olsa
2022-08-15 9:57 ` Peter Zijlstra
2022-08-15 10:10 ` Jiri Olsa
2022-08-15 12:40 ` Peter Zijlstra
2022-08-16 7:01 ` Jiri Olsa
2022-08-30 15:08 ` Jiri Olsa
2022-09-08 8:26 ` Jiri Olsa [this message]
2022-09-08 12:01 ` Masami Hiramatsu
2022-08-11 9:15 ` [PATCHv2 bpf-next 2/6] ftrace: Keep the resolved addr in kallsyms_callback Jiri Olsa
2022-08-15 10:13 ` Peter Zijlstra
2022-08-15 10:30 ` Jiri Olsa
2022-08-15 12:45 ` Peter Zijlstra
2022-08-16 7:06 ` Jiri Olsa
2022-09-08 12:35 ` Masami Hiramatsu
2022-09-08 19:41 ` Jiri Olsa
2022-08-11 9:15 ` [PATCHv2 bpf-next 3/6] bpf: Use given function address for trampoline ip arg Jiri Olsa
2022-08-15 10:18 ` Peter Zijlstra
2022-08-15 10:57 ` Jiri Olsa
2022-08-15 12:51 ` Peter Zijlstra
2022-08-17 13:40 ` Jiri Olsa
2022-08-11 9:15 ` [PATCHv2 bpf-next 4/6] bpf: Adjust kprobe_multi entry_ip for CONFIG_X86_KERNEL_IBT Jiri Olsa
2022-08-11 9:15 ` [PATCHv2 bpf-next 5/6] bpf: Return value in kprobe get_func_ip only for entry address Jiri Olsa
2022-08-11 9:15 ` [PATCHv2 bpf-next 6/6] selftests/bpf: Fix get_func_ip offset test for CONFIG_X86_KERNEL_IBT Jiri Olsa
2022-08-16 3:25 ` Andrii Nakryiko
2022-08-16 7:00 ` Jiri Olsa
2022-08-16 10:18 ` Jiri Olsa
2022-08-16 17:28 ` Andrii Nakryiko
2022-08-16 17:19 ` Andrii Nakryiko
2022-08-16 3:27 ` [PATCHv2 bpf-next 0/6] bpf: Fixes " Andrii Nakryiko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YxmnJBEhQ7x2Yy+H@krava \
--to=olsajiri@gmail.com \
--cc=andrii@kernel.org \
--cc=ast@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=daniel@iogearbox.net \
--cc=haoluo@google.com \
--cc=john.fastabend@gmail.com \
--cc=kafai@fb.com \
--cc=kpsingh@chromium.org \
--cc=mhiramat@kernel.org \
--cc=peterz@infradead.org \
--cc=sdf@google.com \
--cc=songliubraving@fb.com \
--cc=yhs@fb.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.