From: "Roger Pau Monné" <roger.pau@citrix.com>
To: "Chen, Jiqian" <Jiqian.Chen@amd.com>
Cc: Oleksii Kurochko <oleksii.kurochko@gmail.com>,
"xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>,
Andrew Cooper <andrew.cooper3@citrix.com>,
Julien Grall <julien@xen.org>,
Stefano Stabellini <sstabellini@kernel.org>,
"Huang, Ray" <Ray.Huang@amd.com>, Jan Beulich <jbeulich@suse.com>
Subject: Re: [PATCH v8] vpci: Add resizable bar support
Date: Fri, 14 Feb 2025 09:39:24 +0100 [thread overview]
Message-ID: <Z68BPHUxW42KdJPs@macbook.local> (raw)
In-Reply-To: <BL1PR12MB5849BDEC2A23731E9281A26FE7FE2@BL1PR12MB5849.namprd12.prod.outlook.com>
On Fri, Feb 14, 2025 at 08:22:39AM +0000, Chen, Jiqian wrote:
> On 2025/2/14 16:18, Oleksii Kurochko wrote:
> >
> > On 2/14/25 8:35 AM, Jan Beulich wrote:
> >> On 14.02.2025 04:32, Chen, Jiqian wrote:
> >>> On 2025/2/11 17:21, Roger Pau Monné wrote:
> >>>> On Tue, Feb 11, 2025 at 10:22:57AM +0800, Jiqian Chen wrote:
> >>>>> Some devices, like AMDGPU, support resizable bar capability,
> >>>>> but vpci of Xen doesn't support this feature, so they fail
> >>>>> to resize bars and then cause probing failure.
> >>>>>
> >>>>> According to PCIe spec, each bar that supports resizing has
> >>>>> two registers, PCI_REBAR_CAP and PCI_REBAR_CTRL. So, add
> >>>>> handlers to support resizing the size of BARs.
> >>>>>
> >>>>> Note that Xen will only trap PCI_REBAR_CTRL, as PCI_REBAR_CAP
> >>>>> is read-only register and the hardware domain already gets
> >>>>> access to it without needing any setup.
> >>>>>
> >>>>> Signed-off-by: Jiqian Chen <Jiqian.Chen@amd.com>
> >>>> Reviewed-by: Roger Pau Monné <roger.pau@citrix.com>
> >>> Thank you!
> >>> May I know whether this can be merged in Xen version 4.20?
> >
> > It would be better to merge it after the Xen 4.20 release.
> > (It will happen in the next 2 weeks).
> Got it. Thank you for reply.
Could you also add an entry to the CHANGELOG.md file to note that
ReBAR is now supported on PVH dom0?
Thanks, Roger.
next prev parent reply other threads:[~2025-02-14 8:39 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-11 2:22 [PATCH v8] vpci: Add resizable bar support Jiqian Chen
2025-02-11 9:21 ` Roger Pau Monné
2025-02-14 3:32 ` Chen, Jiqian
2025-02-14 7:35 ` Jan Beulich
2025-02-14 8:18 ` Oleksii Kurochko
2025-02-14 8:22 ` Chen, Jiqian
2025-02-14 8:39 ` Roger Pau Monné [this message]
2025-02-14 9:01 ` Chen, Jiqian
2025-02-14 9:12 ` Roger Pau Monné
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Z68BPHUxW42KdJPs@macbook.local \
--to=roger.pau@citrix.com \
--cc=Jiqian.Chen@amd.com \
--cc=Ray.Huang@amd.com \
--cc=andrew.cooper3@citrix.com \
--cc=jbeulich@suse.com \
--cc=julien@xen.org \
--cc=oleksii.kurochko@gmail.com \
--cc=sstabellini@kernel.org \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.