From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Geert Uytterhoeven <geert@linux-m68k.org>
Cc: Andi Shyti <andi.shyti@kernel.org>,
Wolfram Sang <wsa+renesas@sang-engineering.com>,
linux-i2c@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-mediatek@lists.infradead.org,
linux-renesas-soc@vger.kernel.org,
Krzysztof Adamski <krzysztof.adamski@nokia.com>,
Florian Fainelli <florian.fainelli@broadcom.com>,
Ray Jui <rjui@broadcom.com>,
Scott Branden <sbranden@broadcom.com>,
Broadcom internal kernel review list
<bcm-kernel-feedback-list@broadcom.com>,
Stefan Roese <sr@denx.de>,
Matthias Brugger <matthias.bgg@gmail.com>,
AngeloGioacchino Del Regno
<angelogioacchino.delregno@collabora.com>,
Gregory CLEMENT <gregory.clement@bootlin.com>,
Fabrizio Castro <fabrizio.castro.jz@renesas.com>
Subject: Re: [PATCH v1 1/8] i2c: Introduce i2c_10bit_addr_from_msg()
Date: Wed, 12 Feb 2025 21:04:09 +0200 [thread overview]
Message-ID: <Z6zwqbzd5evG0H2z@smile.fi.intel.com> (raw)
In-Reply-To: <CAMuHMdW1wxQ0cddeE72D+Sii4HkT4bJfeTWX4-8FfHiFr+=3DA@mail.gmail.com>
On Wed, Feb 12, 2025 at 07:36:46PM +0100, Geert Uytterhoeven wrote:
> On Wed, 12 Feb 2025 at 17:35, Andy Shevchenko
> <andriy.shevchenko@linux.intel.com> wrote:
> > There are already a lot of drivers that have been using
> > i2c_8bit_addr_from_msg() for 7-bit addresses, now it's time
> > to have the similar for 10-bit addresses.
...
> > +static inline u8 i2c_10bit_addr_from_msg(const struct i2c_msg *msg)
>
> Having never used 10-bit addressing myself, or even looked into it,
> it took me a while to understand what this helper really does...
> So this returns the high byte of the artificial 16-bit address that
> must be used to address a target that uses 10-bit addressing?
> Hence I think this should be renamed, to better match its purpose.
Since you are giving a constructive feedback, please, propose the name.
> > +{
> > + /*
> > + * 10-bit address
> > + * addr_1: 5'b11110 | addr[9:8] | (R/nW)
> > + * addr_2: addr[7:0]
>
> I think the second comment line does not belong here, as this function
> doesn't care about that part.
I think the comment is okay to stay. It explains the full picture which is
helpful. It may be extended to say that the function returns only addr_1.
> > + */
> > + return 0xf0 | ((msg->addr & GENMASK(9, 8)) >> 7) | (msg->flags & I2C_M_RD);
> > +}
>
> Probably you also want to add a similar but much simpler helper to
> return the low byte?
Wouldn't it be too much?
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2025-02-12 19:04 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-12 16:32 [PATCH v1 0/8] i2c: busses: Introduce and use i2c_10bit_addr_from_msg() Andy Shevchenko
2025-02-12 16:32 ` [PATCH v1 1/8] i2c: Introduce i2c_10bit_addr_from_msg() Andy Shevchenko
2025-02-12 17:06 ` Fabrizio Castro
2025-02-12 18:36 ` Geert Uytterhoeven
2025-02-12 19:04 ` Andy Shevchenko [this message]
2025-02-13 10:02 ` Wolfram Sang
2025-02-13 10:54 ` Andy Shevchenko
2025-02-13 13:04 ` Andy Shevchenko
2025-02-13 11:10 ` Geert Uytterhoeven
2025-02-13 22:41 ` Andi Shyti
2025-02-14 8:04 ` Geert Uytterhoeven
2025-02-14 13:55 ` Andy Shevchenko
2025-02-13 22:40 ` Andi Shyti
2025-02-12 16:32 ` [PATCH v1 2/8] i2c: axxia: Use i2c_10bit_addr_from_msg() helper Andy Shevchenko
2025-02-12 16:32 ` [PATCH v1 3/8] i2c: bcm-kona: " Andy Shevchenko
2025-02-12 16:32 ` [PATCH v1 4/8] i2c: eg20t: " Andy Shevchenko
2025-02-12 16:32 ` [PATCH v1 5/8] i2c: kempld: " Andy Shevchenko
2025-02-12 16:32 ` [PATCH v1 6/8] i2c: mt7621: " Andy Shevchenko
2025-02-12 16:32 ` [PATCH v1 7/8] i2c: mv64xxx: Use i2c_*bit_addr_from_msg() helpers Andy Shevchenko
2025-02-12 16:32 ` [PATCH v1 8/8] i2c: rzv2m: Use i2c_10bit_addr_from_msg() helper Andy Shevchenko
2025-02-12 17:08 ` Fabrizio Castro
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Z6zwqbzd5evG0H2z@smile.fi.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=andi.shyti@kernel.org \
--cc=angelogioacchino.delregno@collabora.com \
--cc=bcm-kernel-feedback-list@broadcom.com \
--cc=fabrizio.castro.jz@renesas.com \
--cc=florian.fainelli@broadcom.com \
--cc=geert@linux-m68k.org \
--cc=gregory.clement@bootlin.com \
--cc=krzysztof.adamski@nokia.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=matthias.bgg@gmail.com \
--cc=rjui@broadcom.com \
--cc=sbranden@broadcom.com \
--cc=sr@denx.de \
--cc=wsa+renesas@sang-engineering.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.