From: Tzung-Bi Shih <tzungbi@kernel.org>
To: Lukasz Majczak <lma@chromium.org>
Cc: Gwendal Grignou <gwendal@chromium.org>,
Radoslaw Biernacki <biernacki@google.com>,
Wim Van Sebroeck <wim@linux-watchdog.org>,
Lee Jones <lee@kernel.org>, Benson Leung <bleung@chromium.org>,
Guenter Roeck <groeck@chromium.org>,
Krzysztof Kozlowski <krzk@kernel.org>,
linux-watchdog@vger.kernel.org, linux-kernel@vger.kernel.org,
chrome-platform@lists.linux.dev
Subject: Re: [PATCH v2 1/3] platform/chrome: Update binary interface for EC-based watchdog
Date: Fri, 19 Jan 2024 11:41:49 +0800 [thread overview]
Message-ID: <ZanvffnDDoT0j2af@google.com> (raw)
In-Reply-To: <20240118195325.2964918-2-lma@chromium.org>
On Thu, Jan 18, 2024 at 07:53:22PM +0000, Lukasz Majczak wrote:
> +#define EC_HANG_DETECT_MIN_TIMEOUT 5
> +#define EC_HANG_DETECT_MAX_TIMEOUT 65535
EC_HANG_DETECT_MAX_TIMEOUT isn't in the latest ec_commands.h [1]. Could you
either add EC_HANG_DETECT_MAX_TIMEOUT to ec_commands.h or drop the macro here?
[1] https://crrev.com/5a76e67210b15fcf67d8a6f90439993598949ae4/include/ec_commands.h#4749
next prev parent reply other threads:[~2024-01-19 3:41 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-18 19:53 [PATCH v2 0/3] Introduce EC-based watchdog Lukasz Majczak
2024-01-18 19:53 ` [PATCH v2 1/3] platform/chrome: Update binary interface for " Lukasz Majczak
2024-01-18 23:42 ` Guenter Roeck
2024-01-19 3:41 ` Tzung-Bi Shih [this message]
2024-01-19 8:34 ` Łukasz Majczak
2024-01-18 19:53 ` [PATCH v2 2/3] watchdog: Add ChromeOS EC-based watchdog driver Lukasz Majczak
2024-01-18 23:44 ` Guenter Roeck
2024-01-19 3:42 ` Tzung-Bi Shih
2024-01-19 3:55 ` Guenter Roeck
2024-01-19 5:28 ` Tzung-Bi Shih
2024-01-18 19:53 ` [PATCH v2 3/3] mfd: cros_ec: Register EC-based watchdog subdevice Lukasz Majczak
2024-01-18 23:44 ` Guenter Roeck
2024-01-19 8:36 ` Łukasz Majczak
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZanvffnDDoT0j2af@google.com \
--to=tzungbi@kernel.org \
--cc=biernacki@google.com \
--cc=bleung@chromium.org \
--cc=chrome-platform@lists.linux.dev \
--cc=groeck@chromium.org \
--cc=gwendal@chromium.org \
--cc=krzk@kernel.org \
--cc=lee@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-watchdog@vger.kernel.org \
--cc=lma@chromium.org \
--cc=wim@linux-watchdog.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.