* [PATCH] libmultipath: hwtable: fix fast_io_fail for Infinibox
@ 2024-01-31 11:48 Martin Wilck
2024-02-10 17:15 ` Martin Wilck
0 siblings, 1 reply; 3+ messages in thread
From: Martin Wilck @ 2024-01-31 11:48 UTC (permalink / raw
To: Christophe Varoqui, Benjamin Marzinski
Cc: dm-devel, Arnon Yaari, Xose Vazquez Perez, Tom Abraham,
Jiri Belka
The Infinibox hwtable entry had fast_io_fail and dev_loss both set to 15,
which has the effect that fast_io_fail is switched off (dev_loss timeout
must be higher than fast_io_fail timeout).
Remove the dev_loss value, which will cause the default of 600 to be used.
Experience shows that dev_loss_tmo values below a few minutes are seldom
helpful.
Fixes: 55da608 ("libmultipath: update INFINIDAT builtin config")
Signed-off-by: Martin Wilck <mwilck@suse.com>
Cc: Arnon Yaari <arnony@infinidat.com>
Cc: Xose Vazquez Perez <xose.vazquez@gmail.com>
Cc: Tom Abraham <tabraham@suse.com>
Cc: Jiri Belka <jiri.belka@suse.com>
---
libmultipath/hwtable.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/libmultipath/hwtable.c b/libmultipath/hwtable.c
index 808af54..9ef3e45 100644
--- a/libmultipath/hwtable.c
+++ b/libmultipath/hwtable.c
@@ -1161,7 +1161,6 @@ static struct hwentry default_hw[] = {
.minio_rq = 1,
.flush_on_last_del = FLUSH_ENABLED,
.fast_io_fail = 15,
- .dev_loss = 15,
},
/*
* Kaminario
--
2.43.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] libmultipath: hwtable: fix fast_io_fail for Infinibox
2024-01-31 11:48 [PATCH] libmultipath: hwtable: fix fast_io_fail for Infinibox Martin Wilck
@ 2024-02-10 17:15 ` Martin Wilck
2024-02-14 1:23 ` Benjamin Marzinski
0 siblings, 1 reply; 3+ messages in thread
From: Martin Wilck @ 2024-02-10 17:15 UTC (permalink / raw
To: Christophe Varoqui, Benjamin Marzinski
Cc: dm-devel, Arnon Yaari, Xose Vazquez Perez, Tom Abraham,
Jiri Belka
Gentle review reminder.
On Wed, 2024-01-31 at 12:48 +0100, Martin Wilck wrote:
> The Infinibox hwtable entry had fast_io_fail and dev_loss both set to
> 15,
> which has the effect that fast_io_fail is switched off (dev_loss
> timeout
> must be higher than fast_io_fail timeout).
>
> Remove the dev_loss value, which will cause the default of 600 to be
> used.
> Experience shows that dev_loss_tmo values below a few minutes are
> seldom
> helpful.
>
> Fixes: 55da608 ("libmultipath: update INFINIDAT builtin config")
> Signed-off-by: Martin Wilck <mwilck@suse.com>
> Cc: Arnon Yaari <arnony@infinidat.com>
> Cc: Xose Vazquez Perez <xose.vazquez@gmail.com>
> Cc: Tom Abraham <tabraham@suse.com>
> Cc: Jiri Belka <jiri.belka@suse.com>
> ---
> libmultipath/hwtable.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/libmultipath/hwtable.c b/libmultipath/hwtable.c
> index 808af54..9ef3e45 100644
> --- a/libmultipath/hwtable.c
> +++ b/libmultipath/hwtable.c
> @@ -1161,7 +1161,6 @@ static struct hwentry default_hw[] = {
> .minio_rq = 1,
> .flush_on_last_del = FLUSH_ENABLED,
> .fast_io_fail = 15,
> - .dev_loss = 15,
> },
> /*
> * Kaminario
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] libmultipath: hwtable: fix fast_io_fail for Infinibox
2024-02-10 17:15 ` Martin Wilck
@ 2024-02-14 1:23 ` Benjamin Marzinski
0 siblings, 0 replies; 3+ messages in thread
From: Benjamin Marzinski @ 2024-02-14 1:23 UTC (permalink / raw
To: Martin Wilck
Cc: Christophe Varoqui, dm-devel, Arnon Yaari, Xose Vazquez Perez,
Tom Abraham, Jiri Belka
On Sat, Feb 10, 2024 at 06:15:45PM +0100, Martin Wilck wrote:
> Gentle review reminder.
>
> On Wed, 2024-01-31 at 12:48 +0100, Martin Wilck wrote:
> > The Infinibox hwtable entry had fast_io_fail and dev_loss both set to
> > 15,
> > which has the effect that fast_io_fail is switched off (dev_loss
> > timeout
> > must be higher than fast_io_fail timeout).
> >
> > Remove the dev_loss value, which will cause the default of 600 to be
> > used.
> > Experience shows that dev_loss_tmo values below a few minutes are
> > seldom
> > helpful.
> >
> > Fixes: 55da608 ("libmultipath: update INFINIDAT builtin config")
> > Signed-off-by: Martin Wilck <mwilck@suse.com>
> > Cc: Arnon Yaari <arnony@infinidat.com>
Reviewed-by: Benjamin Marzinski <bmarzins@redhat.com>
> > Cc: Xose Vazquez Perez <xose.vazquez@gmail.com>
> > Cc: Tom Abraham <tabraham@suse.com>
> > Cc: Jiri Belka <jiri.belka@suse.com>
> > ---
> > libmultipath/hwtable.c | 1 -
> > 1 file changed, 1 deletion(-)
> >
> > diff --git a/libmultipath/hwtable.c b/libmultipath/hwtable.c
> > index 808af54..9ef3e45 100644
> > --- a/libmultipath/hwtable.c
> > +++ b/libmultipath/hwtable.c
> > @@ -1161,7 +1161,6 @@ static struct hwentry default_hw[] = {
> > .minio_rq = 1,
> > .flush_on_last_del = FLUSH_ENABLED,
> > .fast_io_fail = 15,
> > - .dev_loss = 15,
> > },
> > /*
> > * Kaminario
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2024-02-14 1:23 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-01-31 11:48 [PATCH] libmultipath: hwtable: fix fast_io_fail for Infinibox Martin Wilck
2024-02-10 17:15 ` Martin Wilck
2024-02-14 1:23 ` Benjamin Marzinski
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.