From: Sean Christopherson <seanjc@google.com>
To: Jakub Kicinski <kuba@kernel.org>
Cc: davem@davemloft.net, netdev@vger.kernel.org, edumazet@google.com,
pabeni@redhat.com, shuah@kernel.org, keescook@chromium.org,
usama.anjum@collabora.com, linux-kselftest@vger.kernel.org,
llvm@lists.linux.dev
Subject: Re: [PATCH net] selftests: kselftest_harness: fix Clang warning about zero-length format
Date: Tue, 16 Apr 2024 08:23:00 -0700 [thread overview]
Message-ID: <Zh6X1NkQJd6ETTo7@google.com> (raw)
In-Reply-To: <20240416151048.1682352-1-kuba@kernel.org>
On Tue, Apr 16, 2024, Jakub Kicinski wrote:
> Apparently it's more legal to pass the format as NULL, than
> it is to use an empty string. Clang complains about empty
> formats:
>
> ./../kselftest_harness.h:1207:30: warning: format string is empty
> [-Wformat-zero-length]
> 1207 | diagnostic ? "%s" : "", diagnostic);
> | ^~
> 1 warning generated.
>
> Reported-by: Sean Christopherson <seanjc@google.com>
> Link: https://lore.kernel.org/all/20240409224256.1581292-1-seanjc@google.com
> Fixes: 378193eff339 ("selftests: kselftest_harness: let PASS / FAIL provide diagnostic")
> Signed-off-by: Jakub Kicinski <kuba@kernel.org>
Thanks Jakub!
Tested-by: Sean Christopherson <seanjc@google.com>
next prev parent reply other threads:[~2024-04-16 15:23 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-16 15:10 [PATCH net] selftests: kselftest_harness: fix Clang warning about zero-length format Jakub Kicinski
2024-04-16 15:23 ` Sean Christopherson [this message]
2024-04-16 15:24 ` Muhammad Usama Anjum
2024-04-18 2:10 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Zh6X1NkQJd6ETTo7@google.com \
--to=seanjc@google.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=keescook@chromium.org \
--cc=kuba@kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=llvm@lists.linux.dev \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=shuah@kernel.org \
--cc=usama.anjum@collabora.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.