From: Christoph Hellwig <hch@infradead.org>
To: David Disseldorp <ddiss@suse.de>
Cc: fstests@vger.kernel.org, linux-xfs@vger.kernel.org
Subject: Re: [PATCH 1/2] common/config: export TEST_DEV for mkfs.xfs
Date: Fri, 26 Apr 2024 22:56:45 -0700 [thread overview]
Message-ID: <ZiyTneFh5GWM6Rs_@infradead.org> (raw)
In-Reply-To: <20240411063234.30110-1-ddiss@suse.de>
On Thu, Apr 11, 2024 at 04:32:33PM +1000, David Disseldorp wrote:
> As of xfsprogs commit 6e0ed3d1 ("mkfs: stop allowing tiny filesystems")
> attempts to create XFS filesystems sized under 300M fail, unless
> TEST_DIR, TEST_DEV and QA_CHECK_FS environment variables are exported
> (or a --unsupported mkfs parameter is provided).
>
> TEST_DIR and QA_CHECK_FS are already exported, while TEST_DEV may only
> be locally set if provided via e.g. configs/$HOSTNAME.config. Explicitly
> export TEST_DEV to ensure that tests which call _scratch_mkfs_sized()
> with an fssize under 300M run normally.
As for fixing the immediate problem this looks fine:
Reviewed-by: Christoph Hellwig <hch@lst.de>
But adding the xfs list as allowing to create a smaller than supported
file system just for testing is pretty silly. If we don't want to
support these tiny file systems, we should also not use them for
testing. The best way to port over the existing tests to a larger
size would probably be to round up the size to the minimum supported
one and then fill the space?
next prev parent reply other threads:[~2024-04-27 5:56 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-11 6:32 [PATCH 1/2] common/config: export TEST_DEV for mkfs.xfs David Disseldorp
2024-04-11 6:32 ` [PATCH 2/2] tests: _fail on _scratch_mkfs_sized failure David Disseldorp
2024-04-12 15:48 ` Darrick J. Wong
2024-04-12 19:28 ` Zorro Lang
2024-04-27 5:58 ` Christoph Hellwig
2024-04-12 15:44 ` [PATCH 1/2] common/config: export TEST_DEV for mkfs.xfs Darrick J. Wong
2024-04-27 5:56 ` Christoph Hellwig [this message]
2024-04-28 5:37 ` Zorro Lang
2024-04-29 11:28 ` David Disseldorp
2024-04-29 13:37 ` Zorro Lang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZiyTneFh5GWM6Rs_@infradead.org \
--to=hch@infradead.org \
--cc=ddiss@suse.de \
--cc=fstests@vger.kernel.org \
--cc=linux-xfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.