From: Marcelo Schmitt <marcelo.schmitt1@gmail.com>
To: Gustavo <ogustavo@usp.br>
Cc: lars@metafoo.de, Michael.Hennerich@analog.com, jic23@kernel.org,
Gustavo <gustavenrique01@gmail.com>,
linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 0/3] iio: adc: ad799x: Fix warning generated by checkpatch
Date: Sat, 27 Apr 2024 07:39:25 -0300 [thread overview]
Message-ID: <ZizV3UWWJkyH5kmr@debian-BULLSEYE-live-builder-AMD64> (raw)
In-Reply-To: <20240426012313.2295067-1-gustavenrique01@gmail.com>
Hi Gustavo, Bruna,
The patches look overall good but there are some improvements that can be made.
First, checkpatch points out email address mismatch. Gustavo address of sign-off
is different then the address used to send the patches. I think this can
be solved by adding --from parameter to git format-patch or git send-email.
Second, Gustavo's sign-off tag is incomplete. The tag must have either first and
last name or all developer's names.
For example:
Signed-off-by: first_name last_name <email_address>
or
Signed-off-by: first_name 1st_middle_name 2nd_middle_name ... last_name <email_address>
I'm pretty sure those actually must be sort out for a patch to be acceptable.
Some additional tips to improve patch set quality:
- Don't use file extensions in subjects
iio: adc: ad799x.c: ... -> iio: adc: ad799x: ...
- Also wrap the cover letter text to 75 columns except when it makes text
clearly less readable.
- It should be okay to say in commit message that a change is suggested by
checkpatch or fixes some checkpatch warning as long as you also describe
what the actual change is. You seem to already be describing the changes
so maybe adding that they also cease checkpatch warnings / make code
compliant to Linux code style.
- Maybe have a look at the submitting-patches documentation [1] and
tips to write commit messages [2] to help producing patches.
[1]: https://www.kernel.org/doc/html/latest/process/submitting-patches.html
[2]: https://cbea.ms/git-commit/#why-not-how
Regards,
Marcelo
On 04/25, Gustavo wrote:
> Clean code of iio:adc:ad799x to avoid warning messages. These include proper variable declaration 'unsigned' to 'unsigned int', add blank line and use of octal permission instead of symbolic.
>
> Gustavo (3):
> iio: adc: ad799x: change 'unsigned' to 'unsigned int' declaration
> iio: adc: ad799x.c: add blank line to avoid warning messages
> iio: adc: ad799x: Prefer to use octal permission instead of symbolic
>
> drivers/iio/adc/ad799x.c | 7 ++++---
> 1 file changed, 4 insertions(+), 3 deletions(-)
>
> --
> 2.34.1
>
>
next prev parent reply other threads:[~2024-04-27 10:38 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-26 1:23 [PATCH 0/3] iio: adc: ad799x: Fix warning generated by checkpatch Gustavo
2024-04-26 1:23 ` [PATCH 1/3] iio: adc: ad799x: change 'unsigned' to 'unsigned int' declaration Gustavo
2024-04-26 1:23 ` [PATCH 2/3] iio: adc: ad799x.c: add blank line to avoid warning messages Gustavo
2024-04-26 1:23 ` [PATCH 3/3] iio: adc: ad799x: Prefer to use octal permission instead of symbolic Gustavo
2024-04-27 10:39 ` Marcelo Schmitt [this message]
-- strict thread matches above, loose matches on Subject: below --
2024-04-28 19:43 [PATCH 0/3] iio: adc: ad799x: Fix warning generated by checkpatch ogustavo
2024-04-29 7:28 ` Nuno Sá
2024-04-29 19:58 ` Jonathan Cameron
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZizV3UWWJkyH5kmr@debian-BULLSEYE-live-builder-AMD64 \
--to=marcelo.schmitt1@gmail.com \
--cc=Michael.Hennerich@analog.com \
--cc=gustavenrique01@gmail.com \
--cc=jic23@kernel.org \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=ogustavo@usp.br \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.