From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE, SPF_PASS,URIBL_RED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0ADF2C433DB for ; Tue, 23 Mar 2021 08:33:44 +0000 (UTC) Received: from smtp4.osuosl.org (smtp4.osuosl.org [140.211.166.137]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 8463161878 for ; Tue, 23 Mar 2021 08:33:43 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 8463161878 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=intel.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=virtualization-bounces@lists.linux-foundation.org Received: from localhost (localhost [127.0.0.1]) by smtp4.osuosl.org (Postfix) with ESMTP id 02C5040497; Tue, 23 Mar 2021 08:33:43 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp4.osuosl.org ([127.0.0.1]) by localhost (smtp4.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id VauYOed1LwcV; Tue, 23 Mar 2021 08:33:41 +0000 (UTC) Received: from lists.linuxfoundation.org (lf-lists.osuosl.org [IPv6:2605:bc80:3010:104::8cd3:938]) by smtp4.osuosl.org (Postfix) with ESMTP id 418C540496; Tue, 23 Mar 2021 08:33:41 +0000 (UTC) Received: from lf-lists.osuosl.org (localhost [127.0.0.1]) by lists.linuxfoundation.org (Postfix) with ESMTP id 1AE58C000B; Tue, 23 Mar 2021 08:33:41 +0000 (UTC) Received: from smtp4.osuosl.org (smtp4.osuosl.org [140.211.166.137]) by lists.linuxfoundation.org (Postfix) with ESMTP id CADD1C0001 for ; Tue, 23 Mar 2021 08:33:39 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp4.osuosl.org (Postfix) with ESMTP id A9DFF40497 for ; Tue, 23 Mar 2021 08:33:39 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp4.osuosl.org ([127.0.0.1]) by localhost (smtp4.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id AYfAmR0n78YA for ; Tue, 23 Mar 2021 08:33:37 +0000 (UTC) X-Greylist: domain auto-whitelisted by SQLgrey-1.8.0 Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by smtp4.osuosl.org (Postfix) with ESMTPS id 7A48A40496 for ; Tue, 23 Mar 2021 08:33:37 +0000 (UTC) IronPort-SDR: SMj2Mrk4hT2HVXOs1TN1Io8hMMi35G6M3vHccwloPWjBsjb/SEzl6PtAr2ZmZpaJSSS3n9LJnK vDyzSbiYBN9g== X-IronPort-AV: E=McAfee;i="6000,8403,9931"; a="190528873" X-IronPort-AV: E=Sophos;i="5.81,271,1610438400"; d="scan'208";a="190528873" Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by orsmga102.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 23 Mar 2021 01:33:36 -0700 IronPort-SDR: dxMPLZLIdwbEcufioZOCgJqKgJrpYMB+pfcuO4K7maUx4JRNqMDGTLG2wGyMaN82r7P8FYJWo6 V6galnLHWa8Q== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.81,271,1610438400"; d="scan'208";a="435470763" Received: from unknown (HELO [10.239.154.55]) ([10.239.154.55]) by fmsmga004.fm.intel.com with ESMTP; 23 Mar 2021 01:33:31 -0700 Subject: Re: [PATCH v10] i2c: virtio: add a virtio i2c frontend driver To: Viresh Kumar References: <226a8d5663b7bb6f5d06ede7701eedb18d1bafa1.1616493817.git.jie.deng@intel.com> <20210323072704.rgoelmq62fl2wjjf@vireshk-i7> From: Jie Deng Message-ID: Date: Tue, 23 Mar 2021 16:33:30 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Firefox/78.0 Thunderbird/78.7.0 MIME-Version: 1.0 In-Reply-To: <20210323072704.rgoelmq62fl2wjjf@vireshk-i7> Content-Language: en-US Cc: mst@redhat.com, bjorn.andersson@linaro.org, wsa+renesas@sang-engineering.com, linux-i2c@vger.kernel.org, wsa@kernel.org, andriy.shevchenko@linux.intel.com, yu1.wang@intel.com, u.kleine-koenig@pengutronix.de, kblaiech@mellanox.com, virtualization@lists.linux-foundation.org, arnd@arndb.de, stefanha@redhat.com, tali.perry1@gmail.com, conghui.chen@intel.com, loic.poulain@linaro.org, linux-kernel@vger.kernel.org, Sergey.Semin@baikalelectronics.ru, jarkko.nikula@linux.intel.com, shuo.a.liu@intel.com, pbonzini@redhat.com, rppt@kernel.org X-BeenThere: virtualization@lists.linux-foundation.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: Linux virtualization List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Errors-To: virtualization-bounces@lists.linux-foundation.org Sender: "Virtualization" On 2021/3/23 15:27, Viresh Kumar wrote: > On 23-03-21, 22:19, Jie Deng wrote: >> +static int __maybe_unused virtio_i2c_freeze(struct virtio_device *vdev) >> +{ >> + virtio_i2c_del_vqs(vdev); >> + return 0; >> +} >> + >> +static int __maybe_unused virtio_i2c_restore(struct virtio_device *vdev) >> +{ >> + return virtio_i2c_setup_vqs(vdev->priv); >> +} > Sorry for not looking at this earlier, but shouldn't we enclose the above two > within #ifdef CONFIG_PM_SLEEP instead and drop the __maybe_unused ? I remembered I was suggested to use "__maybe_unused" instead of "#ifdef". You may check this https://lore.kernel.org/patchwork/patch/732981/ The reason may be something like that. _______________________________________________ Virtualization mailing list Virtualization@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/virtualization From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1BFD0C433E0 for ; Tue, 23 Mar 2021 08:34:37 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id D3487619C6 for ; Tue, 23 Mar 2021 08:34:36 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229866AbhCWIeF (ORCPT ); Tue, 23 Mar 2021 04:34:05 -0400 Received: from mga12.intel.com ([192.55.52.136]:31238 "EHLO mga12.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229897AbhCWIdk (ORCPT ); Tue, 23 Mar 2021 04:33:40 -0400 IronPort-SDR: GjnOo9DIT1VM6LuUjLk2ntqAwB4dGYLc70y+S4VDOh5alz2NXog7ZKwS1cczsd8KZnnx94j/6U EtvAGCB7h6rA== X-IronPort-AV: E=McAfee;i="6000,8403,9931"; a="169767725" X-IronPort-AV: E=Sophos;i="5.81,271,1610438400"; d="scan'208";a="169767725" Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by fmsmga106.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 23 Mar 2021 01:33:36 -0700 IronPort-SDR: dxMPLZLIdwbEcufioZOCgJqKgJrpYMB+pfcuO4K7maUx4JRNqMDGTLG2wGyMaN82r7P8FYJWo6 V6galnLHWa8Q== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.81,271,1610438400"; d="scan'208";a="435470763" Received: from unknown (HELO [10.239.154.55]) ([10.239.154.55]) by fmsmga004.fm.intel.com with ESMTP; 23 Mar 2021 01:33:31 -0700 Subject: Re: [PATCH v10] i2c: virtio: add a virtio i2c frontend driver To: Viresh Kumar Cc: linux-i2c@vger.kernel.org, virtualization@lists.linux-foundation.org, linux-kernel@vger.kernel.org, mst@redhat.com, wsa@kernel.org, jasowang@redhat.com, wsa+renesas@sang-engineering.com, andriy.shevchenko@linux.intel.com, conghui.chen@intel.com, arnd@arndb.de, kblaiech@mellanox.com, jarkko.nikula@linux.intel.com, Sergey.Semin@baikalelectronics.ru, rppt@kernel.org, loic.poulain@linaro.org, tali.perry1@gmail.com, u.kleine-koenig@pengutronix.de, bjorn.andersson@linaro.org, yu1.wang@intel.com, shuo.a.liu@intel.com, stefanha@redhat.com, pbonzini@redhat.com References: <226a8d5663b7bb6f5d06ede7701eedb18d1bafa1.1616493817.git.jie.deng@intel.com> <20210323072704.rgoelmq62fl2wjjf@vireshk-i7> From: Jie Deng Message-ID: Date: Tue, 23 Mar 2021 16:33:30 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Firefox/78.0 Thunderbird/78.7.0 MIME-Version: 1.0 In-Reply-To: <20210323072704.rgoelmq62fl2wjjf@vireshk-i7> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Content-Language: en-US Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2021/3/23 15:27, Viresh Kumar wrote: > On 23-03-21, 22:19, Jie Deng wrote: >> +static int __maybe_unused virtio_i2c_freeze(struct virtio_device *vdev) >> +{ >> + virtio_i2c_del_vqs(vdev); >> + return 0; >> +} >> + >> +static int __maybe_unused virtio_i2c_restore(struct virtio_device *vdev) >> +{ >> + return virtio_i2c_setup_vqs(vdev->priv); >> +} > Sorry for not looking at this earlier, but shouldn't we enclose the above two > within #ifdef CONFIG_PM_SLEEP instead and drop the __maybe_unused ? I remembered I was suggested to use "__maybe_unused" instead of "#ifdef". You may check this https://lore.kernel.org/patchwork/patch/732981/ The reason may be something like that.