From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.3 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,MSGID_FROM_MTA_HEADER,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 36B42C433E0 for ; Fri, 8 Jan 2021 23:46:27 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id E944423A5A for ; Fri, 8 Jan 2021 23:46:26 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org E944423A5A Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=amd.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=amd-gfx-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 3EE1A6E8D7; Fri, 8 Jan 2021 23:46:24 +0000 (UTC) Received: from NAM10-BN7-obe.outbound.protection.outlook.com (mail-bn7nam10on2084.outbound.protection.outlook.com [40.107.92.84]) by gabe.freedesktop.org (Postfix) with ESMTPS id EBFE86E8D2; Fri, 8 Jan 2021 23:46:22 +0000 (UTC) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=jkS6vHFBJ91/h/UyxSUx7nU2fJ/LSm/CC8wI2NK+1gpudur2+fmBUzu6H65ZoqodF/dDp+Allzdq9G44osm6q2kwc/Sq6//n7kgZuhk2xuuJZgPxtu5McA3WHZWi+LFeuqoVD+rDn8MaNrqb/kUsMWNpAJdOX2zs4wcOyik7qA5Pdea7FZo10tI9lHfo/MgkqPd6m9cp2Vxzxp9fLCyoICteFo7szQsjkUN3U/fPIr395LDvcviu+yIcKIr+JaL8xoIK8bkR/tTgngpO/cHh88j8yG5r8hnO13MmjgpV1iQXQZw75/J3KddG2Wv5rY5JCg+E86emZ0O1dbZ+9eslug== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=r1zsCMm2IZu7bnrKiFRXZRbBuhc/w6WvrT6pl6zKQeA=; b=Erhd/dU+2ibaENvAXTr7EBm1p4Da/bJSoKI4+x9D1NiQeeTkCij6FFFA+EEkxhEB4HY7APO47LzjKzYzgQZHl8+Jf8iKHxsNiFbc7Mp2mWzuhWLsmsyV3i8413pJ+xuKIZxfEEU9uHiBBiPfj1SaJbt7nN9FUvqLU0NPk7PBp4WHKzx+XGLp5pnZGwSJODLa6aEFj2JSBhSUZnjMNk7DBjmVpyv4PiS9/yCeUSdUmtmaMlBj0RHl2oGPecyeRkRUZEbSi8+3RekTfN3/di2FaJjG2GB8eHfeLITkE1VeYG/ErtemNIfFoKBgZ1R5WSwD4t7dZoLtWsi1vBKVOJFJtA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=r1zsCMm2IZu7bnrKiFRXZRbBuhc/w6WvrT6pl6zKQeA=; b=PUGO06Kjbs7U4SzOZBmQjMczXAVD820QjjxjeEOQGUViDYz2ePX0rzTGK9YWFhBAqpx4MGf5z+pbfGjp3yyJ3rXYxyLfpX6ywWuWIzx4f8obfMpIRnE6ngK16yKVfOMgh2gS7qzRtBHniE/Q2dFtF6EkLNkStKwqaZbNkQl8yRQ= Authentication-Results: vger.kernel.org; dkim=none (message not signed) header.d=none;vger.kernel.org; dmarc=none action=none header.from=amd.com; Received: from BL0PR12MB4948.namprd12.prod.outlook.com (2603:10b6:208:1cc::20) by MN2PR12MB4520.namprd12.prod.outlook.com (2603:10b6:208:26f::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3742.6; Fri, 8 Jan 2021 23:46:19 +0000 Received: from BL0PR12MB4948.namprd12.prod.outlook.com ([fe80::9425:559:83c0:991b]) by BL0PR12MB4948.namprd12.prod.outlook.com ([fe80::9425:559:83c0:991b%9]) with mapi id 15.20.3742.011; Fri, 8 Jan 2021 23:46:19 +0000 Subject: Re: [PATCH] drm/amdkfd: Fix out-of-bounds read in kdf_create_vcrat_image_cpu() To: Jeremy Cline , Alex Deucher , =?UTF-8?Q?Christian_K=c3=b6nig?= References: <20210108163104.411442-1-jcline@redhat.com> From: Felix Kuehling Message-ID: Date: Fri, 8 Jan 2021 18:46:17 -0500 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 In-Reply-To: <20210108163104.411442-1-jcline@redhat.com> Content-Language: en-US X-Originating-IP: [142.117.121.176] X-ClientProxiedBy: YTXPR0101CA0031.CANPRD01.PROD.OUTLOOK.COM (2603:10b6:b00::44) To BL0PR12MB4948.namprd12.prod.outlook.com (2603:10b6:208:1cc::20) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 Received: from [192.168.2.100] (142.117.121.176) by YTXPR0101CA0031.CANPRD01.PROD.OUTLOOK.COM (2603:10b6:b00::44) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3742.6 via Frontend Transport; Fri, 8 Jan 2021 23:46:18 +0000 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-HT: Tenant X-MS-Office365-Filtering-Correlation-Id: d0feffba-3fcf-4c91-cda3-08d8b42f98f3 X-MS-TrafficTypeDiagnostic: MN2PR12MB4520: X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:10000; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: Yik+0npIL5H+dEAxyhxnyMl7HxOj+26+OM9NmEGq/gCFnoEFursP3YIjxVSc+12G1XN8AWOZsj1frtfQ3rD4D6qNhxxwZu8S/T0HgCXuL2x1SvXocDfLEGYYtVqrbZvdNnj1MPtNVEK3n8OtHvBhEgG7uBiBypwRatGxkCV0Jh57aGaAcCoQv6EB+fnfkmkTJNleN/97IfATfHtFp3FFbFxaRK49seMuSAWpr1+gEOHjNrKkPMYwdkRUkmJ1QDNv1/UH/8hn0sdnL/reDYnB/6+1rpik1ITNVM5bMXOoNyT0brM6YY0K8G+tk+nC5Ld11UGVLdY33Kx5WjajhAf8SfopGBlPmSB0XmMEg4kNyatITuin8eTmXWQe4rcLiZD+cnQh1irFr72Kp8dP19YC8jaNRAHaThMmLDli8Vy7TK8VawQteziP2p9d9t3B4xxeDYotfv06Omlx2DkYTaBkMoEXm4ukbbDZDki3Y/QZZG0= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:BL0PR12MB4948.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(39860400002)(366004)(136003)(346002)(376002)(396003)(86362001)(186003)(16526019)(2616005)(66556008)(5660300002)(2906002)(31686004)(26005)(956004)(44832011)(31696002)(83380400001)(478600001)(66476007)(316002)(54906003)(52116002)(8676002)(110136005)(6486002)(8936002)(4326008)(66946007)(16576012)(36756003)(6636002)(43740500002)(45980500001); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData: =?utf-8?B?VHZwNUFucXIwRXFyWmJLd3I4YkdjenYzOS9LQmN5aHdrN0Ywa3B1c2VncEt3?= =?utf-8?B?UEwxdHphQmZtSmVGTGhDdGprQlJrcFVNdjlXMTE4a1liQjIveDZXWi84L3ZJ?= =?utf-8?B?ckROTyt3M0w4WWwzUHUvZ08yWk9BV2RDSHlIT3h1NEFWUTBEdzVPMjdIVmk3?= =?utf-8?B?ZTUrUStmS1hyVEE0UDhtVVN1R0J3RmZxWFlFUUZ1VVBUeUZjcVI0MlBpMHVs?= =?utf-8?B?K09LZ25CbnNvOEI0VUE5RElmcFRBT2EzSUthZkVlWmxsZkNjUWdkWlc4YitO?= =?utf-8?B?dVRkaXZObHBGTkltZDhoOGpnV2VFa0hFZEtuQWd5TDlHQzVmSXpPeEpaOWM4?= =?utf-8?B?MWVQMkNSblZOcUVodm9pUHF2RWI4clFoU3VyQVh0a0ZUc3p4UUdFdXVuWFJh?= =?utf-8?B?QWZFS1hFVTZtOUozbDVBdG92UmduWGcxUjQ2cEtNMWJwMWxXYklnV3IrSHgx?= =?utf-8?B?eHZPd2tBT1lpK3p4NloxNGZ3RjI1a1RjcXphQTcrcEk4UzNwa2RvelIvMWZt?= =?utf-8?B?RjZ1THQwU0oxdEVqODBwa2J1THM1TVZuZk9lWXFyblRlOUpwY0l2YitxL0dx?= =?utf-8?B?RHlqemdvbXN2K2h5RHcxd3orUGRnYU4yTVQ0b3E0cWhqSnVVN3BBYVhMNHg0?= =?utf-8?B?ZXpQREloZ0ZjQlN4bE5GdWh3NUJ4L2ZlM0hudGFhWms4c3NRbHpYODNHUTZP?= =?utf-8?B?SVhzY1NkM3BWOHB2bjZVVFdmaTlSMWVjbDVROFc4aVJxeUZyL3lDaUFlMXEw?= =?utf-8?B?Qk1BU1YzMnd0OEFwTHAxZC9wZ3Jna1h3UWV3MVVHSUh4NndydWZtUUIwc1Yw?= =?utf-8?B?NDl5UlY3VXpmMGtPampCMGFsNWd1SStjSTVTdXh6MzU2YWNmOWR1TG5BdHNv?= =?utf-8?B?d0xGM3AvOGhtb3BxRnZUTmJjYzl6dWNKeURNekRwSHlsOWxXMmkvMHdmbERa?= =?utf-8?B?M3RGaStXMzAxOGpEV1BOTzliQ1V1N3ZrQXY0dlhlR0hqdEJsV0U2cFFTeEZX?= =?utf-8?B?SnFpOUZ5cXRNQzh4S0tBYXFHV3lQSTJMeW03WHFvak9BRUVJYzF3MG9sZWhy?= =?utf-8?B?TzA2MWEzNmE2bjZmd1pzQ3pmNzVQVC9GY2V3Mk9zdDBtWTJsdmJEbm11RW5D?= =?utf-8?B?SGxvRlk0QUlKV1JvSU5NSWQvWHZKNU91YXZYQy9PUEk3TS9hM3dLUmExVWhC?= =?utf-8?B?ZVdYL2RJUWxMdTZsamZCMFlVZms1cVdZVWZIYTAyRFZZQVp4djlrV1FHZ2VJ?= =?utf-8?B?cDNFejNXY3BzU283NFNwQjhtN0Qxc292RG5GRlRjZVIyNVRlV1B0VGMrRnBU?= =?utf-8?Q?uTRt3MfZo5hRn05wGCsXqmhp3qEGizEx5J?= X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-AuthSource: BL0PR12MB4948.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 Jan 2021 23:46:19.4666 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-Network-Message-Id: d0feffba-3fcf-4c91-cda3-08d8b42f98f3 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: xZFVMwbBXKnV7qbwpef04r5qWcbH5KyEfYwlspmROyEv9XtGBhsHGtKQS6i8tNFLwwu7j0whna+9a9c7M3/VMw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR12MB4520 X-BeenThere: amd-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Discussion list for AMD gfx List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: David Airlie , linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, amd-gfx@lists.freedesktop.org, Daniel Vetter , Kent Russell Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Errors-To: amd-gfx-bounces@lists.freedesktop.org Sender: "amd-gfx" QW0gMjAyMS0wMS0wOCB1bSAxMTozMSBhLm0uIHNjaHJpZWIgSmVyZW15IENsaW5lOgo+IEtBU0FO IHJlcG9ydGVkIGEgc2xhYi1vdXQtb2YtYm91bmRzIHJlYWQgb2Ygc2l6ZSAxIGluCj4ga2RmX2Ny ZWF0ZV92Y3JhdF9pbWFnZV9jcHUoKS4KPgo+IFRoaXMgb2NjdXJzIHdoZW4sIGZvciBleGFtcGxl LCB3aGVuIG9uIGFuIHg4Nl82NCB3aXRoIGEgc2luZ2xlIE5VTUEgbm9kZQo+IGJlY2F1c2Uga2Zk X2ZpbGxfaW9saW5rX2luZm9fZm9yX2NwdSgpIGlzIGEgbm8tb3AsIGJ1dCBhZnRlcndhcmRzIHRo ZQo+IHN1Yl90eXBlX2hkci0+bGVuZ3RoLCB3aGljaCBpcyBvdXQtb2YtYm91bmRzLCBpcyByZWFk IGFuZCBtdWx0aXBsaWVkIGJ5Cj4gZW50cmllcy4gRm9ydHVuYXRlbHksIGVudHJpZXMgaXMgMCBp biB0aGlzIGNhc2Ugc28gdGhlIG92ZXJhbGwKPiBjcmF0X3RhYmxlLT5sZW5ndGggaXMgc3RpbGwg Y29ycmVjdC4KClRoYXQncyBhIHByZXR0eSBiaWcgY2hhbmdlIHRvIGZpeCB0aGF0LiBXb3VsZG4n dCBpdCBiZSBlbm91Z2ggdG8gYWRkIGEKc2ltcGxlIGNoZWNrIGFmdGVyIGNhbGxpbmcga2ZkX2Zp bGxfaW9saW5rX2luZm9fZm9yX2NwdToKCiAgICBpZiAoZW50cmllcykgewogICAgCWNyYXRfdGFi bGUtPmxlbmd0aCArPSAoc3ViX3R5cGVfaGRyLT5sZW5ndGggKiBlbnRyaWVzKTsKICAgIAljcmF0 X3RhYmxlLT50b3RhbF9lbnRyaWVzICs9IGVudHJpZXM7CiAgICB9CgpPciBjaGFuZ2UgdGhlIG91 dHB1dCBwYXJhbWV0ZXJzIG9mIHRoZSBrZmRfZmlsbF8uLi5fZm9yX2NwdSBmdW5jdGlvbnMKZnJv bSBudW1fZW50cmllcyB0byBzaXplX2ZpbGxlZCwgc28gdGhlIGNhbGxlciBkb2Vzbid0IG5lZWQg dG8gcmVhZApzdWJfdHlwZV9oZHItPmxlbmd0aCBhbnkgbW9yZS4KClJlZ2FyZHMsCsKgIEZlbGl4 CgoKPgo+IFRoaXMgcmVmYWN0b3JzIHRoZSBoZWxwZXIgZnVuY3Rpb25zIHRvIGFjY2VwdCB0aGUg Y3JhdF90YWJsZSBkaXJlY3RseQo+IGFuZCBjYWxjdWxhdGUgdGhlIHRhYmxlIGVudHJ5IHBvaW50 ZXIgYmFzZWQgb24gdGhlIGN1cnJlbnQgdGFibGUgbGVuZ3RoLgo+IFRoaXMgYWxsb3dzIHVzIHRv IGF2b2lkIGFuIG91dC1vZi1ib3VuZHMgcmVhZCBhbmQgaG9wZWZ1bGx5IG1ha2VzIHRoZQo+IHBv aW50ZXIgYXJpdGhtZXRpYyBjbGVhcmVyLiBJdCBzaG91bGQgaGF2ZSBubyBmdW5jdGlvbmFsIGNo YW5nZSBiZXlvbmQKPiByZW1vdmluZyB0aGUgb3V0LW9mLWJvdW5kcyByZWFkLgo+Cj4gRml4ZXM6 IGI3YjZjMzg1MjljOSAoImRybS9hbWRrZmQ6IENhbGN1bGF0ZSBDUFUgVkNSQVQgc2l6ZSBkeW5h bWljYWxseSAodjIpIikKPiBTaWduZWQtb2ZmLWJ5OiBKZXJlbXkgQ2xpbmUgPGpjbGluZUByZWRo YXQuY29tPgo+IC0tLQo+ICBkcml2ZXJzL2dwdS9kcm0vYW1kL2FtZGtmZC9rZmRfY3JhdC5jIHwg ODYgKysrKysrKysrKysrKy0tLS0tLS0tLS0tLS0tCj4gIDEgZmlsZSBjaGFuZ2VkLCA0MCBpbnNl cnRpb25zKCspLCA0NiBkZWxldGlvbnMoLSkKPgo+IGRpZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9k cm0vYW1kL2FtZGtmZC9rZmRfY3JhdC5jIGIvZHJpdmVycy9ncHUvZHJtL2FtZC9hbWRrZmQva2Zk X2NyYXQuYwo+IGluZGV4IDhjYWM0OTdjMmM0NS4uZTUwZGIyYzBmNGVlIDEwMDY0NAo+IC0tLSBh L2RyaXZlcnMvZ3B1L2RybS9hbWQvYW1ka2ZkL2tmZF9jcmF0LmMKPiArKysgYi9kcml2ZXJzL2dw dS9kcm0vYW1kL2FtZGtmZC9rZmRfY3JhdC5jCj4gQEAgLTgyOSwyMSArODI5LDI0IEBAIGludCBr ZmRfY3JlYXRlX2NyYXRfaW1hZ2VfYWNwaSh2b2lkICoqY3JhdF9pbWFnZSwgc2l6ZV90ICpzaXpl KQo+ICAvKiBrZmRfZmlsbF9jdV9mb3JfY3B1IC0gRmlsbCBpbiBDb21wdXRlIGluZm8gZm9yIHRo ZSBnaXZlbiBDUFUgTlVNQSBub2RlCj4gICAqCj4gICAqCUBudW1hX25vZGVfaWQ6IENQVSBOVU1B IG5vZGUgaWQKPiAtICoJQGF2YWlsX3NpemU6IEF2YWlsYWJsZSBzaXplIGluIHRoZSBtZW1vcnkK PiAtICoJQHN1Yl90eXBlX2hkcjogTWVtb3J5IGludG8gd2hpY2ggY29tcHV0ZSBpbmZvIHdpbGwg YmUgZmlsbGVkIGluCj4gKyAqCUBhdmFpbF9zaXplOiBBdmFpbGFibGUgc3BhY2UgaW4gYnl0ZXMg YXQgdGhlIGVuZCBvZiB0aGUgQGNyYXRfdGFibGUuCj4gKyAqCUBjcmF0X3RhYmxlOiBUaGUgQ1JB VCB0YWJsZSB0byBhcHBlbmQgdGhlIENvbXB1dGUgaW5mbyB0bzsKPiArICoJCW9uIHN1Y2Nlc3Mg dGhlIHRhYmxlIGxlbmd0aCBhbmQgdG90YWxfZW50cmllcyBjb3VudCBpcyB1cGRhdGVkLgo+ICAg Kgo+ICAgKglSZXR1cm4gMCBpZiBzdWNjZXNzZnVsIGVsc2UgcmV0dXJuIC12ZSB2YWx1ZQo+ICAg Ki8KPiAgc3RhdGljIGludCBrZmRfZmlsbF9jdV9mb3JfY3B1KGludCBudW1hX25vZGVfaWQsIGlu dCAqYXZhaWxfc2l6ZSwKPiAtCQkJCWludCBwcm94aW1pdHlfZG9tYWluLAo+IC0JCQkJc3RydWN0 IGNyYXRfc3VidHlwZV9jb21wdXRldW5pdCAqc3ViX3R5cGVfaGRyKQo+ICsJCQkJc3RydWN0IGNy YXRfaGVhZGVyICpjcmF0X3RhYmxlKQo+ICB7Cj4gIAljb25zdCBzdHJ1Y3QgY3B1bWFzayAqY3B1 bWFzazsKPiArCXN0cnVjdCBjcmF0X3N1YnR5cGVfY29tcHV0ZXVuaXQgKnN1Yl90eXBlX2hkcjsK PiAgCj4gIAkqYXZhaWxfc2l6ZSAtPSBzaXplb2Yoc3RydWN0IGNyYXRfc3VidHlwZV9jb21wdXRl dW5pdCk7Cj4gIAlpZiAoKmF2YWlsX3NpemUgPCAwKQo+ICAJCXJldHVybiAtRU5PTUVNOwo+ICAK PiArCXN1Yl90eXBlX2hkciA9ICh0eXBlb2Yoc3ViX3R5cGVfaGRyKSkoKGNoYXIgKiljcmF0X3Rh YmxlICsKPiArCQljcmF0X3RhYmxlLT5sZW5ndGgpOwo+ICAJbWVtc2V0KHN1Yl90eXBlX2hkciwg MCwgc2l6ZW9mKHN0cnVjdCBjcmF0X3N1YnR5cGVfY29tcHV0ZXVuaXQpKTsKPiAgCj4gIAkvKiBG aWxsIGluIHN1YnR5cGUgaGVhZGVyIGRhdGEgKi8KPiBAQCAtODU1LDM2ICs4NTgsNDIgQEAgc3Rh dGljIGludCBrZmRfZmlsbF9jdV9mb3JfY3B1KGludCBudW1hX25vZGVfaWQsIGludCAqYXZhaWxf c2l6ZSwKPiAgCj4gIAkvKiBGaWxsIGluIENVIGRhdGEgKi8KPiAgCXN1Yl90eXBlX2hkci0+Zmxh Z3MgfD0gQ1JBVF9DVV9GTEFHU19DUFVfUFJFU0VOVDsKPiAtCXN1Yl90eXBlX2hkci0+cHJveGlt aXR5X2RvbWFpbiA9IHByb3hpbWl0eV9kb21haW47Cj4gKwlzdWJfdHlwZV9oZHItPnByb3hpbWl0 eV9kb21haW4gPSBjcmF0X3RhYmxlLT5udW1fZG9tYWluczsKPiAgCXN1Yl90eXBlX2hkci0+cHJv Y2Vzc29yX2lkX2xvdyA9IGtmZF9udW1hX25vZGVfdG9fYXBpY19pZChudW1hX25vZGVfaWQpOwo+ ICAJaWYgKHN1Yl90eXBlX2hkci0+cHJvY2Vzc29yX2lkX2xvdyA9PSAtMSkKPiAgCQlyZXR1cm4g LUVJTlZBTDsKPiAgCj4gIAlzdWJfdHlwZV9oZHItPm51bV9jcHVfY29yZXMgPSBjcHVtYXNrX3dl aWdodChjcHVtYXNrKTsKPiAgCj4gKwljcmF0X3RhYmxlLT5sZW5ndGggKz0gc3ViX3R5cGVfaGRy LT5sZW5ndGg7Cj4gKwljcmF0X3RhYmxlLT50b3RhbF9lbnRyaWVzKys7Cj4gKwo+ICAJcmV0dXJu IDA7Cj4gIH0KPiAgCj4gIC8qIGtmZF9maWxsX21lbV9pbmZvX2Zvcl9jcHUgLSBGaWxsIGluIE1l bW9yeSBpbmZvIGZvciB0aGUgZ2l2ZW4gQ1BVIE5VTUEgbm9kZQo+ICAgKgo+ICAgKglAbnVtYV9u b2RlX2lkOiBDUFUgTlVNQSBub2RlIGlkCj4gLSAqCUBhdmFpbF9zaXplOiBBdmFpbGFibGUgc2l6 ZSBpbiB0aGUgbWVtb3J5Cj4gLSAqCUBzdWJfdHlwZV9oZHI6IE1lbW9yeSBpbnRvIHdoaWNoIGNv bXB1dGUgaW5mbyB3aWxsIGJlIGZpbGxlZCBpbgo+ICsgKglAYXZhaWxfc2l6ZTogQXZhaWxhYmxl IHNwYWNlIGluIGJ5dGVzIGF0IHRoZSBlbmQgb2YgdGhlIEBjcmF0X3RhYmxlLgo+ICsgKglAY3Jh dF90YWJsZTogVGhlIENSQVQgdGFibGUgdG8gYXBwZW5kIHRoZSBNZW1vcnkgaW5mbyB0bzsKPiAr ICoJCW9uIHN1Y2Nlc3MgdGhlIHRhYmxlIGxlbmd0aCBhbmQgdG90YWxfZW50cmllcyBjb3VudCBp cyB1cGRhdGVkLgo+ICAgKgo+ICAgKglSZXR1cm4gMCBpZiBzdWNjZXNzZnVsIGVsc2UgcmV0dXJu IC12ZSB2YWx1ZQo+ICAgKi8KPiAgc3RhdGljIGludCBrZmRfZmlsbF9tZW1faW5mb19mb3JfY3B1 KGludCBudW1hX25vZGVfaWQsIGludCAqYXZhaWxfc2l6ZSwKPiAtCQkJaW50IHByb3hpbWl0eV9k b21haW4sCj4gLQkJCXN0cnVjdCBjcmF0X3N1YnR5cGVfbWVtb3J5ICpzdWJfdHlwZV9oZHIpCj4g KwkJCXN0cnVjdCBjcmF0X2hlYWRlciAqY3JhdF90YWJsZSkKPiAgewo+ICAJdWludDY0X3QgbWVt X2luX2J5dGVzID0gMDsKPiAgCXBnX2RhdGFfdCAqcGdkYXQ7Cj4gIAlpbnQgem9uZV90eXBlOwo+ ICsJc3RydWN0IGNyYXRfc3VidHlwZV9tZW1vcnkgKnN1Yl90eXBlX2hkcjsKPiAgCj4gIAkqYXZh aWxfc2l6ZSAtPSBzaXplb2Yoc3RydWN0IGNyYXRfc3VidHlwZV9tZW1vcnkpOwo+ICAJaWYgKCph dmFpbF9zaXplIDwgMCkKPiAgCQlyZXR1cm4gLUVOT01FTTsKPiAgCj4gKwlzdWJfdHlwZV9oZHIg PSAodHlwZW9mKHN1Yl90eXBlX2hkcikpKChjaGFyICopY3JhdF90YWJsZSArCj4gKwkJY3JhdF90 YWJsZS0+bGVuZ3RoKTsKPiAgCW1lbXNldChzdWJfdHlwZV9oZHIsIDAsIHNpemVvZihzdHJ1Y3Qg Y3JhdF9zdWJ0eXBlX21lbW9yeSkpOwo+ICAKPiAgCS8qIEZpbGwgaW4gc3VidHlwZSBoZWFkZXIg ZGF0YSAqLwo+IEBAIC05MDUsMjcgKzkxNCwzNyBAQCBzdGF0aWMgaW50IGtmZF9maWxsX21lbV9p bmZvX2Zvcl9jcHUoaW50IG51bWFfbm9kZV9pZCwgaW50ICphdmFpbF9zaXplLAo+ICAKPiAgCXN1 Yl90eXBlX2hkci0+bGVuZ3RoX2xvdyA9IGxvd2VyXzMyX2JpdHMobWVtX2luX2J5dGVzKTsKPiAg CXN1Yl90eXBlX2hkci0+bGVuZ3RoX2hpZ2ggPSB1cHBlcl8zMl9iaXRzKG1lbV9pbl9ieXRlcyk7 Cj4gLQlzdWJfdHlwZV9oZHItPnByb3hpbWl0eV9kb21haW4gPSBwcm94aW1pdHlfZG9tYWluOwo+ ICsJc3ViX3R5cGVfaGRyLT5wcm94aW1pdHlfZG9tYWluID0gY3JhdF90YWJsZS0+bnVtX2RvbWFp bnM7Cj4gKwo+ICsJY3JhdF90YWJsZS0+bGVuZ3RoICs9IHN1Yl90eXBlX2hkci0+bGVuZ3RoOwo+ ICsJY3JhdF90YWJsZS0+dG90YWxfZW50cmllcysrOwo+ICAKPiAgCXJldHVybiAwOwo+ICB9Cj4g IAo+ICAjaWZkZWYgQ09ORklHX1g4Nl82NAo+ICsvKiBrZmRfZmlsbF9pb2xpbmtfaW5mb19mb3Jf Y3B1KCkgLSBBZGQgSU8gbGluayBpbmZvIHRvIGEgVmlydHVhbCBDUkFUCj4gKyAqCj4gKyAqIEBu dW1hX25vZGVfaWQ6IFRoZSBOVU1BIG5vZGUgSUQgZm9yIHRoZSBDUFU7IGFzIGZyb20gZm9yX2Vh Y2hfb25saW5lX25vZGUoKQo+ICsgKiBAYXZhaWxfc2l6ZTogQXZhaWxhYmxlIHNwYWNlIGluIGJ5 dGVzIGF0IHRoZSBlbmQgb2YgdGhlIEBjcmF0X3RhYmxlLgo+ICsgKiBAY3JhdF90YWJsZTogVGhl IENSQVQgdGFibGUgdG8gYXBwZW5kIHRoZSBJTyBsaW5rIGluZm8gdG87IG9uIHN1Y2Nlc3MgdGhl Cj4gKyAqICAgICAgICAgICAgICB0YWJsZSBsZW5ndGggYW5kIHRvdGFsX2VudHJpZXMgY291bnQg aXMgdXBkYXRlZC4KPiArICoKPiArICogUmV0dXJuOiAwIGlmIHN1Y2Nlc3NmdWwgZWxzZSByZXR1 cm4gLXZlIHZhbHVlCj4gKyAqLwo+ICBzdGF0aWMgaW50IGtmZF9maWxsX2lvbGlua19pbmZvX2Zv cl9jcHUoaW50IG51bWFfbm9kZV9pZCwgaW50ICphdmFpbF9zaXplLAo+IC0JCQkJdWludDMyX3Qg Km51bV9lbnRyaWVzLAo+IC0JCQkJc3RydWN0IGNyYXRfc3VidHlwZV9pb2xpbmsgKnN1Yl90eXBl X2hkcikKPiArCQkJCXN0cnVjdCBjcmF0X2hlYWRlciAqY3JhdF90YWJsZSkKPiAgewo+ICAJaW50 IG5pZDsKPiAgCXN0cnVjdCBjcHVpbmZvX3g4NiAqYyA9ICZjcHVfZGF0YSgwKTsKPiAgCXVpbnQ4 X3QgbGlua190eXBlOwo+ICsJc3RydWN0IGNyYXRfc3VidHlwZV9pb2xpbmsgKnN1Yl90eXBlX2hk cjsKPiAgCj4gIAlpZiAoYy0+eDg2X3ZlbmRvciA9PSBYODZfVkVORE9SX0FNRCkKPiAgCQlsaW5r X3R5cGUgPSBDUkFUX0lPTElOS19UWVBFX0hZUEVSVFJBTlNQT1JUOwo+ICAJZWxzZQo+ICAJCWxp bmtfdHlwZSA9IENSQVRfSU9MSU5LX1RZUEVfUVBJXzFfMTsKPiAgCj4gLQkqbnVtX2VudHJpZXMg PSAwOwo+IC0KPiAgCS8qIENyZWF0ZSBJTyBsaW5rcyBmcm9tIHRoaXMgbm9kZSB0byBvdGhlciBD UFUgbm9kZXMgKi8KPiAgCWZvcl9lYWNoX29ubGluZV9ub2RlKG5pZCkgewo+ICAJCWlmIChuaWQg PT0gbnVtYV9ub2RlX2lkKSAvKiBub2RlIGl0c2VsZiAqLwo+IEBAIC05MzUsNiArOTU0LDggQEAg c3RhdGljIGludCBrZmRfZmlsbF9pb2xpbmtfaW5mb19mb3JfY3B1KGludCBudW1hX25vZGVfaWQs IGludCAqYXZhaWxfc2l6ZSwKPiAgCQlpZiAoKmF2YWlsX3NpemUgPCAwKQo+ICAJCQlyZXR1cm4g LUVOT01FTTsKPiAgCj4gKwkJc3ViX3R5cGVfaGRyID0gKHR5cGVvZihzdWJfdHlwZV9oZHIpKSgo Y2hhciAqKWNyYXRfdGFibGUgKwo+ICsJCQljcmF0X3RhYmxlLT5sZW5ndGgpOwo+ICAJCW1lbXNl dChzdWJfdHlwZV9oZHIsIDAsIHNpemVvZihzdHJ1Y3QgY3JhdF9zdWJ0eXBlX2lvbGluaykpOwo+ ICAKPiAgCQkvKiBGaWxsIGluIHN1YnR5cGUgaGVhZGVyIGRhdGEgKi8KPiBAQCAtOTQ3LDggKzk2 OCw4IEBAIHN0YXRpYyBpbnQga2ZkX2ZpbGxfaW9saW5rX2luZm9fZm9yX2NwdShpbnQgbnVtYV9u b2RlX2lkLCBpbnQgKmF2YWlsX3NpemUsCj4gIAkJc3ViX3R5cGVfaGRyLT5wcm94aW1pdHlfZG9t YWluX3RvID0gbmlkOwo+ICAJCXN1Yl90eXBlX2hkci0+aW9faW50ZXJmYWNlX3R5cGUgPSBsaW5r X3R5cGU7Cj4gIAo+IC0JCSgqbnVtX2VudHJpZXMpKys7Cj4gLQkJc3ViX3R5cGVfaGRyKys7Cj4g KwkJY3JhdF90YWJsZS0+bGVuZ3RoICs9IHN1Yl90eXBlX2hkci0+bGVuZ3RoOwo+ICsJCWNyYXRf dGFibGUtPnRvdGFsX2VudHJpZXMrKzsKPiAgCX0KPiAgCj4gIAlyZXR1cm4gMDsKPiBAQCAtOTY2 LDEyICs5ODcsOCBAQCBzdGF0aWMgaW50IGtmZF9jcmVhdGVfdmNyYXRfaW1hZ2VfY3B1KHZvaWQg KnBjcmF0X2ltYWdlLCBzaXplX3QgKnNpemUpCj4gIAlzdHJ1Y3QgY3JhdF9oZWFkZXIgKmNyYXRf dGFibGUgPSAoc3RydWN0IGNyYXRfaGVhZGVyICopcGNyYXRfaW1hZ2U7Cj4gIAlzdHJ1Y3QgYWNw aV90YWJsZV9oZWFkZXIgKmFjcGlfdGFibGU7Cj4gIAlhY3BpX3N0YXR1cyBzdGF0dXM7Cj4gLQlz dHJ1Y3QgY3JhdF9zdWJ0eXBlX2dlbmVyaWMgKnN1Yl90eXBlX2hkcjsKPiAgCWludCBhdmFpbF9z aXplID0gKnNpemU7Cj4gIAlpbnQgbnVtYV9ub2RlX2lkOwo+IC0jaWZkZWYgQ09ORklHX1g4Nl82 NAo+IC0JdWludDMyX3QgZW50cmllcyA9IDA7Cj4gLSNlbmRpZgo+ICAJaW50IHJldCA9IDA7Cj4g IAo+ICAJaWYgKCFwY3JhdF9pbWFnZSkKPiBAQCAtMTAwMyw0OCArMTAyMCwyNSBAQCBzdGF0aWMg aW50IGtmZF9jcmVhdGVfdmNyYXRfaW1hZ2VfY3B1KHZvaWQgKnBjcmF0X2ltYWdlLCBzaXplX3Qg KnNpemUpCj4gIAljcmF0X3RhYmxlLT50b3RhbF9lbnRyaWVzID0gMDsKPiAgCWNyYXRfdGFibGUt Pm51bV9kb21haW5zID0gMDsKPiAgCj4gLQlzdWJfdHlwZV9oZHIgPSAoc3RydWN0IGNyYXRfc3Vi dHlwZV9nZW5lcmljICopKGNyYXRfdGFibGUrMSk7Cj4gLQo+ICAJZm9yX2VhY2hfb25saW5lX25v ZGUobnVtYV9ub2RlX2lkKSB7Cj4gIAkJaWYgKGtmZF9udW1hX25vZGVfdG9fYXBpY19pZChudW1h X25vZGVfaWQpID09IC0xKQo+ICAJCQljb250aW51ZTsKPiAgCj4gIAkJLyogRmlsbCBpbiBTdWJ0 eXBlOiBDb21wdXRlIFVuaXQgKi8KPiAtCQlyZXQgPSBrZmRfZmlsbF9jdV9mb3JfY3B1KG51bWFf bm9kZV9pZCwgJmF2YWlsX3NpemUsCj4gLQkJCWNyYXRfdGFibGUtPm51bV9kb21haW5zLAo+IC0J CQkoc3RydWN0IGNyYXRfc3VidHlwZV9jb21wdXRldW5pdCAqKXN1Yl90eXBlX2hkcik7Cj4gKwkJ cmV0ID0ga2ZkX2ZpbGxfY3VfZm9yX2NwdShudW1hX25vZGVfaWQsICZhdmFpbF9zaXplLCBjcmF0 X3RhYmxlKTsKPiAgCQlpZiAocmV0IDwgMCkKPiAgCQkJcmV0dXJuIHJldDsKPiAtCQljcmF0X3Rh YmxlLT5sZW5ndGggKz0gc3ViX3R5cGVfaGRyLT5sZW5ndGg7Cj4gLQkJY3JhdF90YWJsZS0+dG90 YWxfZW50cmllcysrOwo+IC0KPiAtCQlzdWJfdHlwZV9oZHIgPSAodHlwZW9mKHN1Yl90eXBlX2hk cikpKChjaGFyICopc3ViX3R5cGVfaGRyICsKPiAtCQkJc3ViX3R5cGVfaGRyLT5sZW5ndGgpOwo+ ICAKPiAgCQkvKiBGaWxsIGluIFN1YnR5cGU6IE1lbW9yeSAqLwo+IC0JCXJldCA9IGtmZF9maWxs X21lbV9pbmZvX2Zvcl9jcHUobnVtYV9ub2RlX2lkLCAmYXZhaWxfc2l6ZSwKPiAtCQkJY3JhdF90 YWJsZS0+bnVtX2RvbWFpbnMsCj4gLQkJCShzdHJ1Y3QgY3JhdF9zdWJ0eXBlX21lbW9yeSAqKXN1 Yl90eXBlX2hkcik7Cj4gKwkJcmV0ID0ga2ZkX2ZpbGxfbWVtX2luZm9fZm9yX2NwdShudW1hX25v ZGVfaWQsICZhdmFpbF9zaXplLCBjcmF0X3RhYmxlKTsKPiAgCQlpZiAocmV0IDwgMCkKPiAgCQkJ cmV0dXJuIHJldDsKPiAtCQljcmF0X3RhYmxlLT5sZW5ndGggKz0gc3ViX3R5cGVfaGRyLT5sZW5n dGg7Cj4gLQkJY3JhdF90YWJsZS0+dG90YWxfZW50cmllcysrOwo+IC0KPiAtCQlzdWJfdHlwZV9o ZHIgPSAodHlwZW9mKHN1Yl90eXBlX2hkcikpKChjaGFyICopc3ViX3R5cGVfaGRyICsKPiAtCQkJ c3ViX3R5cGVfaGRyLT5sZW5ndGgpOwo+ICAKPiAgCQkvKiBGaWxsIGluIFN1YnR5cGU6IElPIExp bmsgKi8KPiAgI2lmZGVmIENPTkZJR19YODZfNjQKPiAtCQlyZXQgPSBrZmRfZmlsbF9pb2xpbmtf aW5mb19mb3JfY3B1KG51bWFfbm9kZV9pZCwgJmF2YWlsX3NpemUsCj4gLQkJCQkmZW50cmllcywK PiAtCQkJCShzdHJ1Y3QgY3JhdF9zdWJ0eXBlX2lvbGluayAqKXN1Yl90eXBlX2hkcik7Cj4gKwkJ cmV0ID0ga2ZkX2ZpbGxfaW9saW5rX2luZm9fZm9yX2NwdShudW1hX25vZGVfaWQsICZhdmFpbF9z aXplLCBjcmF0X3RhYmxlKTsKPiAgCQlpZiAocmV0IDwgMCkKPiAgCQkJcmV0dXJuIHJldDsKPiAt CQljcmF0X3RhYmxlLT5sZW5ndGggKz0gKHN1Yl90eXBlX2hkci0+bGVuZ3RoICogZW50cmllcyk7 Cj4gLQkJY3JhdF90YWJsZS0+dG90YWxfZW50cmllcyArPSBlbnRyaWVzOwo+IC0KPiAtCQlzdWJf dHlwZV9oZHIgPSAodHlwZW9mKHN1Yl90eXBlX2hkcikpKChjaGFyICopc3ViX3R5cGVfaGRyICsK PiAtCQkJCXN1Yl90eXBlX2hkci0+bGVuZ3RoICogZW50cmllcyk7Cj4gICNlbHNlCj4gIAkJcHJf aW5mbygiSU8gbGluayBub3QgYXZhaWxhYmxlIGZvciBub24geDg2IHBsYXRmb3Jtc1xuIik7Cj4g ICNlbmRpZgpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwph bWQtZ2Z4IG1haWxpbmcgbGlzdAphbWQtZ2Z4QGxpc3RzLmZyZWVkZXNrdG9wLm9yZwpodHRwczov L2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2FtZC1nZngK From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.3 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,MSGID_FROM_MTA_HEADER,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7DB1BC433DB for ; Fri, 8 Jan 2021 23:46:24 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 2D23F23A5A for ; Fri, 8 Jan 2021 23:46:24 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 2D23F23A5A Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=amd.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id ACADA6E8D2; Fri, 8 Jan 2021 23:46:23 +0000 (UTC) Received: from NAM10-BN7-obe.outbound.protection.outlook.com (mail-bn7nam10on2084.outbound.protection.outlook.com [40.107.92.84]) by gabe.freedesktop.org (Postfix) with ESMTPS id EBFE86E8D2; Fri, 8 Jan 2021 23:46:22 +0000 (UTC) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=jkS6vHFBJ91/h/UyxSUx7nU2fJ/LSm/CC8wI2NK+1gpudur2+fmBUzu6H65ZoqodF/dDp+Allzdq9G44osm6q2kwc/Sq6//n7kgZuhk2xuuJZgPxtu5McA3WHZWi+LFeuqoVD+rDn8MaNrqb/kUsMWNpAJdOX2zs4wcOyik7qA5Pdea7FZo10tI9lHfo/MgkqPd6m9cp2Vxzxp9fLCyoICteFo7szQsjkUN3U/fPIr395LDvcviu+yIcKIr+JaL8xoIK8bkR/tTgngpO/cHh88j8yG5r8hnO13MmjgpV1iQXQZw75/J3KddG2Wv5rY5JCg+E86emZ0O1dbZ+9eslug== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=r1zsCMm2IZu7bnrKiFRXZRbBuhc/w6WvrT6pl6zKQeA=; b=Erhd/dU+2ibaENvAXTr7EBm1p4Da/bJSoKI4+x9D1NiQeeTkCij6FFFA+EEkxhEB4HY7APO47LzjKzYzgQZHl8+Jf8iKHxsNiFbc7Mp2mWzuhWLsmsyV3i8413pJ+xuKIZxfEEU9uHiBBiPfj1SaJbt7nN9FUvqLU0NPk7PBp4WHKzx+XGLp5pnZGwSJODLa6aEFj2JSBhSUZnjMNk7DBjmVpyv4PiS9/yCeUSdUmtmaMlBj0RHl2oGPecyeRkRUZEbSi8+3RekTfN3/di2FaJjG2GB8eHfeLITkE1VeYG/ErtemNIfFoKBgZ1R5WSwD4t7dZoLtWsi1vBKVOJFJtA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=r1zsCMm2IZu7bnrKiFRXZRbBuhc/w6WvrT6pl6zKQeA=; b=PUGO06Kjbs7U4SzOZBmQjMczXAVD820QjjxjeEOQGUViDYz2ePX0rzTGK9YWFhBAqpx4MGf5z+pbfGjp3yyJ3rXYxyLfpX6ywWuWIzx4f8obfMpIRnE6ngK16yKVfOMgh2gS7qzRtBHniE/Q2dFtF6EkLNkStKwqaZbNkQl8yRQ= Authentication-Results: vger.kernel.org; dkim=none (message not signed) header.d=none;vger.kernel.org; dmarc=none action=none header.from=amd.com; Received: from BL0PR12MB4948.namprd12.prod.outlook.com (2603:10b6:208:1cc::20) by MN2PR12MB4520.namprd12.prod.outlook.com (2603:10b6:208:26f::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3742.6; Fri, 8 Jan 2021 23:46:19 +0000 Received: from BL0PR12MB4948.namprd12.prod.outlook.com ([fe80::9425:559:83c0:991b]) by BL0PR12MB4948.namprd12.prod.outlook.com ([fe80::9425:559:83c0:991b%9]) with mapi id 15.20.3742.011; Fri, 8 Jan 2021 23:46:19 +0000 Subject: Re: [PATCH] drm/amdkfd: Fix out-of-bounds read in kdf_create_vcrat_image_cpu() To: Jeremy Cline , Alex Deucher , =?UTF-8?Q?Christian_K=c3=b6nig?= References: <20210108163104.411442-1-jcline@redhat.com> From: Felix Kuehling Message-ID: Date: Fri, 8 Jan 2021 18:46:17 -0500 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 In-Reply-To: <20210108163104.411442-1-jcline@redhat.com> Content-Language: en-US X-Originating-IP: [142.117.121.176] X-ClientProxiedBy: YTXPR0101CA0031.CANPRD01.PROD.OUTLOOK.COM (2603:10b6:b00::44) To BL0PR12MB4948.namprd12.prod.outlook.com (2603:10b6:208:1cc::20) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 Received: from [192.168.2.100] (142.117.121.176) by YTXPR0101CA0031.CANPRD01.PROD.OUTLOOK.COM (2603:10b6:b00::44) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3742.6 via Frontend Transport; Fri, 8 Jan 2021 23:46:18 +0000 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-HT: Tenant X-MS-Office365-Filtering-Correlation-Id: d0feffba-3fcf-4c91-cda3-08d8b42f98f3 X-MS-TrafficTypeDiagnostic: MN2PR12MB4520: X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:10000; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: Yik+0npIL5H+dEAxyhxnyMl7HxOj+26+OM9NmEGq/gCFnoEFursP3YIjxVSc+12G1XN8AWOZsj1frtfQ3rD4D6qNhxxwZu8S/T0HgCXuL2x1SvXocDfLEGYYtVqrbZvdNnj1MPtNVEK3n8OtHvBhEgG7uBiBypwRatGxkCV0Jh57aGaAcCoQv6EB+fnfkmkTJNleN/97IfATfHtFp3FFbFxaRK49seMuSAWpr1+gEOHjNrKkPMYwdkRUkmJ1QDNv1/UH/8hn0sdnL/reDYnB/6+1rpik1ITNVM5bMXOoNyT0brM6YY0K8G+tk+nC5Ld11UGVLdY33Kx5WjajhAf8SfopGBlPmSB0XmMEg4kNyatITuin8eTmXWQe4rcLiZD+cnQh1irFr72Kp8dP19YC8jaNRAHaThMmLDli8Vy7TK8VawQteziP2p9d9t3B4xxeDYotfv06Omlx2DkYTaBkMoEXm4ukbbDZDki3Y/QZZG0= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:BL0PR12MB4948.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(39860400002)(366004)(136003)(346002)(376002)(396003)(86362001)(186003)(16526019)(2616005)(66556008)(5660300002)(2906002)(31686004)(26005)(956004)(44832011)(31696002)(83380400001)(478600001)(66476007)(316002)(54906003)(52116002)(8676002)(110136005)(6486002)(8936002)(4326008)(66946007)(16576012)(36756003)(6636002)(43740500002)(45980500001); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData: =?utf-8?B?VHZwNUFucXIwRXFyWmJLd3I4YkdjenYzOS9LQmN5aHdrN0Ywa3B1c2VncEt3?= =?utf-8?B?UEwxdHphQmZtSmVGTGhDdGprQlJrcFVNdjlXMTE4a1liQjIveDZXWi84L3ZJ?= =?utf-8?B?ckROTyt3M0w4WWwzUHUvZ08yWk9BV2RDSHlIT3h1NEFWUTBEdzVPMjdIVmk3?= =?utf-8?B?ZTUrUStmS1hyVEE0UDhtVVN1R0J3RmZxWFlFUUZ1VVBUeUZjcVI0MlBpMHVs?= =?utf-8?B?K09LZ25CbnNvOEI0VUE5RElmcFRBT2EzSUthZkVlWmxsZkNjUWdkWlc4YitO?= =?utf-8?B?dVRkaXZObHBGTkltZDhoOGpnV2VFa0hFZEtuQWd5TDlHQzVmSXpPeEpaOWM4?= =?utf-8?B?MWVQMkNSblZOcUVodm9pUHF2RWI4clFoU3VyQVh0a0ZUc3p4UUdFdXVuWFJh?= =?utf-8?B?QWZFS1hFVTZtOUozbDVBdG92UmduWGcxUjQ2cEtNMWJwMWxXYklnV3IrSHgx?= =?utf-8?B?eHZPd2tBT1lpK3p4NloxNGZ3RjI1a1RjcXphQTcrcEk4UzNwa2RvelIvMWZt?= =?utf-8?B?RjZ1THQwU0oxdEVqODBwa2J1THM1TVZuZk9lWXFyblRlOUpwY0l2YitxL0dx?= =?utf-8?B?RHlqemdvbXN2K2h5RHcxd3orUGRnYU4yTVQ0b3E0cWhqSnVVN3BBYVhMNHg0?= =?utf-8?B?ZXpQREloZ0ZjQlN4bE5GdWh3NUJ4L2ZlM0hudGFhWms4c3NRbHpYODNHUTZP?= =?utf-8?B?SVhzY1NkM3BWOHB2bjZVVFdmaTlSMWVjbDVROFc4aVJxeUZyL3lDaUFlMXEw?= =?utf-8?B?Qk1BU1YzMnd0OEFwTHAxZC9wZ3Jna1h3UWV3MVVHSUh4NndydWZtUUIwc1Yw?= =?utf-8?B?NDl5UlY3VXpmMGtPampCMGFsNWd1SStjSTVTdXh6MzU2YWNmOWR1TG5BdHNv?= =?utf-8?B?d0xGM3AvOGhtb3BxRnZUTmJjYzl6dWNKeURNekRwSHlsOWxXMmkvMHdmbERa?= =?utf-8?B?M3RGaStXMzAxOGpEV1BOTzliQ1V1N3ZrQXY0dlhlR0hqdEJsV0U2cFFTeEZX?= =?utf-8?B?SnFpOUZ5cXRNQzh4S0tBYXFHV3lQSTJMeW03WHFvak9BRUVJYzF3MG9sZWhy?= =?utf-8?B?TzA2MWEzNmE2bjZmd1pzQ3pmNzVQVC9GY2V3Mk9zdDBtWTJsdmJEbm11RW5D?= =?utf-8?B?SGxvRlk0QUlKV1JvSU5NSWQvWHZKNU91YXZYQy9PUEk3TS9hM3dLUmExVWhC?= =?utf-8?B?ZVdYL2RJUWxMdTZsamZCMFlVZms1cVdZVWZIYTAyRFZZQVp4djlrV1FHZ2VJ?= =?utf-8?B?cDNFejNXY3BzU283NFNwQjhtN0Qxc292RG5GRlRjZVIyNVRlV1B0VGMrRnBU?= =?utf-8?Q?uTRt3MfZo5hRn05wGCsXqmhp3qEGizEx5J?= X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-AuthSource: BL0PR12MB4948.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 Jan 2021 23:46:19.4666 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-Network-Message-Id: d0feffba-3fcf-4c91-cda3-08d8b42f98f3 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: xZFVMwbBXKnV7qbwpef04r5qWcbH5KyEfYwlspmROyEv9XtGBhsHGtKQS6i8tNFLwwu7j0whna+9a9c7M3/VMw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR12MB4520 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: David Airlie , linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, amd-gfx@lists.freedesktop.org, Kent Russell Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" QW0gMjAyMS0wMS0wOCB1bSAxMTozMSBhLm0uIHNjaHJpZWIgSmVyZW15IENsaW5lOgo+IEtBU0FO IHJlcG9ydGVkIGEgc2xhYi1vdXQtb2YtYm91bmRzIHJlYWQgb2Ygc2l6ZSAxIGluCj4ga2RmX2Ny ZWF0ZV92Y3JhdF9pbWFnZV9jcHUoKS4KPgo+IFRoaXMgb2NjdXJzIHdoZW4sIGZvciBleGFtcGxl LCB3aGVuIG9uIGFuIHg4Nl82NCB3aXRoIGEgc2luZ2xlIE5VTUEgbm9kZQo+IGJlY2F1c2Uga2Zk X2ZpbGxfaW9saW5rX2luZm9fZm9yX2NwdSgpIGlzIGEgbm8tb3AsIGJ1dCBhZnRlcndhcmRzIHRo ZQo+IHN1Yl90eXBlX2hkci0+bGVuZ3RoLCB3aGljaCBpcyBvdXQtb2YtYm91bmRzLCBpcyByZWFk IGFuZCBtdWx0aXBsaWVkIGJ5Cj4gZW50cmllcy4gRm9ydHVuYXRlbHksIGVudHJpZXMgaXMgMCBp biB0aGlzIGNhc2Ugc28gdGhlIG92ZXJhbGwKPiBjcmF0X3RhYmxlLT5sZW5ndGggaXMgc3RpbGwg Y29ycmVjdC4KClRoYXQncyBhIHByZXR0eSBiaWcgY2hhbmdlIHRvIGZpeCB0aGF0LiBXb3VsZG4n dCBpdCBiZSBlbm91Z2ggdG8gYWRkIGEKc2ltcGxlIGNoZWNrIGFmdGVyIGNhbGxpbmcga2ZkX2Zp bGxfaW9saW5rX2luZm9fZm9yX2NwdToKCiAgICBpZiAoZW50cmllcykgewogICAgCWNyYXRfdGFi bGUtPmxlbmd0aCArPSAoc3ViX3R5cGVfaGRyLT5sZW5ndGggKiBlbnRyaWVzKTsKICAgIAljcmF0 X3RhYmxlLT50b3RhbF9lbnRyaWVzICs9IGVudHJpZXM7CiAgICB9CgpPciBjaGFuZ2UgdGhlIG91 dHB1dCBwYXJhbWV0ZXJzIG9mIHRoZSBrZmRfZmlsbF8uLi5fZm9yX2NwdSBmdW5jdGlvbnMKZnJv bSBudW1fZW50cmllcyB0byBzaXplX2ZpbGxlZCwgc28gdGhlIGNhbGxlciBkb2Vzbid0IG5lZWQg dG8gcmVhZApzdWJfdHlwZV9oZHItPmxlbmd0aCBhbnkgbW9yZS4KClJlZ2FyZHMsCsKgIEZlbGl4 CgoKPgo+IFRoaXMgcmVmYWN0b3JzIHRoZSBoZWxwZXIgZnVuY3Rpb25zIHRvIGFjY2VwdCB0aGUg Y3JhdF90YWJsZSBkaXJlY3RseQo+IGFuZCBjYWxjdWxhdGUgdGhlIHRhYmxlIGVudHJ5IHBvaW50 ZXIgYmFzZWQgb24gdGhlIGN1cnJlbnQgdGFibGUgbGVuZ3RoLgo+IFRoaXMgYWxsb3dzIHVzIHRv IGF2b2lkIGFuIG91dC1vZi1ib3VuZHMgcmVhZCBhbmQgaG9wZWZ1bGx5IG1ha2VzIHRoZQo+IHBv aW50ZXIgYXJpdGhtZXRpYyBjbGVhcmVyLiBJdCBzaG91bGQgaGF2ZSBubyBmdW5jdGlvbmFsIGNo YW5nZSBiZXlvbmQKPiByZW1vdmluZyB0aGUgb3V0LW9mLWJvdW5kcyByZWFkLgo+Cj4gRml4ZXM6 IGI3YjZjMzg1MjljOSAoImRybS9hbWRrZmQ6IENhbGN1bGF0ZSBDUFUgVkNSQVQgc2l6ZSBkeW5h bWljYWxseSAodjIpIikKPiBTaWduZWQtb2ZmLWJ5OiBKZXJlbXkgQ2xpbmUgPGpjbGluZUByZWRo YXQuY29tPgo+IC0tLQo+ICBkcml2ZXJzL2dwdS9kcm0vYW1kL2FtZGtmZC9rZmRfY3JhdC5jIHwg ODYgKysrKysrKysrKysrKy0tLS0tLS0tLS0tLS0tCj4gIDEgZmlsZSBjaGFuZ2VkLCA0MCBpbnNl cnRpb25zKCspLCA0NiBkZWxldGlvbnMoLSkKPgo+IGRpZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9k cm0vYW1kL2FtZGtmZC9rZmRfY3JhdC5jIGIvZHJpdmVycy9ncHUvZHJtL2FtZC9hbWRrZmQva2Zk X2NyYXQuYwo+IGluZGV4IDhjYWM0OTdjMmM0NS4uZTUwZGIyYzBmNGVlIDEwMDY0NAo+IC0tLSBh L2RyaXZlcnMvZ3B1L2RybS9hbWQvYW1ka2ZkL2tmZF9jcmF0LmMKPiArKysgYi9kcml2ZXJzL2dw dS9kcm0vYW1kL2FtZGtmZC9rZmRfY3JhdC5jCj4gQEAgLTgyOSwyMSArODI5LDI0IEBAIGludCBr ZmRfY3JlYXRlX2NyYXRfaW1hZ2VfYWNwaSh2b2lkICoqY3JhdF9pbWFnZSwgc2l6ZV90ICpzaXpl KQo+ICAvKiBrZmRfZmlsbF9jdV9mb3JfY3B1IC0gRmlsbCBpbiBDb21wdXRlIGluZm8gZm9yIHRo ZSBnaXZlbiBDUFUgTlVNQSBub2RlCj4gICAqCj4gICAqCUBudW1hX25vZGVfaWQ6IENQVSBOVU1B IG5vZGUgaWQKPiAtICoJQGF2YWlsX3NpemU6IEF2YWlsYWJsZSBzaXplIGluIHRoZSBtZW1vcnkK PiAtICoJQHN1Yl90eXBlX2hkcjogTWVtb3J5IGludG8gd2hpY2ggY29tcHV0ZSBpbmZvIHdpbGwg YmUgZmlsbGVkIGluCj4gKyAqCUBhdmFpbF9zaXplOiBBdmFpbGFibGUgc3BhY2UgaW4gYnl0ZXMg YXQgdGhlIGVuZCBvZiB0aGUgQGNyYXRfdGFibGUuCj4gKyAqCUBjcmF0X3RhYmxlOiBUaGUgQ1JB VCB0YWJsZSB0byBhcHBlbmQgdGhlIENvbXB1dGUgaW5mbyB0bzsKPiArICoJCW9uIHN1Y2Nlc3Mg dGhlIHRhYmxlIGxlbmd0aCBhbmQgdG90YWxfZW50cmllcyBjb3VudCBpcyB1cGRhdGVkLgo+ICAg Kgo+ICAgKglSZXR1cm4gMCBpZiBzdWNjZXNzZnVsIGVsc2UgcmV0dXJuIC12ZSB2YWx1ZQo+ICAg Ki8KPiAgc3RhdGljIGludCBrZmRfZmlsbF9jdV9mb3JfY3B1KGludCBudW1hX25vZGVfaWQsIGlu dCAqYXZhaWxfc2l6ZSwKPiAtCQkJCWludCBwcm94aW1pdHlfZG9tYWluLAo+IC0JCQkJc3RydWN0 IGNyYXRfc3VidHlwZV9jb21wdXRldW5pdCAqc3ViX3R5cGVfaGRyKQo+ICsJCQkJc3RydWN0IGNy YXRfaGVhZGVyICpjcmF0X3RhYmxlKQo+ICB7Cj4gIAljb25zdCBzdHJ1Y3QgY3B1bWFzayAqY3B1 bWFzazsKPiArCXN0cnVjdCBjcmF0X3N1YnR5cGVfY29tcHV0ZXVuaXQgKnN1Yl90eXBlX2hkcjsK PiAgCj4gIAkqYXZhaWxfc2l6ZSAtPSBzaXplb2Yoc3RydWN0IGNyYXRfc3VidHlwZV9jb21wdXRl dW5pdCk7Cj4gIAlpZiAoKmF2YWlsX3NpemUgPCAwKQo+ICAJCXJldHVybiAtRU5PTUVNOwo+ICAK PiArCXN1Yl90eXBlX2hkciA9ICh0eXBlb2Yoc3ViX3R5cGVfaGRyKSkoKGNoYXIgKiljcmF0X3Rh YmxlICsKPiArCQljcmF0X3RhYmxlLT5sZW5ndGgpOwo+ICAJbWVtc2V0KHN1Yl90eXBlX2hkciwg MCwgc2l6ZW9mKHN0cnVjdCBjcmF0X3N1YnR5cGVfY29tcHV0ZXVuaXQpKTsKPiAgCj4gIAkvKiBG aWxsIGluIHN1YnR5cGUgaGVhZGVyIGRhdGEgKi8KPiBAQCAtODU1LDM2ICs4NTgsNDIgQEAgc3Rh dGljIGludCBrZmRfZmlsbF9jdV9mb3JfY3B1KGludCBudW1hX25vZGVfaWQsIGludCAqYXZhaWxf c2l6ZSwKPiAgCj4gIAkvKiBGaWxsIGluIENVIGRhdGEgKi8KPiAgCXN1Yl90eXBlX2hkci0+Zmxh Z3MgfD0gQ1JBVF9DVV9GTEFHU19DUFVfUFJFU0VOVDsKPiAtCXN1Yl90eXBlX2hkci0+cHJveGlt aXR5X2RvbWFpbiA9IHByb3hpbWl0eV9kb21haW47Cj4gKwlzdWJfdHlwZV9oZHItPnByb3hpbWl0 eV9kb21haW4gPSBjcmF0X3RhYmxlLT5udW1fZG9tYWluczsKPiAgCXN1Yl90eXBlX2hkci0+cHJv Y2Vzc29yX2lkX2xvdyA9IGtmZF9udW1hX25vZGVfdG9fYXBpY19pZChudW1hX25vZGVfaWQpOwo+ ICAJaWYgKHN1Yl90eXBlX2hkci0+cHJvY2Vzc29yX2lkX2xvdyA9PSAtMSkKPiAgCQlyZXR1cm4g LUVJTlZBTDsKPiAgCj4gIAlzdWJfdHlwZV9oZHItPm51bV9jcHVfY29yZXMgPSBjcHVtYXNrX3dl aWdodChjcHVtYXNrKTsKPiAgCj4gKwljcmF0X3RhYmxlLT5sZW5ndGggKz0gc3ViX3R5cGVfaGRy LT5sZW5ndGg7Cj4gKwljcmF0X3RhYmxlLT50b3RhbF9lbnRyaWVzKys7Cj4gKwo+ICAJcmV0dXJu IDA7Cj4gIH0KPiAgCj4gIC8qIGtmZF9maWxsX21lbV9pbmZvX2Zvcl9jcHUgLSBGaWxsIGluIE1l bW9yeSBpbmZvIGZvciB0aGUgZ2l2ZW4gQ1BVIE5VTUEgbm9kZQo+ICAgKgo+ICAgKglAbnVtYV9u b2RlX2lkOiBDUFUgTlVNQSBub2RlIGlkCj4gLSAqCUBhdmFpbF9zaXplOiBBdmFpbGFibGUgc2l6 ZSBpbiB0aGUgbWVtb3J5Cj4gLSAqCUBzdWJfdHlwZV9oZHI6IE1lbW9yeSBpbnRvIHdoaWNoIGNv bXB1dGUgaW5mbyB3aWxsIGJlIGZpbGxlZCBpbgo+ICsgKglAYXZhaWxfc2l6ZTogQXZhaWxhYmxl IHNwYWNlIGluIGJ5dGVzIGF0IHRoZSBlbmQgb2YgdGhlIEBjcmF0X3RhYmxlLgo+ICsgKglAY3Jh dF90YWJsZTogVGhlIENSQVQgdGFibGUgdG8gYXBwZW5kIHRoZSBNZW1vcnkgaW5mbyB0bzsKPiAr ICoJCW9uIHN1Y2Nlc3MgdGhlIHRhYmxlIGxlbmd0aCBhbmQgdG90YWxfZW50cmllcyBjb3VudCBp cyB1cGRhdGVkLgo+ICAgKgo+ICAgKglSZXR1cm4gMCBpZiBzdWNjZXNzZnVsIGVsc2UgcmV0dXJu IC12ZSB2YWx1ZQo+ICAgKi8KPiAgc3RhdGljIGludCBrZmRfZmlsbF9tZW1faW5mb19mb3JfY3B1 KGludCBudW1hX25vZGVfaWQsIGludCAqYXZhaWxfc2l6ZSwKPiAtCQkJaW50IHByb3hpbWl0eV9k b21haW4sCj4gLQkJCXN0cnVjdCBjcmF0X3N1YnR5cGVfbWVtb3J5ICpzdWJfdHlwZV9oZHIpCj4g KwkJCXN0cnVjdCBjcmF0X2hlYWRlciAqY3JhdF90YWJsZSkKPiAgewo+ICAJdWludDY0X3QgbWVt X2luX2J5dGVzID0gMDsKPiAgCXBnX2RhdGFfdCAqcGdkYXQ7Cj4gIAlpbnQgem9uZV90eXBlOwo+ ICsJc3RydWN0IGNyYXRfc3VidHlwZV9tZW1vcnkgKnN1Yl90eXBlX2hkcjsKPiAgCj4gIAkqYXZh aWxfc2l6ZSAtPSBzaXplb2Yoc3RydWN0IGNyYXRfc3VidHlwZV9tZW1vcnkpOwo+ICAJaWYgKCph dmFpbF9zaXplIDwgMCkKPiAgCQlyZXR1cm4gLUVOT01FTTsKPiAgCj4gKwlzdWJfdHlwZV9oZHIg PSAodHlwZW9mKHN1Yl90eXBlX2hkcikpKChjaGFyICopY3JhdF90YWJsZSArCj4gKwkJY3JhdF90 YWJsZS0+bGVuZ3RoKTsKPiAgCW1lbXNldChzdWJfdHlwZV9oZHIsIDAsIHNpemVvZihzdHJ1Y3Qg Y3JhdF9zdWJ0eXBlX21lbW9yeSkpOwo+ICAKPiAgCS8qIEZpbGwgaW4gc3VidHlwZSBoZWFkZXIg ZGF0YSAqLwo+IEBAIC05MDUsMjcgKzkxNCwzNyBAQCBzdGF0aWMgaW50IGtmZF9maWxsX21lbV9p bmZvX2Zvcl9jcHUoaW50IG51bWFfbm9kZV9pZCwgaW50ICphdmFpbF9zaXplLAo+ICAKPiAgCXN1 Yl90eXBlX2hkci0+bGVuZ3RoX2xvdyA9IGxvd2VyXzMyX2JpdHMobWVtX2luX2J5dGVzKTsKPiAg CXN1Yl90eXBlX2hkci0+bGVuZ3RoX2hpZ2ggPSB1cHBlcl8zMl9iaXRzKG1lbV9pbl9ieXRlcyk7 Cj4gLQlzdWJfdHlwZV9oZHItPnByb3hpbWl0eV9kb21haW4gPSBwcm94aW1pdHlfZG9tYWluOwo+ ICsJc3ViX3R5cGVfaGRyLT5wcm94aW1pdHlfZG9tYWluID0gY3JhdF90YWJsZS0+bnVtX2RvbWFp bnM7Cj4gKwo+ICsJY3JhdF90YWJsZS0+bGVuZ3RoICs9IHN1Yl90eXBlX2hkci0+bGVuZ3RoOwo+ ICsJY3JhdF90YWJsZS0+dG90YWxfZW50cmllcysrOwo+ICAKPiAgCXJldHVybiAwOwo+ICB9Cj4g IAo+ICAjaWZkZWYgQ09ORklHX1g4Nl82NAo+ICsvKiBrZmRfZmlsbF9pb2xpbmtfaW5mb19mb3Jf Y3B1KCkgLSBBZGQgSU8gbGluayBpbmZvIHRvIGEgVmlydHVhbCBDUkFUCj4gKyAqCj4gKyAqIEBu dW1hX25vZGVfaWQ6IFRoZSBOVU1BIG5vZGUgSUQgZm9yIHRoZSBDUFU7IGFzIGZyb20gZm9yX2Vh Y2hfb25saW5lX25vZGUoKQo+ICsgKiBAYXZhaWxfc2l6ZTogQXZhaWxhYmxlIHNwYWNlIGluIGJ5 dGVzIGF0IHRoZSBlbmQgb2YgdGhlIEBjcmF0X3RhYmxlLgo+ICsgKiBAY3JhdF90YWJsZTogVGhl IENSQVQgdGFibGUgdG8gYXBwZW5kIHRoZSBJTyBsaW5rIGluZm8gdG87IG9uIHN1Y2Nlc3MgdGhl Cj4gKyAqICAgICAgICAgICAgICB0YWJsZSBsZW5ndGggYW5kIHRvdGFsX2VudHJpZXMgY291bnQg aXMgdXBkYXRlZC4KPiArICoKPiArICogUmV0dXJuOiAwIGlmIHN1Y2Nlc3NmdWwgZWxzZSByZXR1 cm4gLXZlIHZhbHVlCj4gKyAqLwo+ICBzdGF0aWMgaW50IGtmZF9maWxsX2lvbGlua19pbmZvX2Zv cl9jcHUoaW50IG51bWFfbm9kZV9pZCwgaW50ICphdmFpbF9zaXplLAo+IC0JCQkJdWludDMyX3Qg Km51bV9lbnRyaWVzLAo+IC0JCQkJc3RydWN0IGNyYXRfc3VidHlwZV9pb2xpbmsgKnN1Yl90eXBl X2hkcikKPiArCQkJCXN0cnVjdCBjcmF0X2hlYWRlciAqY3JhdF90YWJsZSkKPiAgewo+ICAJaW50 IG5pZDsKPiAgCXN0cnVjdCBjcHVpbmZvX3g4NiAqYyA9ICZjcHVfZGF0YSgwKTsKPiAgCXVpbnQ4 X3QgbGlua190eXBlOwo+ICsJc3RydWN0IGNyYXRfc3VidHlwZV9pb2xpbmsgKnN1Yl90eXBlX2hk cjsKPiAgCj4gIAlpZiAoYy0+eDg2X3ZlbmRvciA9PSBYODZfVkVORE9SX0FNRCkKPiAgCQlsaW5r X3R5cGUgPSBDUkFUX0lPTElOS19UWVBFX0hZUEVSVFJBTlNQT1JUOwo+ICAJZWxzZQo+ICAJCWxp bmtfdHlwZSA9IENSQVRfSU9MSU5LX1RZUEVfUVBJXzFfMTsKPiAgCj4gLQkqbnVtX2VudHJpZXMg PSAwOwo+IC0KPiAgCS8qIENyZWF0ZSBJTyBsaW5rcyBmcm9tIHRoaXMgbm9kZSB0byBvdGhlciBD UFUgbm9kZXMgKi8KPiAgCWZvcl9lYWNoX29ubGluZV9ub2RlKG5pZCkgewo+ICAJCWlmIChuaWQg PT0gbnVtYV9ub2RlX2lkKSAvKiBub2RlIGl0c2VsZiAqLwo+IEBAIC05MzUsNiArOTU0LDggQEAg c3RhdGljIGludCBrZmRfZmlsbF9pb2xpbmtfaW5mb19mb3JfY3B1KGludCBudW1hX25vZGVfaWQs IGludCAqYXZhaWxfc2l6ZSwKPiAgCQlpZiAoKmF2YWlsX3NpemUgPCAwKQo+ICAJCQlyZXR1cm4g LUVOT01FTTsKPiAgCj4gKwkJc3ViX3R5cGVfaGRyID0gKHR5cGVvZihzdWJfdHlwZV9oZHIpKSgo Y2hhciAqKWNyYXRfdGFibGUgKwo+ICsJCQljcmF0X3RhYmxlLT5sZW5ndGgpOwo+ICAJCW1lbXNl dChzdWJfdHlwZV9oZHIsIDAsIHNpemVvZihzdHJ1Y3QgY3JhdF9zdWJ0eXBlX2lvbGluaykpOwo+ ICAKPiAgCQkvKiBGaWxsIGluIHN1YnR5cGUgaGVhZGVyIGRhdGEgKi8KPiBAQCAtOTQ3LDggKzk2 OCw4IEBAIHN0YXRpYyBpbnQga2ZkX2ZpbGxfaW9saW5rX2luZm9fZm9yX2NwdShpbnQgbnVtYV9u b2RlX2lkLCBpbnQgKmF2YWlsX3NpemUsCj4gIAkJc3ViX3R5cGVfaGRyLT5wcm94aW1pdHlfZG9t YWluX3RvID0gbmlkOwo+ICAJCXN1Yl90eXBlX2hkci0+aW9faW50ZXJmYWNlX3R5cGUgPSBsaW5r X3R5cGU7Cj4gIAo+IC0JCSgqbnVtX2VudHJpZXMpKys7Cj4gLQkJc3ViX3R5cGVfaGRyKys7Cj4g KwkJY3JhdF90YWJsZS0+bGVuZ3RoICs9IHN1Yl90eXBlX2hkci0+bGVuZ3RoOwo+ICsJCWNyYXRf dGFibGUtPnRvdGFsX2VudHJpZXMrKzsKPiAgCX0KPiAgCj4gIAlyZXR1cm4gMDsKPiBAQCAtOTY2 LDEyICs5ODcsOCBAQCBzdGF0aWMgaW50IGtmZF9jcmVhdGVfdmNyYXRfaW1hZ2VfY3B1KHZvaWQg KnBjcmF0X2ltYWdlLCBzaXplX3QgKnNpemUpCj4gIAlzdHJ1Y3QgY3JhdF9oZWFkZXIgKmNyYXRf dGFibGUgPSAoc3RydWN0IGNyYXRfaGVhZGVyICopcGNyYXRfaW1hZ2U7Cj4gIAlzdHJ1Y3QgYWNw aV90YWJsZV9oZWFkZXIgKmFjcGlfdGFibGU7Cj4gIAlhY3BpX3N0YXR1cyBzdGF0dXM7Cj4gLQlz dHJ1Y3QgY3JhdF9zdWJ0eXBlX2dlbmVyaWMgKnN1Yl90eXBlX2hkcjsKPiAgCWludCBhdmFpbF9z aXplID0gKnNpemU7Cj4gIAlpbnQgbnVtYV9ub2RlX2lkOwo+IC0jaWZkZWYgQ09ORklHX1g4Nl82 NAo+IC0JdWludDMyX3QgZW50cmllcyA9IDA7Cj4gLSNlbmRpZgo+ICAJaW50IHJldCA9IDA7Cj4g IAo+ICAJaWYgKCFwY3JhdF9pbWFnZSkKPiBAQCAtMTAwMyw0OCArMTAyMCwyNSBAQCBzdGF0aWMg aW50IGtmZF9jcmVhdGVfdmNyYXRfaW1hZ2VfY3B1KHZvaWQgKnBjcmF0X2ltYWdlLCBzaXplX3Qg KnNpemUpCj4gIAljcmF0X3RhYmxlLT50b3RhbF9lbnRyaWVzID0gMDsKPiAgCWNyYXRfdGFibGUt Pm51bV9kb21haW5zID0gMDsKPiAgCj4gLQlzdWJfdHlwZV9oZHIgPSAoc3RydWN0IGNyYXRfc3Vi dHlwZV9nZW5lcmljICopKGNyYXRfdGFibGUrMSk7Cj4gLQo+ICAJZm9yX2VhY2hfb25saW5lX25v ZGUobnVtYV9ub2RlX2lkKSB7Cj4gIAkJaWYgKGtmZF9udW1hX25vZGVfdG9fYXBpY19pZChudW1h X25vZGVfaWQpID09IC0xKQo+ICAJCQljb250aW51ZTsKPiAgCj4gIAkJLyogRmlsbCBpbiBTdWJ0 eXBlOiBDb21wdXRlIFVuaXQgKi8KPiAtCQlyZXQgPSBrZmRfZmlsbF9jdV9mb3JfY3B1KG51bWFf bm9kZV9pZCwgJmF2YWlsX3NpemUsCj4gLQkJCWNyYXRfdGFibGUtPm51bV9kb21haW5zLAo+IC0J CQkoc3RydWN0IGNyYXRfc3VidHlwZV9jb21wdXRldW5pdCAqKXN1Yl90eXBlX2hkcik7Cj4gKwkJ cmV0ID0ga2ZkX2ZpbGxfY3VfZm9yX2NwdShudW1hX25vZGVfaWQsICZhdmFpbF9zaXplLCBjcmF0 X3RhYmxlKTsKPiAgCQlpZiAocmV0IDwgMCkKPiAgCQkJcmV0dXJuIHJldDsKPiAtCQljcmF0X3Rh YmxlLT5sZW5ndGggKz0gc3ViX3R5cGVfaGRyLT5sZW5ndGg7Cj4gLQkJY3JhdF90YWJsZS0+dG90 YWxfZW50cmllcysrOwo+IC0KPiAtCQlzdWJfdHlwZV9oZHIgPSAodHlwZW9mKHN1Yl90eXBlX2hk cikpKChjaGFyICopc3ViX3R5cGVfaGRyICsKPiAtCQkJc3ViX3R5cGVfaGRyLT5sZW5ndGgpOwo+ ICAKPiAgCQkvKiBGaWxsIGluIFN1YnR5cGU6IE1lbW9yeSAqLwo+IC0JCXJldCA9IGtmZF9maWxs X21lbV9pbmZvX2Zvcl9jcHUobnVtYV9ub2RlX2lkLCAmYXZhaWxfc2l6ZSwKPiAtCQkJY3JhdF90 YWJsZS0+bnVtX2RvbWFpbnMsCj4gLQkJCShzdHJ1Y3QgY3JhdF9zdWJ0eXBlX21lbW9yeSAqKXN1 Yl90eXBlX2hkcik7Cj4gKwkJcmV0ID0ga2ZkX2ZpbGxfbWVtX2luZm9fZm9yX2NwdShudW1hX25v ZGVfaWQsICZhdmFpbF9zaXplLCBjcmF0X3RhYmxlKTsKPiAgCQlpZiAocmV0IDwgMCkKPiAgCQkJ cmV0dXJuIHJldDsKPiAtCQljcmF0X3RhYmxlLT5sZW5ndGggKz0gc3ViX3R5cGVfaGRyLT5sZW5n dGg7Cj4gLQkJY3JhdF90YWJsZS0+dG90YWxfZW50cmllcysrOwo+IC0KPiAtCQlzdWJfdHlwZV9o ZHIgPSAodHlwZW9mKHN1Yl90eXBlX2hkcikpKChjaGFyICopc3ViX3R5cGVfaGRyICsKPiAtCQkJ c3ViX3R5cGVfaGRyLT5sZW5ndGgpOwo+ICAKPiAgCQkvKiBGaWxsIGluIFN1YnR5cGU6IElPIExp bmsgKi8KPiAgI2lmZGVmIENPTkZJR19YODZfNjQKPiAtCQlyZXQgPSBrZmRfZmlsbF9pb2xpbmtf aW5mb19mb3JfY3B1KG51bWFfbm9kZV9pZCwgJmF2YWlsX3NpemUsCj4gLQkJCQkmZW50cmllcywK PiAtCQkJCShzdHJ1Y3QgY3JhdF9zdWJ0eXBlX2lvbGluayAqKXN1Yl90eXBlX2hkcik7Cj4gKwkJ cmV0ID0ga2ZkX2ZpbGxfaW9saW5rX2luZm9fZm9yX2NwdShudW1hX25vZGVfaWQsICZhdmFpbF9z aXplLCBjcmF0X3RhYmxlKTsKPiAgCQlpZiAocmV0IDwgMCkKPiAgCQkJcmV0dXJuIHJldDsKPiAt CQljcmF0X3RhYmxlLT5sZW5ndGggKz0gKHN1Yl90eXBlX2hkci0+bGVuZ3RoICogZW50cmllcyk7 Cj4gLQkJY3JhdF90YWJsZS0+dG90YWxfZW50cmllcyArPSBlbnRyaWVzOwo+IC0KPiAtCQlzdWJf dHlwZV9oZHIgPSAodHlwZW9mKHN1Yl90eXBlX2hkcikpKChjaGFyICopc3ViX3R5cGVfaGRyICsK PiAtCQkJCXN1Yl90eXBlX2hkci0+bGVuZ3RoICogZW50cmllcyk7Cj4gICNlbHNlCj4gIAkJcHJf aW5mbygiSU8gbGluayBub3QgYXZhaWxhYmxlIGZvciBub24geDg2IHBsYXRmb3Jtc1xuIik7Cj4g ICNlbmRpZgpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpk cmktZGV2ZWwgbWFpbGluZyBsaXN0CmRyaS1kZXZlbEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0 cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9kcmktZGV2ZWwK From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-17.5 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,MSGID_FROM_MTA_HEADER,NICE_REPLY_A, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 01797C433DB for ; Fri, 8 Jan 2021 23:47:30 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id BB01023A74 for ; Fri, 8 Jan 2021 23:47:29 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726264AbhAHXrQ (ORCPT ); Fri, 8 Jan 2021 18:47:16 -0500 Received: from mail-dm6nam11on2061.outbound.protection.outlook.com ([40.107.223.61]:8928 "EHLO NAM11-DM6-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1725836AbhAHXrP (ORCPT ); Fri, 8 Jan 2021 18:47:15 -0500 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=jkS6vHFBJ91/h/UyxSUx7nU2fJ/LSm/CC8wI2NK+1gpudur2+fmBUzu6H65ZoqodF/dDp+Allzdq9G44osm6q2kwc/Sq6//n7kgZuhk2xuuJZgPxtu5McA3WHZWi+LFeuqoVD+rDn8MaNrqb/kUsMWNpAJdOX2zs4wcOyik7qA5Pdea7FZo10tI9lHfo/MgkqPd6m9cp2Vxzxp9fLCyoICteFo7szQsjkUN3U/fPIr395LDvcviu+yIcKIr+JaL8xoIK8bkR/tTgngpO/cHh88j8yG5r8hnO13MmjgpV1iQXQZw75/J3KddG2Wv5rY5JCg+E86emZ0O1dbZ+9eslug== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=r1zsCMm2IZu7bnrKiFRXZRbBuhc/w6WvrT6pl6zKQeA=; b=Erhd/dU+2ibaENvAXTr7EBm1p4Da/bJSoKI4+x9D1NiQeeTkCij6FFFA+EEkxhEB4HY7APO47LzjKzYzgQZHl8+Jf8iKHxsNiFbc7Mp2mWzuhWLsmsyV3i8413pJ+xuKIZxfEEU9uHiBBiPfj1SaJbt7nN9FUvqLU0NPk7PBp4WHKzx+XGLp5pnZGwSJODLa6aEFj2JSBhSUZnjMNk7DBjmVpyv4PiS9/yCeUSdUmtmaMlBj0RHl2oGPecyeRkRUZEbSi8+3RekTfN3/di2FaJjG2GB8eHfeLITkE1VeYG/ErtemNIfFoKBgZ1R5WSwD4t7dZoLtWsi1vBKVOJFJtA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=r1zsCMm2IZu7bnrKiFRXZRbBuhc/w6WvrT6pl6zKQeA=; b=PUGO06Kjbs7U4SzOZBmQjMczXAVD820QjjxjeEOQGUViDYz2ePX0rzTGK9YWFhBAqpx4MGf5z+pbfGjp3yyJ3rXYxyLfpX6ywWuWIzx4f8obfMpIRnE6ngK16yKVfOMgh2gS7qzRtBHniE/Q2dFtF6EkLNkStKwqaZbNkQl8yRQ= Authentication-Results: vger.kernel.org; dkim=none (message not signed) header.d=none;vger.kernel.org; dmarc=none action=none header.from=amd.com; Received: from BL0PR12MB4948.namprd12.prod.outlook.com (2603:10b6:208:1cc::20) by MN2PR12MB4520.namprd12.prod.outlook.com (2603:10b6:208:26f::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3742.6; Fri, 8 Jan 2021 23:46:19 +0000 Received: from BL0PR12MB4948.namprd12.prod.outlook.com ([fe80::9425:559:83c0:991b]) by BL0PR12MB4948.namprd12.prod.outlook.com ([fe80::9425:559:83c0:991b%9]) with mapi id 15.20.3742.011; Fri, 8 Jan 2021 23:46:19 +0000 Subject: Re: [PATCH] drm/amdkfd: Fix out-of-bounds read in kdf_create_vcrat_image_cpu() To: Jeremy Cline , Alex Deucher , =?UTF-8?Q?Christian_K=c3=b6nig?= Cc: David Airlie , Daniel Vetter , Kent Russell , amd-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org References: <20210108163104.411442-1-jcline@redhat.com> From: Felix Kuehling Message-ID: Date: Fri, 8 Jan 2021 18:46:17 -0500 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 In-Reply-To: <20210108163104.411442-1-jcline@redhat.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Content-Language: en-US X-Originating-IP: [142.117.121.176] X-ClientProxiedBy: YTXPR0101CA0031.CANPRD01.PROD.OUTLOOK.COM (2603:10b6:b00::44) To BL0PR12MB4948.namprd12.prod.outlook.com (2603:10b6:208:1cc::20) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 Received: from [192.168.2.100] (142.117.121.176) by YTXPR0101CA0031.CANPRD01.PROD.OUTLOOK.COM (2603:10b6:b00::44) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3742.6 via Frontend Transport; Fri, 8 Jan 2021 23:46:18 +0000 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-HT: Tenant X-MS-Office365-Filtering-Correlation-Id: d0feffba-3fcf-4c91-cda3-08d8b42f98f3 X-MS-TrafficTypeDiagnostic: MN2PR12MB4520: X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:10000; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: Yik+0npIL5H+dEAxyhxnyMl7HxOj+26+OM9NmEGq/gCFnoEFursP3YIjxVSc+12G1XN8AWOZsj1frtfQ3rD4D6qNhxxwZu8S/T0HgCXuL2x1SvXocDfLEGYYtVqrbZvdNnj1MPtNVEK3n8OtHvBhEgG7uBiBypwRatGxkCV0Jh57aGaAcCoQv6EB+fnfkmkTJNleN/97IfATfHtFp3FFbFxaRK49seMuSAWpr1+gEOHjNrKkPMYwdkRUkmJ1QDNv1/UH/8hn0sdnL/reDYnB/6+1rpik1ITNVM5bMXOoNyT0brM6YY0K8G+tk+nC5Ld11UGVLdY33Kx5WjajhAf8SfopGBlPmSB0XmMEg4kNyatITuin8eTmXWQe4rcLiZD+cnQh1irFr72Kp8dP19YC8jaNRAHaThMmLDli8Vy7TK8VawQteziP2p9d9t3B4xxeDYotfv06Omlx2DkYTaBkMoEXm4ukbbDZDki3Y/QZZG0= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BL0PR12MB4948.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(39860400002)(366004)(136003)(346002)(376002)(396003)(86362001)(186003)(16526019)(2616005)(66556008)(5660300002)(2906002)(31686004)(26005)(956004)(44832011)(31696002)(83380400001)(478600001)(66476007)(316002)(54906003)(52116002)(8676002)(110136005)(6486002)(8936002)(4326008)(66946007)(16576012)(36756003)(6636002)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData: =?utf-8?B?VHZwNUFucXIwRXFyWmJLd3I4YkdjenYzOS9LQmN5aHdrN0Ywa3B1c2VncEt3?= =?utf-8?B?UEwxdHphQmZtSmVGTGhDdGprQlJrcFVNdjlXMTE4a1liQjIveDZXWi84L3ZJ?= =?utf-8?B?ckROTyt3M0w4WWwzUHUvZ08yWk9BV2RDSHlIT3h1NEFWUTBEdzVPMjdIVmk3?= =?utf-8?B?ZTUrUStmS1hyVEE0UDhtVVN1R0J3RmZxWFlFUUZ1VVBUeUZjcVI0MlBpMHVs?= =?utf-8?B?K09LZ25CbnNvOEI0VUE5RElmcFRBT2EzSUthZkVlWmxsZkNjUWdkWlc4YitO?= =?utf-8?B?dVRkaXZObHBGTkltZDhoOGpnV2VFa0hFZEtuQWd5TDlHQzVmSXpPeEpaOWM4?= =?utf-8?B?MWVQMkNSblZOcUVodm9pUHF2RWI4clFoU3VyQVh0a0ZUc3p4UUdFdXVuWFJh?= =?utf-8?B?QWZFS1hFVTZtOUozbDVBdG92UmduWGcxUjQ2cEtNMWJwMWxXYklnV3IrSHgx?= =?utf-8?B?eHZPd2tBT1lpK3p4NloxNGZ3RjI1a1RjcXphQTcrcEk4UzNwa2RvelIvMWZt?= =?utf-8?B?RjZ1THQwU0oxdEVqODBwa2J1THM1TVZuZk9lWXFyblRlOUpwY0l2YitxL0dx?= =?utf-8?B?RHlqemdvbXN2K2h5RHcxd3orUGRnYU4yTVQ0b3E0cWhqSnVVN3BBYVhMNHg0?= =?utf-8?B?ZXpQREloZ0ZjQlN4bE5GdWh3NUJ4L2ZlM0hudGFhWms4c3NRbHpYODNHUTZP?= =?utf-8?B?SVhzY1NkM3BWOHB2bjZVVFdmaTlSMWVjbDVROFc4aVJxeUZyL3lDaUFlMXEw?= =?utf-8?B?Qk1BU1YzMnd0OEFwTHAxZC9wZ3Jna1h3UWV3MVVHSUh4NndydWZtUUIwc1Yw?= =?utf-8?B?NDl5UlY3VXpmMGtPampCMGFsNWd1SStjSTVTdXh6MzU2YWNmOWR1TG5BdHNv?= =?utf-8?B?d0xGM3AvOGhtb3BxRnZUTmJjYzl6dWNKeURNekRwSHlsOWxXMmkvMHdmbERa?= =?utf-8?B?M3RGaStXMzAxOGpEV1BOTzliQ1V1N3ZrQXY0dlhlR0hqdEJsV0U2cFFTeEZX?= =?utf-8?B?SnFpOUZ5cXRNQzh4S0tBYXFHV3lQSTJMeW03WHFvak9BRUVJYzF3MG9sZWhy?= =?utf-8?B?TzA2MWEzNmE2bjZmd1pzQ3pmNzVQVC9GY2V3Mk9zdDBtWTJsdmJEbm11RW5D?= =?utf-8?B?SGxvRlk0QUlKV1JvSU5NSWQvWHZKNU91YXZYQy9PUEk3TS9hM3dLUmExVWhC?= =?utf-8?B?ZVdYL2RJUWxMdTZsamZCMFlVZms1cVdZVWZIYTAyRFZZQVp4djlrV1FHZ2VJ?= =?utf-8?B?cDNFejNXY3BzU283NFNwQjhtN0Qxc292RG5GRlRjZVIyNVRlV1B0VGMrRnBU?= =?utf-8?Q?uTRt3MfZo5hRn05wGCsXqmhp3qEGizEx5J?= X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-AuthSource: BL0PR12MB4948.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 Jan 2021 23:46:19.4666 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-Network-Message-Id: d0feffba-3fcf-4c91-cda3-08d8b42f98f3 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: xZFVMwbBXKnV7qbwpef04r5qWcbH5KyEfYwlspmROyEv9XtGBhsHGtKQS6i8tNFLwwu7j0whna+9a9c7M3/VMw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR12MB4520 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Am 2021-01-08 um 11:31 a.m. schrieb Jeremy Cline: > KASAN reported a slab-out-of-bounds read of size 1 in > kdf_create_vcrat_image_cpu(). > > This occurs when, for example, when on an x86_64 with a single NUMA node > because kfd_fill_iolink_info_for_cpu() is a no-op, but afterwards the > sub_type_hdr->length, which is out-of-bounds, is read and multiplied by > entries. Fortunately, entries is 0 in this case so the overall > crat_table->length is still correct. That's a pretty big change to fix that. Wouldn't it be enough to add a simple check after calling kfd_fill_iolink_info_for_cpu: if (entries) { crat_table->length += (sub_type_hdr->length * entries); crat_table->total_entries += entries; } Or change the output parameters of the kfd_fill_..._for_cpu functions from num_entries to size_filled, so the caller doesn't need to read sub_type_hdr->length any more. Regards,   Felix > > This refactors the helper functions to accept the crat_table directly > and calculate the table entry pointer based on the current table length. > This allows us to avoid an out-of-bounds read and hopefully makes the > pointer arithmetic clearer. It should have no functional change beyond > removing the out-of-bounds read. > > Fixes: b7b6c38529c9 ("drm/amdkfd: Calculate CPU VCRAT size dynamically (v2)") > Signed-off-by: Jeremy Cline > --- > drivers/gpu/drm/amd/amdkfd/kfd_crat.c | 86 +++++++++++++-------------- > 1 file changed, 40 insertions(+), 46 deletions(-) > > diff --git a/drivers/gpu/drm/amd/amdkfd/kfd_crat.c b/drivers/gpu/drm/amd/amdkfd/kfd_crat.c > index 8cac497c2c45..e50db2c0f4ee 100644 > --- a/drivers/gpu/drm/amd/amdkfd/kfd_crat.c > +++ b/drivers/gpu/drm/amd/amdkfd/kfd_crat.c > @@ -829,21 +829,24 @@ int kfd_create_crat_image_acpi(void **crat_image, size_t *size) > /* kfd_fill_cu_for_cpu - Fill in Compute info for the given CPU NUMA node > * > * @numa_node_id: CPU NUMA node id > - * @avail_size: Available size in the memory > - * @sub_type_hdr: Memory into which compute info will be filled in > + * @avail_size: Available space in bytes at the end of the @crat_table. > + * @crat_table: The CRAT table to append the Compute info to; > + * on success the table length and total_entries count is updated. > * > * Return 0 if successful else return -ve value > */ > static int kfd_fill_cu_for_cpu(int numa_node_id, int *avail_size, > - int proximity_domain, > - struct crat_subtype_computeunit *sub_type_hdr) > + struct crat_header *crat_table) > { > const struct cpumask *cpumask; > + struct crat_subtype_computeunit *sub_type_hdr; > > *avail_size -= sizeof(struct crat_subtype_computeunit); > if (*avail_size < 0) > return -ENOMEM; > > + sub_type_hdr = (typeof(sub_type_hdr))((char *)crat_table + > + crat_table->length); > memset(sub_type_hdr, 0, sizeof(struct crat_subtype_computeunit)); > > /* Fill in subtype header data */ > @@ -855,36 +858,42 @@ static int kfd_fill_cu_for_cpu(int numa_node_id, int *avail_size, > > /* Fill in CU data */ > sub_type_hdr->flags |= CRAT_CU_FLAGS_CPU_PRESENT; > - sub_type_hdr->proximity_domain = proximity_domain; > + sub_type_hdr->proximity_domain = crat_table->num_domains; > sub_type_hdr->processor_id_low = kfd_numa_node_to_apic_id(numa_node_id); > if (sub_type_hdr->processor_id_low == -1) > return -EINVAL; > > sub_type_hdr->num_cpu_cores = cpumask_weight(cpumask); > > + crat_table->length += sub_type_hdr->length; > + crat_table->total_entries++; > + > return 0; > } > > /* kfd_fill_mem_info_for_cpu - Fill in Memory info for the given CPU NUMA node > * > * @numa_node_id: CPU NUMA node id > - * @avail_size: Available size in the memory > - * @sub_type_hdr: Memory into which compute info will be filled in > + * @avail_size: Available space in bytes at the end of the @crat_table. > + * @crat_table: The CRAT table to append the Memory info to; > + * on success the table length and total_entries count is updated. > * > * Return 0 if successful else return -ve value > */ > static int kfd_fill_mem_info_for_cpu(int numa_node_id, int *avail_size, > - int proximity_domain, > - struct crat_subtype_memory *sub_type_hdr) > + struct crat_header *crat_table) > { > uint64_t mem_in_bytes = 0; > pg_data_t *pgdat; > int zone_type; > + struct crat_subtype_memory *sub_type_hdr; > > *avail_size -= sizeof(struct crat_subtype_memory); > if (*avail_size < 0) > return -ENOMEM; > > + sub_type_hdr = (typeof(sub_type_hdr))((char *)crat_table + > + crat_table->length); > memset(sub_type_hdr, 0, sizeof(struct crat_subtype_memory)); > > /* Fill in subtype header data */ > @@ -905,27 +914,37 @@ static int kfd_fill_mem_info_for_cpu(int numa_node_id, int *avail_size, > > sub_type_hdr->length_low = lower_32_bits(mem_in_bytes); > sub_type_hdr->length_high = upper_32_bits(mem_in_bytes); > - sub_type_hdr->proximity_domain = proximity_domain; > + sub_type_hdr->proximity_domain = crat_table->num_domains; > + > + crat_table->length += sub_type_hdr->length; > + crat_table->total_entries++; > > return 0; > } > > #ifdef CONFIG_X86_64 > +/* kfd_fill_iolink_info_for_cpu() - Add IO link info to a Virtual CRAT > + * > + * @numa_node_id: The NUMA node ID for the CPU; as from for_each_online_node() > + * @avail_size: Available space in bytes at the end of the @crat_table. > + * @crat_table: The CRAT table to append the IO link info to; on success the > + * table length and total_entries count is updated. > + * > + * Return: 0 if successful else return -ve value > + */ > static int kfd_fill_iolink_info_for_cpu(int numa_node_id, int *avail_size, > - uint32_t *num_entries, > - struct crat_subtype_iolink *sub_type_hdr) > + struct crat_header *crat_table) > { > int nid; > struct cpuinfo_x86 *c = &cpu_data(0); > uint8_t link_type; > + struct crat_subtype_iolink *sub_type_hdr; > > if (c->x86_vendor == X86_VENDOR_AMD) > link_type = CRAT_IOLINK_TYPE_HYPERTRANSPORT; > else > link_type = CRAT_IOLINK_TYPE_QPI_1_1; > > - *num_entries = 0; > - > /* Create IO links from this node to other CPU nodes */ > for_each_online_node(nid) { > if (nid == numa_node_id) /* node itself */ > @@ -935,6 +954,8 @@ static int kfd_fill_iolink_info_for_cpu(int numa_node_id, int *avail_size, > if (*avail_size < 0) > return -ENOMEM; > > + sub_type_hdr = (typeof(sub_type_hdr))((char *)crat_table + > + crat_table->length); > memset(sub_type_hdr, 0, sizeof(struct crat_subtype_iolink)); > > /* Fill in subtype header data */ > @@ -947,8 +968,8 @@ static int kfd_fill_iolink_info_for_cpu(int numa_node_id, int *avail_size, > sub_type_hdr->proximity_domain_to = nid; > sub_type_hdr->io_interface_type = link_type; > > - (*num_entries)++; > - sub_type_hdr++; > + crat_table->length += sub_type_hdr->length; > + crat_table->total_entries++; > } > > return 0; > @@ -966,12 +987,8 @@ static int kfd_create_vcrat_image_cpu(void *pcrat_image, size_t *size) > struct crat_header *crat_table = (struct crat_header *)pcrat_image; > struct acpi_table_header *acpi_table; > acpi_status status; > - struct crat_subtype_generic *sub_type_hdr; > int avail_size = *size; > int numa_node_id; > -#ifdef CONFIG_X86_64 > - uint32_t entries = 0; > -#endif > int ret = 0; > > if (!pcrat_image) > @@ -1003,48 +1020,25 @@ static int kfd_create_vcrat_image_cpu(void *pcrat_image, size_t *size) > crat_table->total_entries = 0; > crat_table->num_domains = 0; > > - sub_type_hdr = (struct crat_subtype_generic *)(crat_table+1); > - > for_each_online_node(numa_node_id) { > if (kfd_numa_node_to_apic_id(numa_node_id) == -1) > continue; > > /* Fill in Subtype: Compute Unit */ > - ret = kfd_fill_cu_for_cpu(numa_node_id, &avail_size, > - crat_table->num_domains, > - (struct crat_subtype_computeunit *)sub_type_hdr); > + ret = kfd_fill_cu_for_cpu(numa_node_id, &avail_size, crat_table); > if (ret < 0) > return ret; > - crat_table->length += sub_type_hdr->length; > - crat_table->total_entries++; > - > - sub_type_hdr = (typeof(sub_type_hdr))((char *)sub_type_hdr + > - sub_type_hdr->length); > > /* Fill in Subtype: Memory */ > - ret = kfd_fill_mem_info_for_cpu(numa_node_id, &avail_size, > - crat_table->num_domains, > - (struct crat_subtype_memory *)sub_type_hdr); > + ret = kfd_fill_mem_info_for_cpu(numa_node_id, &avail_size, crat_table); > if (ret < 0) > return ret; > - crat_table->length += sub_type_hdr->length; > - crat_table->total_entries++; > - > - sub_type_hdr = (typeof(sub_type_hdr))((char *)sub_type_hdr + > - sub_type_hdr->length); > > /* Fill in Subtype: IO Link */ > #ifdef CONFIG_X86_64 > - ret = kfd_fill_iolink_info_for_cpu(numa_node_id, &avail_size, > - &entries, > - (struct crat_subtype_iolink *)sub_type_hdr); > + ret = kfd_fill_iolink_info_for_cpu(numa_node_id, &avail_size, crat_table); > if (ret < 0) > return ret; > - crat_table->length += (sub_type_hdr->length * entries); > - crat_table->total_entries += entries; > - > - sub_type_hdr = (typeof(sub_type_hdr))((char *)sub_type_hdr + > - sub_type_hdr->length * entries); > #else > pr_info("IO link not available for non x86 platforms\n"); > #endif