From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id B3F5CC19F2C for ; Tue, 2 Aug 2022 12:55:00 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236723AbiHBMy6 (ORCPT ); Tue, 2 Aug 2022 08:54:58 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39066 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236248AbiHBMyy (ORCPT ); Tue, 2 Aug 2022 08:54:54 -0400 Received: from mailout-taastrup.gigahost.dk (mailout-taastrup.gigahost.dk [46.183.139.199]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E668214D0A; Tue, 2 Aug 2022 05:54:52 -0700 (PDT) Received: from mailout.gigahost.dk (mailout.gigahost.dk [89.186.169.112]) by mailout-taastrup.gigahost.dk (Postfix) with ESMTP id 9B01318857C4; Tue, 2 Aug 2022 12:54:50 +0000 (UTC) Received: from smtp.gigahost.dk (smtp.gigahost.dk [89.186.169.109]) by mailout.gigahost.dk (Postfix) with ESMTP id 9324925032B7; Tue, 2 Aug 2022 12:54:50 +0000 (UTC) Received: by smtp.gigahost.dk (Postfix, from userid 1000) id 8A8CEA1E00BE; Tue, 2 Aug 2022 12:54:50 +0000 (UTC) X-Screener-Id: 413d8c6ce5bf6eab4824d0abaab02863e8e3f662 MIME-Version: 1.0 Date: Tue, 02 Aug 2022 14:54:50 +0200 From: netdev@kapio-technology.com To: Vladimir Oltean Cc: Ido Schimmel , davem@davemloft.net, kuba@kernel.org, netdev@vger.kernel.org, Andrew Lunn , Vivien Didelot , Florian Fainelli , Eric Dumazet , Paolo Abeni , Jiri Pirko , Ivan Vecera , Roopa Prabhu , Nikolay Aleksandrov , Shuah Khan , Daniel Borkmann , linux-kernel@vger.kernel.org, bridge@lists.linux-foundation.org, linux-kselftest@vger.kernel.org Subject: Re: [PATCH v4 net-next 3/6] drivers: net: dsa: add locked fdb entry flag to drivers In-Reply-To: <20220721115935.5ctsbtoojtoxxubi@skbuf> References: <20220708091550.2qcu3tyqkhgiudjg@skbuf> <20220708115624.rrjzjtidlhcqczjv@skbuf> <723e2995314b41ff323272536ef27341@kapio-technology.com> <648ba6718813bf76e7b973150b73f028@kapio-technology.com> <4500e01ec4e2f34a8bbb58ac9b657a40@kapio-technology.com> <20220721115935.5ctsbtoojtoxxubi@skbuf> User-Agent: Gigahost Webmail Message-ID: X-Sender: netdev@kapio-technology.com Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2022-07-21 13:59, Vladimir Oltean wrote: > On Sun, Jul 17, 2022 at 05:53:22PM +0200, netdev@kapio-technology.com > wrote: >> > 3. What happens to packets with a DA matching the zero-DPV entry, are >> > they also discarded in hardware? If so, here we differ from the bridge >> > driver implementation where such packets will be forwarded according to >> > the locked entry and egress the locked port >> >> I understand that egress will follow what is setup with regard to UC, >> MC and >> BC, though I haven't tested that. But no replies will get through of >> course >> as long as the port hasn't been opened for the iface behind the locked >> port. > > Here, should we be rather fixing the software bridge, if the current > behavior is to forward packets towards locked FDB entries? Yes, I think that locked entries should block egress to the respective hosts behind the locked port, which should be fixed in the bridge. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: DKIM-Filter: OpenDKIM Filter v2.11.0 smtp1.osuosl.org 3AA828136A DKIM-Filter: OpenDKIM Filter v2.11.0 smtp1.osuosl.org 0232B81366 MIME-Version: 1.0 Date: Tue, 02 Aug 2022 14:54:50 +0200 From: netdev@kapio-technology.com In-Reply-To: <20220721115935.5ctsbtoojtoxxubi@skbuf> References: <20220708091550.2qcu3tyqkhgiudjg@skbuf> <20220708115624.rrjzjtidlhcqczjv@skbuf> <723e2995314b41ff323272536ef27341@kapio-technology.com> <648ba6718813bf76e7b973150b73f028@kapio-technology.com> <4500e01ec4e2f34a8bbb58ac9b657a40@kapio-technology.com> <20220721115935.5ctsbtoojtoxxubi@skbuf> Message-ID: Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Bridge] [PATCH v4 net-next 3/6] drivers: net: dsa: add locked fdb entry flag to drivers List-Id: Linux Ethernet Bridging List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Vladimir Oltean Cc: Ivan Vecera , Andrew Lunn , Florian Fainelli , Jiri Pirko , Daniel Borkmann , bridge@lists.linux-foundation.org, Ido Schimmel , Nikolay Aleksandrov , Roopa Prabhu , linux-kernel@vger.kernel.org, Vivien Didelot , Eric Dumazet , linux-kselftest@vger.kernel.org, netdev@vger.kernel.org, kuba@kernel.org, Paolo Abeni , Shuah Khan , davem@davemloft.net On 2022-07-21 13:59, Vladimir Oltean wrote: > On Sun, Jul 17, 2022 at 05:53:22PM +0200, netdev@kapio-technology.com > wrote: >> > 3. What happens to packets with a DA matching the zero-DPV entry, are >> > they also discarded in hardware? If so, here we differ from the bridge >> > driver implementation where such packets will be forwarded according to >> > the locked entry and egress the locked port >> >> I understand that egress will follow what is setup with regard to UC, >> MC and >> BC, though I haven't tested that. But no replies will get through of >> course >> as long as the port hasn't been opened for the iface behind the locked >> port. > > Here, should we be rather fixing the software bridge, if the current > behavior is to forward packets towards locked FDB entries? Yes, I think that locked entries should block egress to the respective hosts behind the locked port, which should be fixed in the bridge.