From: Alan Young <consult.awy@gmail.com>
To: Greg KH <gregkh@linuxfoundation.org>
Cc: stable@vger.kernel.org, tiwai@suse.de
Subject: Re: FAILED: patch "[PATCH] ALSA: pcm: Call substream ack() method upon compat mmap" failed to apply to 5.4-stable tree
Date: Fri, 30 Jul 2021 12:15:14 +0100 [thread overview]
Message-ID: <acb7f13d-a7bf-8820-363c-98798faa7a09@gmail.com> (raw)
In-Reply-To: <YQPFqOmmJCJM9Ref@kroah.com>
On 30/07/2021 10:26, Greg KH wrote:
> On Fri, Jul 30, 2021 at 09:38:52AM +0100, Alan Young wrote:
>> This commit is not applicable before the 64-bit time_t in user space with
>> 32-bit compatibility changes introduces by
>> 80fe7430c7085951d1246d83f638cc17e6c0be36 in 5.6.
> That is odd, as that is not what you wrote in the patch itself:
>
>> Fixes: 9027c4639ef1 ("ALSA: pcm: Call ack() whenever appl_ptr is updated")
> So is the Fixes: tag here incorrect?
>
> thanks,
>
> greg k-h
I did not add the Fixes tag. I guess Takashi Iwai did.
I think that 9027c4639ef1 added some functionality that was broken by
80fe7430c7085951 and which my patch corrects. So the Fixes: 9027c4639ef1
tag refers to the actual functionality, not the breaking of it.
I have no idea if that is the correct usage of the Fixes tag which, as I
said, I did not add.
Alan.
next prev parent reply other threads:[~2021-07-30 11:15 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-26 8:09 FAILED: patch "[PATCH] ALSA: pcm: Call substream ack() method upon compat mmap" failed to apply to 5.4-stable tree gregkh
[not found] ` <e26c27fb-12e8-f1c1-0dde-50fd68623118@gmail.com>
2021-07-30 9:26 ` Greg KH
2021-07-30 11:15 ` Alan Young [this message]
2021-07-30 18:12 ` Takashi Iwai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=acb7f13d-a7bf-8820-363c-98798faa7a09@gmail.com \
--to=consult.awy@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=stable@vger.kernel.org \
--cc=tiwai@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.