From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.3 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BE107C433E0 for ; Mon, 11 Jan 2021 15:49:22 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 651E7224D2 for ; Mon, 11 Jan 2021 15:49:22 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729362AbhAKPtV (ORCPT ); Mon, 11 Jan 2021 10:49:21 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54712 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727089AbhAKPtU (ORCPT ); Mon, 11 Jan 2021 10:49:20 -0500 Received: from mail-qv1-xf2d.google.com (mail-qv1-xf2d.google.com [IPv6:2607:f8b0:4864:20::f2d]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 464A6C061786 for ; Mon, 11 Jan 2021 07:48:40 -0800 (PST) Received: by mail-qv1-xf2d.google.com with SMTP id h13so1912544qvo.1 for ; Mon, 11 Jan 2021 07:48:40 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=toxicpanda-com.20150623.gappssmtp.com; s=20150623; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=9ln6bz3yyd1W5+sBe1fRyhA6q3eWpQ1fyqVKWkHkeXI=; b=eNU+2aI4/iuXRY7vZWYfRR0CPwaIrW5wQF7NDgwxbO+S0eoYSOGqjRlPrxuHxx7Keu 2kpq/a/47hCnP4T7Dpie7E42Z5D3XhESPN1/6e29Z3z8C+QtzTWbX8aiiI4QJyfDOdz+ DefdZHOzjrP+6oaBFMNfctCQ/xAok+ANAChdY2XnO4NIxToLxOrOVuZsUa8iqXPrZiaM Odp/uonVVMx0qGdUPP/UgaTL5QuBUK8FOQsgUsSXFzruqBWfrAKaD5LovEE689l6TRS4 M6HRMM1PxoG70eDI0O5Nd21GhhNgqdNLsDicnH4FuXIV2pg0e/w/hhwDIPkXID3WcaSA q5wA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=9ln6bz3yyd1W5+sBe1fRyhA6q3eWpQ1fyqVKWkHkeXI=; b=dR+9LZxVdRjKJDy47vgrICDn3vAGkpuPj8bZjLKQUrO034Njzg4G0dO9fbyR6bpv+x /hQQnw22ycn8RvvU6XLNFKfzg/BVaxwiHBaWtrWdoADWWeze2gPaZgkJkE9AM6dlJpd9 uBusdLTBcI4Cgus2mcAxmAHBTsHrLKtrshKX++luIKqqGVwkx8r47P/EBgQGX/8uAALb k2OX3zePk6gs8uHBsrpg3BvtY37q9U6wbTphxBVA5vpVISfU0vJYVz9ZS81js10N2vjY 4lKWr0cI4IwDKPveEH4XyzAH2MCTXzwCUepZWnxNW9MPWSHP2RVLhElG5DtWySgLgI0A msmA== X-Gm-Message-State: AOAM532lqhYhmWIqsdJCHgW3vnBjYvLDkpDD7W5Vuo1h5Ppz6RmirFNA E6j3NX6e+OmvQVfSSTagGBDupO0mQ7ulBc/I X-Google-Smtp-Source: ABdhPJyuhu5ZPw8yi1s/evXfmjNXN99HU/zI2gp8JHUMQQ3K/UStoLxMf+mfxosg5kTHEDJ67AgEag== X-Received: by 2002:a0c:9e5e:: with SMTP id z30mr252307qve.56.1610380118402; Mon, 11 Jan 2021 07:48:38 -0800 (PST) Received: from [192.168.1.45] (cpe-174-109-172-136.nc.res.rr.com. [174.109.172.136]) by smtp.gmail.com with ESMTPSA id u4sm7868403qtv.49.2021.01.11.07.48.37 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 11 Jan 2021 07:48:37 -0800 (PST) Subject: Re: [PATCH 1/2] btrfs: Make btrfs_start_delalloc_root's nr argument a long To: Nikolay Borisov , dsterba@suse.cz Cc: linux-btrfs@vger.kernel.org References: <20210111105812.423915-1-nborisov@suse.com> From: Josef Bacik Message-ID: Date: Mon, 11 Jan 2021 10:48:36 -0500 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:78.0) Gecko/20100101 Thunderbird/78.6.0 MIME-Version: 1.0 In-Reply-To: <20210111105812.423915-1-nborisov@suse.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-btrfs@vger.kernel.org On 1/11/21 5:58 AM, Nikolay Borisov wrote: > It's currently u64 which gets instantly translated either to LONG_MAX > (if U64_MAX is passed) or casted to an unsigned long (which is in fact, > wrong because iwriteback_control::nr_to_write is a signed, long type). > > Just convert the function's argument to be long time which obviates the > need to manually convert u64 value to a long. Adjust all call sites > which pass U64_MAX to pass LONG_MAX. Finally ensure that in > shrink_delalloc the u64 is converted to a long without overflowing, > resulting in a negative number. > > Signed-off-by: Nikolay Borisov You can add Reviewed-by: Josef Bacik to both patches, thanks, Josef