From mboxrd@z Thu Jan 1 00:00:00 1970 From: Johannes Schindelin Subject: Re: [PATCH 16/18] fsck: support demoting errors to warnings Date: Tue, 23 Dec 2014 19:06:57 +0100 (CET) Message-ID: References: Mime-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Cc: git@vger.kernel.org To: Junio C Hamano X-From: git-owner@vger.kernel.org Tue Dec 23 19:07:14 2014 Return-path: Envelope-to: gcvg-git-2@plane.gmane.org Received: from vger.kernel.org ([209.132.180.67]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1Y3TrV-0007yd-HA for gcvg-git-2@plane.gmane.org; Tue, 23 Dec 2014 19:07:13 +0100 Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751574AbaLWSHG (ORCPT ); Tue, 23 Dec 2014 13:07:06 -0500 Received: from mout.gmx.net ([212.227.15.15]:60404 "EHLO mout.gmx.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751216AbaLWSHF (ORCPT ); Tue, 23 Dec 2014 13:07:05 -0500 Received: from s15462909.onlinehome-server.info ([87.106.4.80]) by mail.gmx.com (mrgmx003) with ESMTPSA (Nemesis) id 0Lg0wl-1XWalN1trH-00pdWX; Tue, 23 Dec 2014 19:06:58 +0100 X-X-Sender: schindelin@s15462909.onlinehome-server.info In-Reply-To: User-Agent: Alpine 1.00 (DEB 882 2007-12-20) X-Provags-ID: V03:K0:IKnu5u4O4F1E46w0xdgtvp/lQUDnwrWTrydDXKKeHBgSj88lNCM gE8vd0sfu7RYiXbp9PCWjbn8MVilqn5JsZE1g5Txp4q7fsBXJdusI+LUxHYbKfpezMZp3cv MxRnIMjU9tdIdQXiWKgXMBUz5HHfKyB2+PBVFofLNGV716VfUBF6FlWUrAZdE2+DMluCTtU Bwhryn6ocfaVgUcGlF22Q== X-UI-Out-Filterresults: notjunk:1; Sender: git-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org Archived-At: Hi Junio, On Tue, 23 Dec 2014, Junio C Hamano wrote: > Johannes Schindelin writes: > > > Okay, so just to clarify: you want me to > > > > - split the parser into > > > > - a parser that accepts only camelCased variable names when they > > come from the config (for use in fsck and receive-pack), and > > OK. > > > - another parser that rejects camelCased variable names and only > > accepts lower-case-dashed, intended for command-line parsing > > in fsck, index-pack and unpack-objects, and > > > > - consequently have a converter from the camelCased variable names we > > receive from the config in receive-pack so we can pass lower-case-dashed > > settings to index-pack and unpack-objects. > > I am not sure about the latter two. This needs a design discussion > what the command line options should be. > > I think the command line should be like this: > > git cmd --warn=missingTags,missingAuthor Okay. This contradicts the convention where Git uses lower-case-dashed command-line option values (e.g. on-demand, error-all, etc) and no camelCased options were present so far. But your wish is my command. Ciao, Dscho > > in the first place, i.e. "we may invent tokens to denote new kinds > of errors as we improve fsck", not with "we may add options for new > kinds of errors", i.e. the command line should not look like this: > > git cmd --missing-tags=warn --missing-author=warn > > And from that point of view, I see no reason to support the dashed > variant anywhere in the code, neither in the config parser or in the > command line parser. >