From mboxrd@z Thu Jan 1 00:00:00 1970 From: Johannes Schindelin Subject: Re: [PATCH 04/18] Offer a function to demote fsck errors to warnings Date: Tue, 23 Dec 2014 19:23:19 +0100 (CET) Message-ID: References: <2a0c4cd4c5d3aaceff8a6ffa49d2f3597d26086d.1418055173.git.johannes.schindelin@gmx.de> Mime-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Cc: Git Mailing List , Michael Haggerty To: Junio C Hamano X-From: git-owner@vger.kernel.org Tue Dec 23 19:23:31 2014 Return-path: Envelope-to: gcvg-git-2@plane.gmane.org Received: from vger.kernel.org ([209.132.180.67]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1Y3U7E-0000y7-60 for gcvg-git-2@plane.gmane.org; Tue, 23 Dec 2014 19:23:28 +0100 Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752127AbaLWSXY (ORCPT ); Tue, 23 Dec 2014 13:23:24 -0500 Received: from mout.gmx.net ([212.227.15.19]:57457 "EHLO mout.gmx.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751363AbaLWSXX (ORCPT ); Tue, 23 Dec 2014 13:23:23 -0500 Received: from s15462909.onlinehome-server.info ([87.106.4.80]) by mail.gmx.com (mrgmx003) with ESMTPSA (Nemesis) id 0MMjgF-1XyFiK35LD-008dni; Tue, 23 Dec 2014 19:23:19 +0100 X-X-Sender: schindelin@s15462909.onlinehome-server.info In-Reply-To: User-Agent: Alpine 1.00 (DEB 882 2007-12-20) X-Provags-ID: V03:K0:6S+QDr06LNLzwgfQRATuJOe0IiIBD2+WpY2DCgF/xDaIsN5Anat kaaAD0Vu7JBA/wOTGQFC4rCeF6f0vg6lADdfD6g4ZGXGwBNqrFGyhljwKueZdlBlPDo+n6S 61lwl5yaXbOk6UC8FqD/lEW/H8Vv5iefYLW9Fa6KZq9YiiWCt9gNZhKVyCdBQR4HK/VfCjh BtINXGyJl58ItAdRAKiOg== X-UI-Out-Filterresults: notjunk:1; Sender: git-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org Archived-At: Hi Junio, On Tue, 23 Dec 2014, Junio C Hamano wrote: > On Tue, Dec 23, 2014 at 9:28 AM, Johannes Schindelin > wrote: > >> Johannes Schindelin writes: > >> > >> > And *still*, this is *just* a global table with defaults. I would *still* > >> > need to copy-on-write when the first customization of the severity level > >> > takes place because I cannot allow the global defaults to be modified by > >> > one caller (that would defeat the whole purpose of having per-caller > >> > settings bundled in the fsck_options struct). > > > > There is no alloc. Right now, the initialization reads: > > > > struct fsck_options options = strict ? > > FSCK_OPTIONS_STRICT : FSCK_OPTIONS_DEFAULT; > > Then it is just the matter of having > > fsck_options_init(&options); > if (strict) > options.some_field = make_it_strict; > > as the first few statements, no? > > I am not sure why it is so difficult.... It is not difficult. But I try to avoid complexity when I can. Since you asked specifically, I will introduce it, though. Hopefully still this year (I'll not be available for a while starting tomorrow). Ciao, Dscho