From: Stefano Stabellini <stefano.stabellini@eu.citrix.com>
To: Ian Campbell <ian.campbell@citrix.com>
Cc: Wei Liu <wei.liu2@citrix.com>,
Vijay Kilari <vijay.kilari@gmail.com>,
Stefano Stabellini <stefano.stabellini@eu.citrix.com>,
Prasun Kapoor <Prasun.Kapoor@caviumnetworks.com>,
manish.jaggi@caviumnetworks.com,
"xen-devel@lists.xen.org" <xen-devel@lists.xen.org>,
Julien Grall <julien.grall@citrix.com>,
Stefano Stabellini <stefano.stabellini@citrix.com>
Subject: Re: Requesting for freeze exception for ARM/ITS patches
Date: Tue, 14 Jul 2015 11:51:59 +0100 [thread overview]
Message-ID: <alpine.DEB.2.02.1507141151300.17378@kaball.uk.xensource.com> (raw)
In-Reply-To: <1436860155.7019.137.camel@citrix.com>
On Tue, 14 Jul 2015, Ian Campbell wrote:
> On Mon, 2015-07-13 at 18:24 +0100, Stefano Stabellini wrote:
> > On Mon, 13 Jul 2015, Wei Liu wrote:
> > > On Fri, Jul 10, 2015 at 04:16:07PM +0530, Vijay Kilari wrote:
> > > > Hi Wei,
> > > >
> > > > I would like to have freeze exception for ITS feature on ARM64.
> > > > Design got freeze few weeks back and I have sent v4 version of patch series
> > > > today.
> > > >
> > > > This patches will not impact any generic code of other platforms and have minor
> > > > changes generic arm related code. Also these patches are only for
> > > > ARM64 platform.
> > > >
> > > > These patches are pre-requisite for PCI support / Pass-through support
> > > > on ARM64 platforms.
> > > >
> > > > The risk is minor and as of today only used by Cavium ThunderX platform.
> > > >
> > >
> > >
> > > I'm not a ARM expert, but last time I checked most patches in v3 are not
> > > acked.
> > >
> > > I also got conflict statements from maintainers and core developer. I
> > > will wait a bit for them clarify the situation.
> > >
> > > But as Ian said, if you can't post v4 and get most if all of your
> > > patches acked / reviewed early this week, my answer to this request
> > > would be no.
> >
> > I pretty much agree with Ian: I went through the patches and the impact
> > of the series on non-ITS platforms will be null after Vijay addresses:
> >
> > - the lpi irq_desc and irq_pending allocation issues
> > - improve lpi_supported to check for ITS presence
> >
> > these two changes should be trivial and are certainly necessary for a
> > freeze exception in my view.
> >
> >
> > On this basis, if Vijay manages to resend a v5 version on time with
> > those two issues covered, making sure that the new code is not enabled
> > unless an its is present, then I think that a freeze exception would be
> > OK as the risk would be zero.
>
> I don't think we should be limiting ourselves to only fixing issues
> which reduce the risk on non-ITS platforms. So the two issues which you
> highlight above are necessary but not sufficient for a freeze exception
> in my view.
>
> For example I am firmly of the opinion that the VPLI injection code
> needs to be corrected as discussed during review.
>
> Likewise I said that care needs to be taken wrt when any of this code is
> enabled, which includes not exposing it to domU even on platforms which
> support ITS. I also view this as a requirement for a freeze exception.
> In other words only dom0 and only on an ITS enabled system should be
> exposed to any aspect of the ITS support.
I agree.
next prev parent reply other threads:[~2015-07-14 10:51 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-10 10:46 Requesting for freeze exception for ARM/ITS patches Vijay Kilari
2015-07-10 11:01 ` Jan Beulich
2015-07-10 15:52 ` Ian Campbell
2015-07-11 6:36 ` Julien Grall
2015-07-14 9:24 ` Vijay Kilari
2015-07-14 9:50 ` Ian Campbell
2015-07-14 9:59 ` Vijay Kilari
2015-07-10 16:07 ` Ian Campbell
2015-07-11 7:18 ` Julien Grall
2015-07-11 9:21 ` Ian Campbell
2015-07-13 21:58 ` Julien Grall
2015-07-14 10:02 ` Vijay Kilari
2015-07-14 13:31 ` Ian Campbell
2015-07-13 13:55 ` Wei Liu
2015-07-13 13:56 ` Wei Liu
2015-07-13 17:24 ` Stefano Stabellini
2015-07-13 21:50 ` Julien Grall
2015-07-14 7:49 ` Ian Campbell
2015-07-14 10:51 ` Stefano Stabellini [this message]
2015-07-16 14:08 ` Wei Liu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.02.1507141151300.17378@kaball.uk.xensource.com \
--to=stefano.stabellini@eu.citrix.com \
--cc=Prasun.Kapoor@caviumnetworks.com \
--cc=ian.campbell@citrix.com \
--cc=julien.grall@citrix.com \
--cc=manish.jaggi@caviumnetworks.com \
--cc=stefano.stabellini@citrix.com \
--cc=vijay.kilari@gmail.com \
--cc=wei.liu2@citrix.com \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.