From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752041AbbIOEge (ORCPT ); Tue, 15 Sep 2015 00:36:34 -0400 Received: from mail2-relais-roc.national.inria.fr ([192.134.164.83]:44526 "EHLO mail2-relais-roc.national.inria.fr" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751389AbbIOEgd (ORCPT ); Tue, 15 Sep 2015 00:36:33 -0400 X-IronPort-AV: E=Sophos;i="5.17,532,1437429600"; d="scan'208";a="177555147" Date: Tue, 15 Sep 2015 06:36:30 +0200 (CEST) From: Julia Lawall X-X-Sender: jll@localhost6.localdomain6 To: Tyler Hicks cc: sergey.senozhatsky@gmail.com, kernel-janitors@vger.kernel.org, ecryptfs@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 28/39] ecryptfs: drop null test before destroy functions In-Reply-To: <20150915020830.GC32505@boyd> Message-ID: References: <1442146532-9100-1-git-send-email-Julia.Lawall@lip6.fr> <1442146532-9100-29-git-send-email-Julia.Lawall@lip6.fr> <20150915020830.GC32505@boyd> User-Agent: Alpine 2.02 (DEB 1266 2009-07-14) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 14 Sep 2015, Tyler Hicks wrote: > On 2015-09-13 14:15:21, Julia Lawall wrote: > > Remove unneeded NULL test. > > > > The semantic patch that makes this change is as follows: > > (http://coccinelle.lip6.fr/) > > > > // > > @@ expression x; @@ > > -if (x != NULL) > > \(kmem_cache_destroy\|mempool_destroy\|dma_pool_destroy\)(x); > > // > > > > Signed-off-by: Julia Lawall > > Acked-by: Tyler Hicks > > I assume that you'll be landing this patch set into Linus' tree all > together. Let me know if that's incorrect and I should take this single > patch into the eCryptfs dev tree. I'm not doing anythign after this point. Some others have taken the patch into their trees. julia > > Thanks! > > Tyler > > > > > --- > > fs/ecryptfs/main.c | 3 +-- > > 1 file changed, 1 insertion(+), 2 deletions(-) > > > > diff --git a/fs/ecryptfs/main.c b/fs/ecryptfs/main.c > > index 4f4d047..e83f31c 100644 > > --- a/fs/ecryptfs/main.c > > +++ b/fs/ecryptfs/main.c > > @@ -737,8 +737,7 @@ static void ecryptfs_free_kmem_caches(void) > > struct ecryptfs_cache_info *info; > > > > info = &ecryptfs_cache_infos[i]; > > - if (*(info->cache)) > > - kmem_cache_destroy(*(info->cache)); > > + kmem_cache_destroy(*(info->cache)); > > } > > } > > > > > From mboxrd@z Thu Jan 1 00:00:00 1970 From: Julia Lawall Date: Tue, 15 Sep 2015 04:36:30 +0000 Subject: Re: [PATCH 28/39] ecryptfs: drop null test before destroy functions Message-Id: List-Id: References: <1442146532-9100-1-git-send-email-Julia.Lawall@lip6.fr> <1442146532-9100-29-git-send-email-Julia.Lawall@lip6.fr> <20150915020830.GC32505@boyd> In-Reply-To: <20150915020830.GC32505@boyd> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Tyler Hicks Cc: sergey.senozhatsky@gmail.com, kernel-janitors@vger.kernel.org, ecryptfs@vger.kernel.org, linux-kernel@vger.kernel.org On Mon, 14 Sep 2015, Tyler Hicks wrote: > On 2015-09-13 14:15:21, Julia Lawall wrote: > > Remove unneeded NULL test. > > > > The semantic patch that makes this change is as follows: > > (http://coccinelle.lip6.fr/) > > > > // > > @@ expression x; @@ > > -if (x != NULL) > > \(kmem_cache_destroy\|mempool_destroy\|dma_pool_destroy\)(x); > > // > > > > Signed-off-by: Julia Lawall > > Acked-by: Tyler Hicks > > I assume that you'll be landing this patch set into Linus' tree all > together. Let me know if that's incorrect and I should take this single > patch into the eCryptfs dev tree. I'm not doing anythign after this point. Some others have taken the patch into their trees. julia > > Thanks! > > Tyler > > > > > --- > > fs/ecryptfs/main.c | 3 +-- > > 1 file changed, 1 insertion(+), 2 deletions(-) > > > > diff --git a/fs/ecryptfs/main.c b/fs/ecryptfs/main.c > > index 4f4d047..e83f31c 100644 > > --- a/fs/ecryptfs/main.c > > +++ b/fs/ecryptfs/main.c > > @@ -737,8 +737,7 @@ static void ecryptfs_free_kmem_caches(void) > > struct ecryptfs_cache_info *info; > > > > info = &ecryptfs_cache_infos[i]; > > - if (*(info->cache)) > > - kmem_cache_destroy(*(info->cache)); > > + kmem_cache_destroy(*(info->cache)); > > } > > } > > > > >