From mboxrd@z Thu Jan  1 00:00:00 1970
From: Stefano Stabellini <stefano.stabellini@eu.citrix.com>
Subject: Re: [PATCH v3 0/4] arm64: Add Xen boot support (via fdt)
Date: Thu, 1 Oct 2015 17:19:21 +0100
Message-ID: <alpine.DEB.2.02.1510011714390.14155@kaball.uk.xensource.com>
References: <=fu.wei@linaro.org>
	<1437628583-23667-1-git-send-email-fu.wei@linaro.org>
	<CADyBb7uXHPTHob=UTCbZ=zxKDZxycg3YM+PFu2nnn4D=Mo5a=w@mail.gmail.com>
	<CADyBb7vSU-So9+eGZNGOzg+SE8KpkmHCAwmkf1dCNnaa+tHQBg@mail.gmail.com>
	<alpine.DEB.2.02.1509301522450.14155@kaball.uk.xensource.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
In-Reply-To: <alpine.DEB.2.02.1509301522450.14155@kaball.uk.xensource.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Stefano Stabellini <stefano.stabellini@eu.citrix.com>
Cc: The development of GNU GRUB <grub-devel@gnu.org>, xen-devel@lists.xensource.com, Ian Campbell <Ian.Campbell@citrix.com>, Andrei Borzenkov <arvidjaar@gmail.com>, Vladimir Serbinenko <phcoder@gmail.com>, Leif Lindholm <leif.lindholm@linaro.org>, Ryan Harkin <ryan.harkin@linaro.org>, Linaro UEFI Mailman List <linaro-uefi@lists.linaro.org>, Jon Masters <jcm@redhat.com>, Fu Wei <fu.wei@linaro.org>
List-Id: xen-devel@lists.xenproject.org

On Wed, 30 Sep 2015, Stefano Stabellini wrote:
> Hi Fu,
> 
> I backported your patches to the CentOS aarch64 grub2 rpm.  I am testing
> it on X-Gene with EFI firmware. It works fine when booting Xen, but
> booting native kernels (no Xen) doesn't work anymore. Grub prints
> 
> error: out of memory.
> 
> Press any key to continue...
> 
> grub is still able to continue and load Linux, but then the kernel fails
> to boot with "Cannot open root device", even though the grub config is
> still same as before and the rootfs (which is xfs) hasn't changed.
> Reverting the patches solved the problem.
> 
> Do you have any ideas on what is causing the issue? Maybe the initramfs
> hasn't been properly loaded?

It looks like the following chunk of commit
f8451af8251a3866cb8b7307b9917dd5d34fbd0a "arm64: Export useful functions
from linux.c" causes troubles:


diff --git a/grub-core/loader/linux.c b/grub-core/loader/linux.c
index 117232f..a63a11a 100644
--- a/grub-core/loader/linux.c
+++ b/grub-core/loader/linux.c
@@ -205,7 +205,8 @@ grub_initrd_init (int argc, char *argv[],
       initrd_ctx->nfiles++;
       initrd_ctx->components[i].size
        = grub_file_size (initrd_ctx->components[i].file);
-      initrd_ctx->size += ALIGN_UP (initrd_ctx->components[i].size, 4);
+      if (argc != 1)
+       initrd_ctx->size += ALIGN_UP (initrd_ctx->components[i].size, 4);
     }
 
   if (newc)


Simply removing this change seems to fix the issue and Xen still boots
fine.