From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753926AbbIMQSM (ORCPT ); Sun, 13 Sep 2015 12:18:12 -0400 Received: from mail2-relais-roc.national.inria.fr ([192.134.164.83]:34653 "EHLO mail2-relais-roc.national.inria.fr" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752758AbbIMQSL (ORCPT ); Sun, 13 Sep 2015 12:18:11 -0400 X-IronPort-AV: E=Sophos;i="5.17,523,1437429600"; d="scan'208";a="177196930" Date: Sun, 13 Sep 2015 18:18:04 +0200 (CEST) From: Julia Lawall X-X-Sender: jll@hadrien To: Shraddha Barke cc: Greg Kroah-Hartman , Jes Sorensen , linux-kernel@vger.kernel.org Subject: Re: [PATCH v4 2/3] Staging: vt6656: Bool tests don't need comparisons In-Reply-To: <1442160279-6334-3-git-send-email-shraddha.6596@gmail.com> Message-ID: References: <1442160279-6334-1-git-send-email-shraddha.6596@gmail.com> <1442160279-6334-3-git-send-email-shraddha.6596@gmail.com> User-Agent: Alpine 2.10 (DEB 1266 2009-07-14) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, 13 Sep 2015, Shraddha Barke wrote: > This patch removes comparisons to true/false values on bool variables. > > Change in v4- > No changes This needs to go under the ---. It is not information that needs to be preserved in the git log. julia > Signed-off-by: Shraddha Barke > --- > drivers/staging/vt6656/wcmd.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/staging/vt6656/wcmd.c b/drivers/staging/vt6656/wcmd.c > index 3cbf479..c8e69ff 100644 > --- a/drivers/staging/vt6656/wcmd.c > +++ b/drivers/staging/vt6656/wcmd.c > @@ -177,7 +177,7 @@ int vnt_schedule_command(struct vnt_private *priv, enum vnt_cmd command) > ADD_ONE_WITH_WRAP_AROUND(priv->cmd_enqueue_idx, CMD_Q_SIZE); > priv->free_cmd_queue--; > > - if (priv->cmd_running == false) > + if (!priv->cmd_running) > vnt_cmd_complete(priv); > > return true; > -- > 2.1.4 > >