* [PATCH] Staging: i4l: Do not initialise statics to 0.
@ 2016-09-17 1:10 Sandhya Bankar
2016-09-17 12:21 ` [Outreachy kernel] " Julia Lawall
0 siblings, 1 reply; 2+ messages in thread
From: Sandhya Bankar @ 2016-09-17 1:10 UTC (permalink / raw
To: outreachy-kernel; +Cc: gregkh
Do not initialise statics to 0.
static variable by default initialise to 0,so
no need to explicite initialisation.
This issue was found by checkpatch .
Signed-off-by: Sandhya Bankar <bankarsandhya512@gmail.com>
---
drivers/staging/i4l/act2000/module.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/staging/i4l/act2000/module.c b/drivers/staging/i4l/act2000/module.c
index 68073d0..39a8940 100755
--- a/drivers/staging/i4l/act2000/module.c
+++ b/drivers/staging/i4l/act2000/module.c
@@ -28,7 +28,7 @@ static unsigned short act2000_isa_ports[] =
static act2000_card *cards = (act2000_card *) NULL;
/* Parameters to be set by insmod */
-static int act_bus = 0;
+static int act_bus;
static int act_port = -1; /* -1 = Autoprobe */
static int act_irq = -1;
static char *act_id = "\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0";
--
1.7.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [Outreachy kernel] [PATCH] Staging: i4l: Do not initialise statics to 0.
2016-09-17 1:10 [PATCH] Staging: i4l: Do not initialise statics to 0 Sandhya Bankar
@ 2016-09-17 12:21 ` Julia Lawall
0 siblings, 0 replies; 2+ messages in thread
From: Julia Lawall @ 2016-09-17 12:21 UTC (permalink / raw
To: Sandhya Bankar; +Cc: outreachy-kernel, gregkh
On Sat, 17 Sep 2016, Sandhya Bankar wrote:
> Do not initialise statics to 0.
> static variable by default initialise to 0,so
> no need to explicite initialisation.
> This issue was found by checkpatch .
Your commit message should fill more of the available 80 characters.
Sentences should start with a capital letter. Punctuation should have no
space before and a space after. The commit message is preserved forever,
so it is good for it to look nice.
julia
>
> Signed-off-by: Sandhya Bankar <bankarsandhya512@gmail.com>
> ---
> drivers/staging/i4l/act2000/module.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/staging/i4l/act2000/module.c b/drivers/staging/i4l/act2000/module.c
> index 68073d0..39a8940 100755
> --- a/drivers/staging/i4l/act2000/module.c
> +++ b/drivers/staging/i4l/act2000/module.c
> @@ -28,7 +28,7 @@ static unsigned short act2000_isa_ports[] =
> static act2000_card *cards = (act2000_card *) NULL;
>
> /* Parameters to be set by insmod */
> -static int act_bus = 0;
> +static int act_bus;
> static int act_port = -1; /* -1 = Autoprobe */
> static int act_irq = -1;
> static char *act_id = "\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0";
> --
> 1.7.1
>
> --
> You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
> To unsubscribe from this group and stop receiving emails from it, send an email to outreachy-kernel+unsubscribe@googlegroups.com.
> To post to this group, send email to outreachy-kernel@googlegroups.com.
> To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/20160917011052.GA14721%40sandhya.
> For more options, visit https://groups.google.com/d/optout.
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2016-09-17 12:21 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-09-17 1:10 [PATCH] Staging: i4l: Do not initialise statics to 0 Sandhya Bankar
2016-09-17 12:21 ` [Outreachy kernel] " Julia Lawall
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.