From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751687AbbLHSPn (ORCPT ); Tue, 8 Dec 2015 13:15:43 -0500 Received: from www.linutronix.de ([62.245.132.108]:51531 "EHLO Galois.linutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751132AbbLHSPm (ORCPT ); Tue, 8 Dec 2015 13:15:42 -0500 Date: Tue, 8 Dec 2015 19:14:54 +0100 (CET) From: Thomas Gleixner To: Dave Hansen cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, x86@kernel.org, dave.hansen@linux.intel.com Subject: Re: [PATCH 19/34] x86, pkeys: optimize fault handling in access_error() In-Reply-To: <20151204011450.A07593D5@viggo.jf.intel.com> Message-ID: References: <20151204011424.8A36E365@viggo.jf.intel.com> <20151204011450.A07593D5@viggo.jf.intel.com> User-Agent: Alpine 2.11 (DEB 23 2013-08-11) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII X-Linutronix-Spam-Score: -1.0 X-Linutronix-Spam-Level: - X-Linutronix-Spam-Status: No , -1.0 points, 5.0 required, ALL_TRUSTED=-1,SHORTCIRCUIT=-0.0001,URIBL_BLOCKED=0.001 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 3 Dec 2015, Dave Hansen wrote: > diff -puN arch/x86/mm/fault.c~pkeys-15-access_error arch/x86/mm/fault.c > --- a/arch/x86/mm/fault.c~pkeys-15-access_error 2015-12-03 16:21:26.872727820 -0800 > +++ b/arch/x86/mm/fault.c 2015-12-03 16:21:26.876728002 -0800 > @@ -900,10 +900,16 @@ bad_area(struct pt_regs *regs, unsigned > static inline bool bad_area_access_from_pkeys(unsigned long error_code, > struct vm_area_struct *vma) > { > + /* This code is always called on the current mm */ > + int foreign = 0; arch_vma_access_permitted takes a bool .... > if (!boot_cpu_has(X86_FEATURE_OSPKE)) > return false; > if (error_code & PF_PK) > return true; > + /* this checks permission keys on the VMA: */ > + if (!arch_vma_access_permitted(vma, (error_code & PF_WRITE), foreign)) > + return true; > return false; > } > > @@ -1091,6 +1097,8 @@ int show_unhandled_signals = 1; > static inline int > access_error(unsigned long error_code, struct vm_area_struct *vma) > { > + /* This is only called for the current mm, so: */ > + int foreign = 0; Ditto. Other than that: Reviewed-by: Thomas Gleixner From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm0-f51.google.com (mail-wm0-f51.google.com [74.125.82.51]) by kanga.kvack.org (Postfix) with ESMTP id 4924D6B0255 for ; Tue, 8 Dec 2015 13:15:44 -0500 (EST) Received: by wmuu63 with SMTP id u63so191614112wmu.0 for ; Tue, 08 Dec 2015 10:15:43 -0800 (PST) Received: from Galois.linutronix.de (linutronix.de. [2001:470:1f0b:db:abcd:42:0:1]) by mx.google.com with ESMTPS id kj9si5825723wjb.72.2015.12.08.10.15.43 for (version=TLS1_2 cipher=AES128-SHA bits=128/128); Tue, 08 Dec 2015 10:15:43 -0800 (PST) Date: Tue, 8 Dec 2015 19:14:54 +0100 (CET) From: Thomas Gleixner Subject: Re: [PATCH 19/34] x86, pkeys: optimize fault handling in access_error() In-Reply-To: <20151204011450.A07593D5@viggo.jf.intel.com> Message-ID: References: <20151204011424.8A36E365@viggo.jf.intel.com> <20151204011450.A07593D5@viggo.jf.intel.com> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: owner-linux-mm@kvack.org List-ID: To: Dave Hansen Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, x86@kernel.org, dave.hansen@linux.intel.com On Thu, 3 Dec 2015, Dave Hansen wrote: > diff -puN arch/x86/mm/fault.c~pkeys-15-access_error arch/x86/mm/fault.c > --- a/arch/x86/mm/fault.c~pkeys-15-access_error 2015-12-03 16:21:26.872727820 -0800 > +++ b/arch/x86/mm/fault.c 2015-12-03 16:21:26.876728002 -0800 > @@ -900,10 +900,16 @@ bad_area(struct pt_regs *regs, unsigned > static inline bool bad_area_access_from_pkeys(unsigned long error_code, > struct vm_area_struct *vma) > { > + /* This code is always called on the current mm */ > + int foreign = 0; arch_vma_access_permitted takes a bool .... > if (!boot_cpu_has(X86_FEATURE_OSPKE)) > return false; > if (error_code & PF_PK) > return true; > + /* this checks permission keys on the VMA: */ > + if (!arch_vma_access_permitted(vma, (error_code & PF_WRITE), foreign)) > + return true; > return false; > } > > @@ -1091,6 +1097,8 @@ int show_unhandled_signals = 1; > static inline int > access_error(unsigned long error_code, struct vm_area_struct *vma) > { > + /* This is only called for the current mm, so: */ > + int foreign = 0; Ditto. Other than that: Reviewed-by: Thomas Gleixner -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org