From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751864AbbLHSR4 (ORCPT ); Tue, 8 Dec 2015 13:17:56 -0500 Received: from www.linutronix.de ([62.245.132.108]:51549 "EHLO Galois.linutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751666AbbLHSRy (ORCPT ); Tue, 8 Dec 2015 13:17:54 -0500 Date: Tue, 8 Dec 2015 19:17:05 +0100 (CET) From: Thomas Gleixner To: Dave Hansen cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, x86@kernel.org, dave.hansen@linux.intel.com Subject: Re: [PATCH 20/34] x86, pkeys: differentiate instruction fetches In-Reply-To: <20151204011452.AA84FFA8@viggo.jf.intel.com> Message-ID: References: <20151204011424.8A36E365@viggo.jf.intel.com> <20151204011452.AA84FFA8@viggo.jf.intel.com> User-Agent: Alpine 2.11 (DEB 23 2013-08-11) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII X-Linutronix-Spam-Score: -1.0 X-Linutronix-Spam-Level: - X-Linutronix-Spam-Status: No , -1.0 points, 5.0 required, ALL_TRUSTED=-1,SHORTCIRCUIT=-0.0001,URIBL_BLOCKED=0.001 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 3 Dec 2015, Dave Hansen wrote: > static inline bool arch_vma_access_permitted(struct vm_area_struct *vma, > - bool write, bool foreign) > + bool write, bool execute, bool foreign) .... > + /* > + * gups are always data accesses, not instruction > + * fetches, so execute=0 here Again. Can we please be consistent about booleans? > + */ > + if (!arch_vma_access_permitted(vma, write, 0, foreign)) > return -EFAULT; > return 0; > } > @@ -576,8 +580,11 @@ bool vma_permits_fault(struct vm_area_st > /* > * The architecture might have a hardware protection > * mechanism other than read/write that can deny access. > + * > + * gup always represents data access, not instruction > + * fetches, so execute=0 here: > */ > - if (!arch_vma_access_permitted(vma, write, foreign)) > + if (!arch_vma_access_permitted(vma, write, 0, foreign)) > return false; Ditto. Other than that: Reviewed-by: Thomas Gleixner From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm0-f47.google.com (mail-wm0-f47.google.com [74.125.82.47]) by kanga.kvack.org (Postfix) with ESMTP id DF5F36B0255 for ; Tue, 8 Dec 2015 13:17:55 -0500 (EST) Received: by wmuu63 with SMTP id u63so191683274wmu.0 for ; Tue, 08 Dec 2015 10:17:55 -0800 (PST) Received: from Galois.linutronix.de (linutronix.de. [2001:470:1f0b:db:abcd:42:0:1]) by mx.google.com with ESMTPS id i204si32011195wma.10.2015.12.08.10.17.54 for (version=TLS1_2 cipher=AES128-SHA bits=128/128); Tue, 08 Dec 2015 10:17:55 -0800 (PST) Date: Tue, 8 Dec 2015 19:17:05 +0100 (CET) From: Thomas Gleixner Subject: Re: [PATCH 20/34] x86, pkeys: differentiate instruction fetches In-Reply-To: <20151204011452.AA84FFA8@viggo.jf.intel.com> Message-ID: References: <20151204011424.8A36E365@viggo.jf.intel.com> <20151204011452.AA84FFA8@viggo.jf.intel.com> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: owner-linux-mm@kvack.org List-ID: To: Dave Hansen Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, x86@kernel.org, dave.hansen@linux.intel.com On Thu, 3 Dec 2015, Dave Hansen wrote: > static inline bool arch_vma_access_permitted(struct vm_area_struct *vma, > - bool write, bool foreign) > + bool write, bool execute, bool foreign) .... > + /* > + * gups are always data accesses, not instruction > + * fetches, so execute=0 here Again. Can we please be consistent about booleans? > + */ > + if (!arch_vma_access_permitted(vma, write, 0, foreign)) > return -EFAULT; > return 0; > } > @@ -576,8 +580,11 @@ bool vma_permits_fault(struct vm_area_st > /* > * The architecture might have a hardware protection > * mechanism other than read/write that can deny access. > + * > + * gup always represents data access, not instruction > + * fetches, so execute=0 here: > */ > - if (!arch_vma_access_permitted(vma, write, foreign)) > + if (!arch_vma_access_permitted(vma, write, 0, foreign)) > return false; Ditto. Other than that: Reviewed-by: Thomas Gleixner -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org