From: Thomas Gleixner <tglx@linutronix.de>
To: Borislav Petkov <bp@alien8.de>
Cc: "Luck, Tony" <tony.luck@intel.com>,
linux-edac <linux-edac@vger.kernel.org>, X86 ML <x86@kernel.org>,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] x86/MCE: Remove MCP_TIMESTAMP
Date: Tue, 8 Nov 2016 21:39:02 +0100 (CET) [thread overview]
Message-ID: <alpine.DEB.2.20.1611082136380.3501@nanos> (raw)
In-Reply-To: <20161108180932.wvvcbbzrzrai26eg@pd.tnic>
On Tue, 8 Nov 2016, Borislav Petkov wrote:
>
> Also, this fixes another bug where machine_check_poll() would clear
> mce.tsc unconditionally even if we requested precise MCP_TIMESTAMP
> logging.
> @@ -713,7 +713,6 @@ bool machine_check_poll(enum mcp_flags flags, mce_banks_t *b)
> m.misc = 0;
> m.addr = 0;
> m.bank = i;
> - m.tsc = 0;
That does not make any sense. Where is m.tsc initialized? I couldn't find
any place which does, except this and the conditional clear farther down in
that function.
Thanks,
tglx
next prev parent reply other threads:[~2016-11-08 20:41 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-01 12:09 [RFC PATCH 0/3] x86/RAS: Dump error record to dmesg if no consumers Borislav Petkov
2016-11-01 12:09 ` [RFC PATCH 1/3] notifiers: Document notifier priority Borislav Petkov
2016-11-01 12:09 ` [RFC PATCH 2/3] x86/RAS: Add TSC to the injected MCE Borislav Petkov
2016-11-08 16:19 ` [tip:ras/core] x86/RAS: Add TSC timestamp " tip-bot for Borislav Petkov
2016-11-01 12:09 ` [RFC PATCH 3/3] x86/MCE: Dump MCE to dmesg if no consumers Borislav Petkov
2016-11-08 16:19 ` [tip:ras/core] " tip-bot for Borislav Petkov
2016-11-05 13:11 ` [PATCH] x86/MCE: Remove MCP_TIMESTAMP Borislav Petkov
2016-11-07 17:48 ` Luck, Tony
2016-11-07 18:08 ` Borislav Petkov
2016-11-07 18:37 ` Luck, Tony
2016-11-08 18:09 ` Borislav Petkov
2016-11-08 18:22 ` Luck, Tony
2016-11-08 20:39 ` Thomas Gleixner [this message]
2016-11-08 21:08 ` Borislav Petkov
2016-11-08 21:14 ` Thomas Gleixner
2016-11-08 21:24 ` Borislav Petkov
2016-11-08 21:54 ` Thomas Gleixner
2016-11-09 18:06 ` Borislav Petkov
2017-01-18 20:34 ` Borislav Petkov
2017-01-19 13:34 ` Borislav Petkov
2016-11-07 7:37 ` [RFC PATCH 0/3] x86/RAS: Dump error record to dmesg if no consumers Ingo Molnar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.20.1611082136380.3501@nanos \
--to=tglx@linutronix.de \
--cc=bp@alien8.de \
--cc=linux-edac@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=tony.luck@intel.com \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.