* [PATCH] riscv: dts: fu540-c000: drop "timebase-frequency"
@ 2019-07-25 21:30 ` Paul Walmsley
0 siblings, 0 replies; 4+ messages in thread
From: Paul Walmsley @ 2019-07-25 21:30 UTC (permalink / raw
To: linux-riscv; +Cc: linux-kernel, robh+dt, mark.rutland, palmer, devicetree
On FU540-based systems, the "timebase-frequency" (RTCCLK) is sourced
from an external crystal located on the PCB. Thus the
timebase-frequency DT property should be defined by the board that
uses the SoC, not the SoC itself. Drop the superfluous
timebase-frequency property from the SoC DT data. (It's already
present in the board DT data.)
Signed-off-by: Paul Walmsley <paul.walmsley@sifive.com>
---
arch/riscv/boot/dts/sifive/fu540-c000.dtsi | 1 -
1 file changed, 1 deletion(-)
diff --git a/arch/riscv/boot/dts/sifive/fu540-c000.dtsi b/arch/riscv/boot/dts/sifive/fu540-c000.dtsi
index 9bf63f0ab253..42b5ec223100 100644
--- a/arch/riscv/boot/dts/sifive/fu540-c000.dtsi
+++ b/arch/riscv/boot/dts/sifive/fu540-c000.dtsi
@@ -21,7 +21,6 @@
cpus {
#address-cells = <1>;
#size-cells = <0>;
- timebase-frequency = <1000000>;
cpu0: cpu@0 {
compatible = "sifive,e51", "sifive,rocket0", "riscv";
device_type = "cpu";
--
2.22.0
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [PATCH] riscv: dts: fu540-c000: drop "timebase-frequency"
@ 2019-07-25 21:30 ` Paul Walmsley
0 siblings, 0 replies; 4+ messages in thread
From: Paul Walmsley @ 2019-07-25 21:30 UTC (permalink / raw
To: linux-riscv; +Cc: mark.rutland, devicetree, robh+dt, palmer, linux-kernel
On FU540-based systems, the "timebase-frequency" (RTCCLK) is sourced
from an external crystal located on the PCB. Thus the
timebase-frequency DT property should be defined by the board that
uses the SoC, not the SoC itself. Drop the superfluous
timebase-frequency property from the SoC DT data. (It's already
present in the board DT data.)
Signed-off-by: Paul Walmsley <paul.walmsley@sifive.com>
---
arch/riscv/boot/dts/sifive/fu540-c000.dtsi | 1 -
1 file changed, 1 deletion(-)
diff --git a/arch/riscv/boot/dts/sifive/fu540-c000.dtsi b/arch/riscv/boot/dts/sifive/fu540-c000.dtsi
index 9bf63f0ab253..42b5ec223100 100644
--- a/arch/riscv/boot/dts/sifive/fu540-c000.dtsi
+++ b/arch/riscv/boot/dts/sifive/fu540-c000.dtsi
@@ -21,7 +21,6 @@
cpus {
#address-cells = <1>;
#size-cells = <0>;
- timebase-frequency = <1000000>;
cpu0: cpu@0 {
compatible = "sifive,e51", "sifive,rocket0", "riscv";
device_type = "cpu";
--
2.22.0
_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] riscv: dts: fu540-c000: drop "timebase-frequency"
2019-07-25 21:30 ` Paul Walmsley
@ 2019-07-28 13:40 ` Bin Meng
-1 siblings, 0 replies; 4+ messages in thread
From: Bin Meng @ 2019-07-28 13:40 UTC (permalink / raw
To: Paul Walmsley
Cc: linux-riscv, Mark Rutland, devicetree, Rob Herring,
Palmer Dabbelt, linux-kernel
On Fri, Jul 26, 2019 at 5:31 AM Paul Walmsley <paul.walmsley@sifive.com> wrote:
>
>
> On FU540-based systems, the "timebase-frequency" (RTCCLK) is sourced
> from an external crystal located on the PCB. Thus the
> timebase-frequency DT property should be defined by the board that
> uses the SoC, not the SoC itself. Drop the superfluous
> timebase-frequency property from the SoC DT data. (It's already
> present in the board DT data.)
>
> Signed-off-by: Paul Walmsley <paul.walmsley@sifive.com>
> ---
> arch/riscv/boot/dts/sifive/fu540-c000.dtsi | 1 -
> 1 file changed, 1 deletion(-)
>
Reviewed-by: Bin Meng <bmeng.cn@gmail.com>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] riscv: dts: fu540-c000: drop "timebase-frequency"
@ 2019-07-28 13:40 ` Bin Meng
0 siblings, 0 replies; 4+ messages in thread
From: Bin Meng @ 2019-07-28 13:40 UTC (permalink / raw
To: Paul Walmsley
Cc: Mark Rutland, devicetree, Palmer Dabbelt, linux-kernel,
Rob Herring, linux-riscv
On Fri, Jul 26, 2019 at 5:31 AM Paul Walmsley <paul.walmsley@sifive.com> wrote:
>
>
> On FU540-based systems, the "timebase-frequency" (RTCCLK) is sourced
> from an external crystal located on the PCB. Thus the
> timebase-frequency DT property should be defined by the board that
> uses the SoC, not the SoC itself. Drop the superfluous
> timebase-frequency property from the SoC DT data. (It's already
> present in the board DT data.)
>
> Signed-off-by: Paul Walmsley <paul.walmsley@sifive.com>
> ---
> arch/riscv/boot/dts/sifive/fu540-c000.dtsi | 1 -
> 1 file changed, 1 deletion(-)
>
Reviewed-by: Bin Meng <bmeng.cn@gmail.com>
_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2019-07-28 13:40 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-07-25 21:30 [PATCH] riscv: dts: fu540-c000: drop "timebase-frequency" Paul Walmsley
2019-07-25 21:30 ` Paul Walmsley
2019-07-28 13:40 ` Bin Meng
2019-07-28 13:40 ` Bin Meng
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.