From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755373AbbHFRao (ORCPT ); Thu, 6 Aug 2015 13:30:44 -0400 Received: from mail-qg0-f54.google.com ([209.85.192.54]:34443 "EHLO mail-qg0-f54.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753296AbbHFRan (ORCPT ); Thu, 6 Aug 2015 13:30:43 -0400 Date: Thu, 6 Aug 2015 13:30:40 -0400 (EDT) From: Nicolas Pitre To: Drew Richardson cc: "linux@arm.linux.org.uk" , Dave P Martin , "christoffer.dall@linaro.org" , "linux-arm-kernel@lists.infradead.org" , "linux-kernel@vger.kernel.org" , Wade Cherry , Pawel Moll Subject: Re: [PATCH] ARM: Mark ret_fast_syscall as a function In-Reply-To: <20150806170758.GA26691@dreric01-gentoo.localdomain> Message-ID: References: <1436877957-18127-1-git-send-email-drew.richardson@arm.com> <20150806170758.GA26691@dreric01-gentoo.localdomain> User-Agent: Alpine 2.20 (LFD 67 2015-01-07) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 6 Aug 2015, Drew Richardson wrote: > On Tue, Jul 14, 2015 at 01:45:57PM +0100, Drew Richardson wrote: > > ret_fast_syscall runs when user space makes a syscall. However it > > needs to be marked as such so the ELF information is correct. Before > > it was: > > > > 101: 8000f300 0 NOTYPE LOCAL DEFAULT 2 ret_fast_syscall > > > > But with this change it correctly shows as: > > > > 101: 8000f300 96 FUNC LOCAL DEFAULT 2 ret_fast_syscall > > > > I see this function when using perf to unwind call stacks from kernel > > space to user space. Without this change I would need to add some > > special case logic when using the vmlinux ELF information. > > > > Signed-off-by: Drew Richardson > > I haven't heard any further comments on this, did this get merged and > I just didn't notice? Or did I forget to add someone? Most likely that it is so trivial that nobody paid much attention. FWIW, you can add Acked-by: Nicolas Pitre and submit it here: http://www.arm.linux.org.uk/developer/patches/ Nicolas From mboxrd@z Thu Jan 1 00:00:00 1970 From: nicolas.pitre@linaro.org (Nicolas Pitre) Date: Thu, 6 Aug 2015 13:30:40 -0400 (EDT) Subject: [PATCH] ARM: Mark ret_fast_syscall as a function In-Reply-To: <20150806170758.GA26691@dreric01-gentoo.localdomain> References: <1436877957-18127-1-git-send-email-drew.richardson@arm.com> <20150806170758.GA26691@dreric01-gentoo.localdomain> Message-ID: To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Thu, 6 Aug 2015, Drew Richardson wrote: > On Tue, Jul 14, 2015 at 01:45:57PM +0100, Drew Richardson wrote: > > ret_fast_syscall runs when user space makes a syscall. However it > > needs to be marked as such so the ELF information is correct. Before > > it was: > > > > 101: 8000f300 0 NOTYPE LOCAL DEFAULT 2 ret_fast_syscall > > > > But with this change it correctly shows as: > > > > 101: 8000f300 96 FUNC LOCAL DEFAULT 2 ret_fast_syscall > > > > I see this function when using perf to unwind call stacks from kernel > > space to user space. Without this change I would need to add some > > special case logic when using the vmlinux ELF information. > > > > Signed-off-by: Drew Richardson > > I haven't heard any further comments on this, did this get merged and > I just didn't notice? Or did I forget to add someone? Most likely that it is so trivial that nobody paid much attention. FWIW, you can add Acked-by: Nicolas Pitre and submit it here: http://www.arm.linux.org.uk/developer/patches/ Nicolas