* why does oe-buildenv-internal check for -z "$BDIR"?
@ 2020-04-18 16:04 Robert P. J. Day
2020-04-18 16:30 ` [OE-core] " Richard Purdie
0 siblings, 1 reply; 13+ messages in thread
From: Robert P. J. Day @ 2020-04-18 16:04 UTC (permalink / raw
To: OE Core mailing list
perusing the OE init scripts, and noticed this in
oe-buildenv-internal, line 42:
if [ -z "$BDIR" ]; then
if [ -z "$1" ]; then
BDIR="build"
else
BDIR="$1"
... snip ...
i'm curious ... under what circumstances would BDIR *not* be unset
(or not be the empty string) at that point? i'm just puzzled as to a
possible flow of control that gets to that point where BDIR has a
non-empty value, since i've never seen any mention in the docs about
such a possibility.
doesn't hurt, of course, just not sure what that test is trying to
accomplish.
rday
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [OE-core] why does oe-buildenv-internal check for -z "$BDIR"?
2020-04-18 16:04 why does oe-buildenv-internal check for -z "$BDIR"? Robert P. J. Day
@ 2020-04-18 16:30 ` Richard Purdie
2020-04-18 16:43 ` Robert P. J. Day
0 siblings, 1 reply; 13+ messages in thread
From: Richard Purdie @ 2020-04-18 16:30 UTC (permalink / raw
To: Robert P. J. Day, OE Core mailing list
On Sat, 2020-04-18 at 12:04 -0400, Robert P. J. Day wrote:
> perusing the OE init scripts, and noticed this in
> oe-buildenv-internal, line 42:
>
> if [ -z "$BDIR" ]; then
> if [ -z "$1" ]; then
> BDIR="build"
> else
> BDIR="$1"
> ... snip ...
>
> i'm curious ... under what circumstances would BDIR *not* be unset
> (or not be the empty string) at that point? i'm just puzzled as to a
> possible flow of control that gets to that point where BDIR has a
> non-empty value, since i've never seen any mention in the docs about
> such a possibility.
>
> doesn't hurt, of course, just not sure what that test is trying to
> accomplish.
You can do:
$ source oe-init-build-env build2
and if your shell supports it, build becomes build2?
Cheers,
Richard
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [OE-core] why does oe-buildenv-internal check for -z "$BDIR"?
2020-04-18 16:30 ` [OE-core] " Richard Purdie
@ 2020-04-18 16:43 ` Robert P. J. Day
2020-04-18 17:08 ` Chris Laplante
0 siblings, 1 reply; 13+ messages in thread
From: Robert P. J. Day @ 2020-04-18 16:43 UTC (permalink / raw
To: Richard Purdie; +Cc: OE Core mailing list
On Sat, 18 Apr 2020, Richard Purdie wrote:
> On Sat, 2020-04-18 at 12:04 -0400, Robert P. J. Day wrote:
> > perusing the OE init scripts, and noticed this in
> > oe-buildenv-internal, line 42:
> >
> > if [ -z "$BDIR" ]; then
> > if [ -z "$1" ]; then
> > BDIR="build"
> > else
> > BDIR="$1"
> > ... snip ...
> >
> > i'm curious ... under what circumstances would BDIR *not* be unset
> > (or not be the empty string) at that point? i'm just puzzled as to a
> > possible flow of control that gets to that point where BDIR has a
> > non-empty value, since i've never seen any mention in the docs about
> > such a possibility.
> >
> > doesn't hurt, of course, just not sure what that test is trying to
> > accomplish.
>
> You can do:
>
> $ source oe-init-build-env build2
>
> and if your shell supports it, build becomes build2?
i know that -- in fact, it's the only way i use it -- the question
is the purpose for checking if $BDIR is zero length first. that is,
under what circumstances could it *not* be? even invoking the way you
demonstrate, that variable is empty when tested, and i see nothing
that could cause it to have a value before that test.
rday
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [OE-core] why does oe-buildenv-internal check for -z "$BDIR"?
2020-04-18 16:43 ` Robert P. J. Day
@ 2020-04-18 17:08 ` Chris Laplante
2020-04-18 17:23 ` Robert P. J. Day
0 siblings, 1 reply; 13+ messages in thread
From: Chris Laplante @ 2020-04-18 17:08 UTC (permalink / raw
To: rpjday@crashcourse.ca, Richard Purdie; +Cc: OE Core mailing list
> i know that -- in fact, it's the only way i use it -- the question
> is the purpose for checking if $BDIR is zero length first. that is,
> under what circumstances could it *not* be? even invoking the way you
> demonstrate, that variable is empty when tested, and i see nothing
> that could cause it to have a value before that test.
FWIW I was curious/bored and looked to see if 'BDIR' was ever used in poky (outside of the script of course), and I found no results.
git rev-list --all | xargs git grep -w BDIR -- './*' ':!scripts/oe-buildenv-internal'
Chris
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [OE-core] why does oe-buildenv-internal check for -z "$BDIR"?
2020-04-18 17:08 ` Chris Laplante
@ 2020-04-18 17:23 ` Robert P. J. Day
2020-04-18 18:45 ` Peter Kjellerstedt
0 siblings, 1 reply; 13+ messages in thread
From: Robert P. J. Day @ 2020-04-18 17:23 UTC (permalink / raw
To: chris.laplante@agilent.com; +Cc: Richard Purdie, OE Core mailing list
On Sat, 18 Apr 2020, chris.laplante@agilent.com wrote:
> > i know that -- in fact, it's the only way i use it -- the question
> > is the purpose for checking if $BDIR is zero length first. that is,
> > under what circumstances could it *not* be? even invoking the way you
> > demonstrate, that variable is empty when tested, and i see nothing
> > that could cause it to have a value before that test.
>
> FWIW I was curious/bored and looked to see if 'BDIR' was ever used
> in poky (outside of the script of course), and I found no results.
>
> git rev-list --all | xargs git grep -w BDIR -- './*' ':!scripts/oe-buildenv-internal'
that's kind of the point i was making ... that variable appeared out
of nowhere, clearly seemed like a local variable, and is even "unset"
after it's used in that script. i poked around, trying to figure if
there was some other flow of control that got you into that script
from another direction, but i didn't find one.
and, yes, it seems trivial to obsess over it, but it's just those
sorts of things that make me wonder, "hmmmmm ... maybe i *don't*
really understand how this script can be used."
anyway, moving on ...
rday
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [OE-core] why does oe-buildenv-internal check for -z "$BDIR"?
2020-04-18 17:23 ` Robert P. J. Day
@ 2020-04-18 18:45 ` Peter Kjellerstedt
2020-04-18 18:55 ` Robert P. J. Day
2020-04-18 20:10 ` Robert P. J. Day
0 siblings, 2 replies; 13+ messages in thread
From: Peter Kjellerstedt @ 2020-04-18 18:45 UTC (permalink / raw
To: Robert P. J. Day, chris.laplante@agilent.com
Cc: Richard Purdie, OE Core mailing list
> -----Original Message-----
> From: openembedded-core@lists.openembedded.org <openembedded-
> core@lists.openembedded.org> On Behalf Of Robert P. J. Day
> Sent: den 18 april 2020 19:24
> To: chris.laplante@agilent.com
> Cc: Richard Purdie <richard.purdie@linuxfoundation.org>; OE Core mailing
> list <openembedded-core@lists.openembedded.org>
> Subject: Re: [OE-core] why does oe-buildenv-internal check for -z
> "$BDIR"?
>
> On Sat, 18 Apr 2020, chris.laplante@agilent.com wrote:
>
> > > i know that -- in fact, it's the only way i use it -- the question
> > > is the purpose for checking if $BDIR is zero length first. that is,
> > > under what circumstances could it *not* be? even invoking the way you
> > > demonstrate, that variable is empty when tested, and i see nothing
> > > that could cause it to have a value before that test.
> >
> > FWIW I was curious/bored and looked to see if 'BDIR' was ever used
> > in poky (outside of the script of course), and I found no results.
> >
> > git rev-list --all | xargs git grep -w BDIR -- './*' ':!scripts/oe-
> buildenv-internal'
>
> that's kind of the point i was making ... that variable appeared out
> of nowhere, clearly seemed like a local variable, and is even "unset"
> after it's used in that script. i poked around, trying to figure if
> there was some other flow of control that got you into that script
> from another direction, but i didn't find one.
>
> and, yes, it seems trivial to obsess over it, but it's just those
> sorts of things that make me wonder, "hmmmmm ... maybe i *don't*
> really understand how this script can be used."
>
> anyway, moving on ...
>
> rday
When it comes to understanding why the code looks like it does in a case
like this, it is often better to look at the history than the current state.
If you go back to when the test was introduced (commit
5d5fab77cf9616bf62023c202b38f309f8bbf189 in Poky), you will see that
BDIR could be set in a script called poky-autobuild at that time. The
poky-autobuild script was removed 12 years ago, but the test in
oe-buildenv-internal remained.
//Peter
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [OE-core] why does oe-buildenv-internal check for -z "$BDIR"?
2020-04-18 18:45 ` Peter Kjellerstedt
@ 2020-04-18 18:55 ` Robert P. J. Day
2020-04-18 20:10 ` Robert P. J. Day
1 sibling, 0 replies; 13+ messages in thread
From: Robert P. J. Day @ 2020-04-18 18:55 UTC (permalink / raw
To: Peter Kjellerstedt
Cc: chris.laplante@agilent.com, Richard Purdie, OE Core mailing list
On Sat, 18 Apr 2020, Peter Kjellerstedt wrote:
> > -----Original Message-----
> > From: openembedded-core@lists.openembedded.org <openembedded-
> > core@lists.openembedded.org> On Behalf Of Robert P. J. Day
> > Sent: den 18 april 2020 19:24
> > To: chris.laplante@agilent.com
> > Cc: Richard Purdie <richard.purdie@linuxfoundation.org>; OE Core mailing
> > list <openembedded-core@lists.openembedded.org>
> > Subject: Re: [OE-core] why does oe-buildenv-internal check for -z
> > "$BDIR"?
> >
> > On Sat, 18 Apr 2020, chris.laplante@agilent.com wrote:
> >
> > > > i know that -- in fact, it's the only way i use it -- the question
> > > > is the purpose for checking if $BDIR is zero length first. that is,
> > > > under what circumstances could it *not* be? even invoking the way you
> > > > demonstrate, that variable is empty when tested, and i see nothing
> > > > that could cause it to have a value before that test.
> > >
> > > FWIW I was curious/bored and looked to see if 'BDIR' was ever used
> > > in poky (outside of the script of course), and I found no results.
> > >
> > > git rev-list --all | xargs git grep -w BDIR -- './*' ':!scripts/oe-
> > buildenv-internal'
> >
> > that's kind of the point i was making ... that variable appeared out
> > of nowhere, clearly seemed like a local variable, and is even "unset"
> > after it's used in that script. i poked around, trying to figure if
> > there was some other flow of control that got you into that script
> > from another direction, but i didn't find one.
> >
> > and, yes, it seems trivial to obsess over it, but it's just those
> > sorts of things that make me wonder, "hmmmmm ... maybe i *don't*
> > really understand how this script can be used."
> >
> > anyway, moving on ...
> >
> > rday
>
> When it comes to understanding why the code looks like it does in a
> case like this, it is often better to look at the history than the
> current state.
>
> If you go back to when the test was introduced (commit
> 5d5fab77cf9616bf62023c202b38f309f8bbf189 in Poky), you will see that
> BDIR could be set in a script called poky-autobuild at that time.
> The poky-autobuild script was removed 12 years ago, but the test in
> oe-buildenv-internal remained.
i did a (cursory) check of history; obviously, i did not look
closely enough. my bad.
rday
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [OE-core] why does oe-buildenv-internal check for -z "$BDIR"?
2020-04-18 18:45 ` Peter Kjellerstedt
2020-04-18 18:55 ` Robert P. J. Day
@ 2020-04-18 20:10 ` Robert P. J. Day
2020-04-18 22:13 ` Christopher Larson
1 sibling, 1 reply; 13+ messages in thread
From: Robert P. J. Day @ 2020-04-18 20:10 UTC (permalink / raw
To: Peter Kjellerstedt
Cc: chris.laplante@agilent.com, Richard Purdie, OE Core mailing list
On Sat, 18 Apr 2020, Peter Kjellerstedt wrote:
> > -----Original Message-----
> > From: openembedded-core@lists.openembedded.org <openembedded-
> > core@lists.openembedded.org> On Behalf Of Robert P. J. Day
> > Sent: den 18 april 2020 19:24
> > To: chris.laplante@agilent.com
> > Cc: Richard Purdie <richard.purdie@linuxfoundation.org>; OE Core mailing
> > list <openembedded-core@lists.openembedded.org>
> > Subject: Re: [OE-core] why does oe-buildenv-internal check for -z
> > "$BDIR"?
> >
> > On Sat, 18 Apr 2020, chris.laplante@agilent.com wrote:
> >
> > > > i know that -- in fact, it's the only way i use it -- the question
> > > > is the purpose for checking if $BDIR is zero length first. that is,
> > > > under what circumstances could it *not* be? even invoking the way you
> > > > demonstrate, that variable is empty when tested, and i see nothing
> > > > that could cause it to have a value before that test.
> > >
> > > FWIW I was curious/bored and looked to see if 'BDIR' was ever used
> > > in poky (outside of the script of course), and I found no results.
> > >
> > > git rev-list --all | xargs git grep -w BDIR -- './*' ':!scripts/oe-
> > buildenv-internal'
> >
> > that's kind of the point i was making ... that variable appeared out
> > of nowhere, clearly seemed like a local variable, and is even "unset"
> > after it's used in that script. i poked around, trying to figure if
> > there was some other flow of control that got you into that script
> > from another direction, but i didn't find one.
> >
> > and, yes, it seems trivial to obsess over it, but it's just those
> > sorts of things that make me wonder, "hmmmmm ... maybe i *don't*
> > really understand how this script can be used."
> >
> > anyway, moving on ...
> >
> > rday
>
> When it comes to understanding why the code looks like it does in a
> case like this, it is often better to look at the history than the
> current state.
>
> If you go back to when the test was introduced (commit
> 5d5fab77cf9616bf62023c202b38f309f8bbf189 in Poky), you will see that
> BDIR could be set in a script called poky-autobuild at that time.
> The poky-autobuild script was removed 12 years ago, but the test in
> oe-buildenv-internal remained.
additional observation, but same script also contains:
if [ -n "$2" ]; then
BITBAKEDIR="$2"
fi
clearly implying a second argument pointing at bitbake directory,
which is nowhere documented, and is followed by:
if [ -z "$BITBAKEDIR" ]; then
BITBAKEDIR="$OEROOT/bitbake$BBEXTRA"
test -d "$BITBAKEDIR" || BITBAKEDIR="$OEROOT/../bitbake$BBEXTRA"
fi
this also seems out of date, but i won't flog it any further.
rday
p.s. no mention in ref manual of "BBEXTRA" variable ... i'll leave it
to those higher up the food chain to decide what's worth cleaning.
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [OE-core] why does oe-buildenv-internal check for -z "$BDIR"?
2020-04-18 20:10 ` Robert P. J. Day
@ 2020-04-18 22:13 ` Christopher Larson
2020-04-18 22:17 ` Robert P. J. Day
2020-04-18 22:19 ` Robert P. J. Day
0 siblings, 2 replies; 13+ messages in thread
From: Christopher Larson @ 2020-04-18 22:13 UTC (permalink / raw
To: Peter Kjellerstedt, Robert P. J. Day
Cc: chris.laplante@agilent.com, Richard Purdie, OE Core mailing list
[-- Attachment #1: Type: text/plain, Size: 3430 bytes --]
On Apr 18, 2020, 1:10 PM -0700, Robert P. J. Day <rpjday@crashcourse.ca>, wrote:
> On Sat, 18 Apr 2020, Peter Kjellerstedt wrote:
>
> > > -----Original Message-----
> > > From: openembedded-core@lists.openembedded.org <openembedded-
> > > core@lists.openembedded.org> On Behalf Of Robert P. J. Day
> > > Sent: den 18 april 2020 19:24
> > > To: chris.laplante@agilent.com
> > > Cc: Richard Purdie <richard.purdie@linuxfoundation.org>; OE Core mailing
> > > list <openembedded-core@lists.openembedded.org>
> > > Subject: Re: [OE-core] why does oe-buildenv-internal check for -z
> > > "$BDIR"?
> > >
> > > On Sat, 18 Apr 2020, chris.laplante@agilent.com wrote:
> > >
> > > > > i know that -- in fact, it's the only way i use it -- the question
> > > > > is the purpose for checking if $BDIR is zero length first. that is,
> > > > > under what circumstances could it *not* be? even invoking the way you
> > > > > demonstrate, that variable is empty when tested, and i see nothing
> > > > > that could cause it to have a value before that test.
> > > >
> > > > FWIW I was curious/bored and looked to see if 'BDIR' was ever used
> > > > in poky (outside of the script of course), and I found no results.
> > > >
> > > > git rev-list --all | xargs git grep -w BDIR -- './*' ':!scripts/oe-
> > > buildenv-internal'
> > >
> > > that's kind of the point i was making ... that variable appeared out
> > > of nowhere, clearly seemed like a local variable, and is even "unset"
> > > after it's used in that script. i poked around, trying to figure if
> > > there was some other flow of control that got you into that script
> > > from another direction, but i didn't find one.
> > >
> > > and, yes, it seems trivial to obsess over it, but it's just those
> > > sorts of things that make me wonder, "hmmmmm ... maybe i *don't*
> > > really understand how this script can be used."
> > >
> > > anyway, moving on ...
> > >
> > > rday
> >
> > When it comes to understanding why the code looks like it does in a
> > case like this, it is often better to look at the history than the
> > current state.
> >
> > If you go back to when the test was introduced (commit
> > 5d5fab77cf9616bf62023c202b38f309f8bbf189 in Poky), you will see that
> > BDIR could be set in a script called poky-autobuild at that time.
> > The poky-autobuild script was removed 12 years ago, but the test in
> > oe-buildenv-internal remained.
>
> additional observation, but same script also contains:
>
> if [ -n "$2" ]; then
> BITBAKEDIR="$2"
> fi
>
> clearly implying a second argument pointing at bitbake directory,
> which is nowhere documented, and is followed by:
>
> if [ -z "$BITBAKEDIR" ]; then
> BITBAKEDIR="$OEROOT/bitbake$BBEXTRA"
> test -d "$BITBAKEDIR" || BITBAKEDIR="$OEROOT/../bitbake$BBEXTRA"
> fi
>
> this also seems out of date, but i won't flog it any further.
I don’t think this is out of date. It’s allowing the user to specify the path to bitbake (which I’ve done in unusual layouts or just to be explicit), falling back to either under OEROOT (poky-style) or in its parent (more typical).
It’s also worth noting that oe-init-build-env and oe-buildenv-internal are not just used directly, but many other setup scripts build on top of them, so this particular flexibility is useful. BDIR still seems like it can be dropped regardless of the BITBAKEDIR logic.
-Chris
[-- Attachment #2: Type: text/html, Size: 4517 bytes --]
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [OE-core] why does oe-buildenv-internal check for -z "$BDIR"?
2020-04-18 22:13 ` Christopher Larson
@ 2020-04-18 22:17 ` Robert P. J. Day
2020-04-18 23:39 ` Richard Purdie
2020-04-18 22:19 ` Robert P. J. Day
1 sibling, 1 reply; 13+ messages in thread
From: Robert P. J. Day @ 2020-04-18 22:17 UTC (permalink / raw
To: Christopher Larson
Cc: Peter Kjellerstedt, chris.laplante@agilent.com, Richard Purdie,
OE Core mailing list
[-- Attachment #1: Type: text/plain, Size: 4581 bytes --]
On Sat, 18 Apr 2020, Christopher Larson wrote:
> On Apr 18, 2020, 1:10 PM -0700, Robert P. J. Day <rpjday@crashcourse.ca>, wrote:
> On Sat, 18 Apr 2020, Peter Kjellerstedt wrote:
>
> -----Original Message-----
> From: openembedded-core@lists.openembedded.org <openembedded-
> core@lists.openembedded.org> On Behalf Of Robert P. J. Day
> Sent: den 18 april 2020 19:24
> To: chris.laplante@agilent.com
> Cc: Richard Purdie <richard.purdie@linuxfoundation.org>; OE Core mailing
> list <openembedded-core@lists.openembedded.org>
> Subject: Re: [OE-core] why does oe-buildenv-internal check for -z
> "$BDIR"?
>
> On Sat, 18 Apr 2020, chris.laplante@agilent.com wrote:
>
> i know that -- in fact, it's the only way i use it
> -- the question
> is the purpose for checking if $BDIR is zero length
> first. that is,
> under what circumstances could it *not* be? even
> invoking the way you
> demonstrate, that variable is empty when tested,
> and i see nothing
> that could cause it to have a value before that
> test.
>
>
> FWIW I was curious/bored and looked to see if 'BDIR' was ever
> used
> in poky (outside of the script of course), and I found no
> results.
>
> git rev-list --all | xargs git grep -w BDIR -- './*'
> ':!scripts/oe-
>
> buildenv-internal'
>
> that's kind of the point i was making ... that variable appeared out
> of nowhere, clearly seemed like a local variable, and is even "unset"
> after it's used in that script. i poked around, trying to figure if
> there was some other flow of control that got you into that script
> from another direction, but i didn't find one.
>
> and, yes, it seems trivial to obsess over it, but it's just those
> sorts of things that make me wonder, "hmmmmm ... maybe i *don't*
> really understand how this script can be used."
>
> anyway, moving on ...
>
> rday
>
>
> When it comes to understanding why the code looks like it does in a
> case like this, it is often better to look at the history than the
> current state.
>
> If you go back to when the test was introduced (commit
> 5d5fab77cf9616bf62023c202b38f309f8bbf189 in Poky), you will see that
> BDIR could be set in a script called poky-autobuild at that time.
> The poky-autobuild script was removed 12 years ago, but the test in
> oe-buildenv-internal remained.
>
>
> additional observation, but same script also contains:
>
> if [ -n "$2" ]; then
> BITBAKEDIR="$2"
> fi
>
> clearly implying a second argument pointing at bitbake directory,
> which is nowhere documented, and is followed by:
>
> if [ -z "$BITBAKEDIR" ]; then
> BITBAKEDIR="$OEROOT/bitbake$BBEXTRA"
> test -d "$BITBAKEDIR" || BITBAKEDIR="$OEROOT/../bitbake$BBEXTRA"
> fi
>
> this also seems out of date, but i won't flog it any further.
>
>
>
> I don’t think this is out of date. It’s allowing the user to specify
> the path to bitbake (which I’ve done in unusual layouts or just to
> be explicit), falling back to either under OEROOT (poky-style) or in
> its parent (more typical).
>
> It’s also worth noting that oe-init-build-env and
> oe-buildenv-internal are not just used directly, but many other
> setup scripts build on top of them, so this particular flexibility
> is useful. BDIR still seems like it can be dropped regardless of the
> BITBAKEDIR logic.
that actually matches with what i concluded -- BDIR is dead and
gone, but i realized that BITBAKEDIR could still be useful, even if
it's currently undocumented. so i'll submit a patch to ditch BDIR, and
leave all else as is. for now.
rday
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [OE-core] why does oe-buildenv-internal check for -z "$BDIR"?
2020-04-18 22:13 ` Christopher Larson
2020-04-18 22:17 ` Robert P. J. Day
@ 2020-04-18 22:19 ` Robert P. J. Day
1 sibling, 0 replies; 13+ messages in thread
From: Robert P. J. Day @ 2020-04-18 22:19 UTC (permalink / raw
To: Christopher Larson
Cc: Peter Kjellerstedt, chris.laplante@agilent.com, Richard Purdie,
OE Core mailing list
[-- Attachment #1: Type: text/plain, Size: 691 bytes --]
On Sat, 18 Apr 2020, Christopher Larson wrote:
> I don’t think this is out of date. It’s allowing the user to specify
> the path to bitbake (which I’ve done in unusual layouts or just to
> be explicit), falling back to either under OEROOT (poky-style) or in
> its parent (more typical).
>
> It’s also worth noting that oe-init-build-env and
> oe-buildenv-internal are not just used directly, but many other
> setup scripts build on top of them, so this particular flexibility
> is useful. BDIR still seems like it can be dropped regardless of the
> BITBAKEDIR logic.
so if BBEXTRA is still valid, should it be documented, perhaps in
the variable glossary?
rday
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [OE-core] why does oe-buildenv-internal check for -z "$BDIR"?
2020-04-18 22:17 ` Robert P. J. Day
@ 2020-04-18 23:39 ` Richard Purdie
2020-04-19 13:11 ` Robert P. J. Day
0 siblings, 1 reply; 13+ messages in thread
From: Richard Purdie @ 2020-04-18 23:39 UTC (permalink / raw
To: Robert P. J. Day, Christopher Larson
Cc: Peter Kjellerstedt, chris.laplante@agilent.com,
OE Core mailing list
On Sat, 2020-04-18 at 18:17 -0400, Robert P. J. Day wrote:
> that actually matches with what i concluded -- BDIR is dead and
> gone, but i realized that BITBAKEDIR could still be useful, even if
> it's currently undocumented. so i'll submit a patch to ditch BDIR,
> and leave all else as is. for now.
BDIR allows the build directory to be set explicitly from a script
without worrying about which shell is in use.
I'd note it is used by scripts/build-perf-test-wrapper in yocto-
autobuilder-helper, probably for exactly this reason (I've not checked
the history).
Cheers,
Richard
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [OE-core] why does oe-buildenv-internal check for -z "$BDIR"?
2020-04-18 23:39 ` Richard Purdie
@ 2020-04-19 13:11 ` Robert P. J. Day
0 siblings, 0 replies; 13+ messages in thread
From: Robert P. J. Day @ 2020-04-19 13:11 UTC (permalink / raw
To: Richard Purdie
Cc: Christopher Larson, Peter Kjellerstedt,
chris.laplante@agilent.com, OE Core mailing list
On Sun, 19 Apr 2020, Richard Purdie wrote:
> On Sat, 2020-04-18 at 18:17 -0400, Robert P. J. Day wrote:
> > that actually matches with what i concluded -- BDIR is dead and
> > gone, but i realized that BITBAKEDIR could still be useful, even
> > if it's currently undocumented. so i'll submit a patch to ditch
> > BDIR, and leave all else as is. for now.
>
> BDIR allows the build directory to be set explicitly from a script
> without worrying about which shell is in use.
i believe you, and i actually went specifically *looking* for
something that did that, but didn't find it.
> I'd note it is used by scripts/build-perf-test-wrapper in yocto-
> autobuilder-helper, probably for exactly this reason (I've not
> checked the history).
and that's the snippet of info i was after ... that *something*
takes advantage of that feature. ok, i'm happy now. :-)
rday
^ permalink raw reply [flat|nested] 13+ messages in thread
end of thread, other threads:[~2020-04-19 13:12 UTC | newest]
Thread overview: 13+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2020-04-18 16:04 why does oe-buildenv-internal check for -z "$BDIR"? Robert P. J. Day
2020-04-18 16:30 ` [OE-core] " Richard Purdie
2020-04-18 16:43 ` Robert P. J. Day
2020-04-18 17:08 ` Chris Laplante
2020-04-18 17:23 ` Robert P. J. Day
2020-04-18 18:45 ` Peter Kjellerstedt
2020-04-18 18:55 ` Robert P. J. Day
2020-04-18 20:10 ` Robert P. J. Day
2020-04-18 22:13 ` Christopher Larson
2020-04-18 22:17 ` Robert P. J. Day
2020-04-18 23:39 ` Richard Purdie
2020-04-19 13:11 ` Robert P. J. Day
2020-04-18 22:19 ` Robert P. J. Day
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.