From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:59275)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <keith.busch@intel.com>) id 1Z5xgU-00030k-Nw
	for qemu-devel@nongnu.org; Fri, 19 Jun 2015 10:54:23 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <keith.busch@intel.com>) id 1Z5xgR-0004j8-FF
	for qemu-devel@nongnu.org; Fri, 19 Jun 2015 10:54:22 -0400
Received: from mga09.intel.com ([134.134.136.24]:51651)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <keith.busch@intel.com>) id 1Z5xgR-0004hc-AS
	for qemu-devel@nongnu.org; Fri, 19 Jun 2015 10:54:19 -0400
Date: Fri, 19 Jun 2015 14:54:16 +0000 (UTC)
From: Keith Busch <keith.busch@intel.com>
In-Reply-To: <20150619125727.GB18007@stefanha-thinkpad.redhat.com>
Message-ID: <alpine.LNX.2.00.1506191453110.15930@localhost.lm.intel.com>
References: <1434695254-69808-1-git-send-email-kathy.wangting@huawei.com>
	<20150619125727.GB18007@stefanha-thinkpad.redhat.com>
MIME-Version: 1.0
Content-Type: TEXT/PLAIN; charset=US-ASCII; format=flowed
Subject: Re: [Qemu-devel] [PATCH] nvme: Fix memleak in nvme_dma_read_prp
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Stefan Hajnoczi <stefanha@gmail.com>
Cc: Keith Busch <keith.busch@intel.com>, Lu Lina <lina.lulina@huawei.com>, qemu-devel@nongnu.org, Ting Wang <kathy.wangting@huawei.com>

On Fri, 19 Jun 2015, Stefan Hajnoczi wrote:
>> From: Lu Lina <lina.lulina@huawei.com>
>>
>> Signed-off-by: Lu Lina <lina.lulina@huawei.com>

Thanks for the fix.

Acked-by: Keith Busch <keith.busch@intel.com>

>> @@ -154,6 +154,7 @@ static uint16_t nvme_dma_read_prp(NvmeCtrl *n, uint8_t *ptr, uint32_t len,
>>          qemu_sglist_destroy(&qsg);
>>          return NVME_INVALID_FIELD | NVME_DNR;
>>      }
>> +    qemu_sglist_destroy(&qsg);
>>      return NVME_SUCCESS;
>>  }