From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id B2554C00144 for ; Mon, 1 Aug 2022 15:21:00 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233706AbiHAPU7 (ORCPT ); Mon, 1 Aug 2022 11:20:59 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55402 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233520AbiHAPUp (ORCPT ); Mon, 1 Aug 2022 11:20:45 -0400 Received: from alexa-out-sd-02.qualcomm.com (alexa-out-sd-02.qualcomm.com [199.106.114.39]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A63AFB49A; Mon, 1 Aug 2022 08:20:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=quicinc.com; i=@quicinc.com; q=dns/txt; s=qcdkim; t=1659367243; x=1690903243; h=message-id:date:mime-version:subject:to:cc:references: from:in-reply-to:content-transfer-encoding; bh=2DXcIe7hUnldJ+7bWfHGOv4iXtFwQUzM3UzzWrBzOUs=; b=tI8cjlW8Dnw6seHPjRh0QMTaVhs4p0V1EPvNf57/SbmeXPMSF4vgSoFK vgwjo0/jF3+Ll8ne42heV07x6cq2lOH47r3Jj1hgr6ohm+laI8rXLjQae 7EELxaMcb8KwJoqrziw0K4iu7duZhMjTzvYUDHWyTqxdkb07taFoCKKG6 o=; Received: from unknown (HELO ironmsg04-sd.qualcomm.com) ([10.53.140.144]) by alexa-out-sd-02.qualcomm.com with ESMTP; 01 Aug 2022 08:20:43 -0700 X-QCInternal: smtphost Received: from nasanex01c.na.qualcomm.com ([10.47.97.222]) by ironmsg04-sd.qualcomm.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 01 Aug 2022 08:20:42 -0700 Received: from nalasex01a.na.qualcomm.com (10.47.209.196) by nasanex01c.na.qualcomm.com (10.47.97.222) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.22; Mon, 1 Aug 2022 08:20:42 -0700 Received: from [10.216.14.65] (10.80.80.8) by nalasex01a.na.qualcomm.com (10.47.209.196) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.22; Mon, 1 Aug 2022 08:20:35 -0700 Message-ID: Date: Mon, 1 Aug 2022 20:50:29 +0530 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.3.2 Subject: Re: [Freedreno] [PATCH 2/5] clk: qcom: Allow custom reset ops Content-Language: en-US To: kernel test robot , freedreno , , , Rob Clark , "Bjorn Andersson" , Stephen Boyd CC: , Michael Turquette , Konrad Dybcio , Douglas Anderson , , Andy Gross , References: <20220730144713.2.I4b69f984a97535179acd9637426a1331f84f6646@changeid> <202207302137.mPbHPaHz-lkp@intel.com> From: Akhil P Oommen In-Reply-To: <202207302137.mPbHPaHz-lkp@intel.com> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [10.80.80.8] X-ClientProxiedBy: nasanex01b.na.qualcomm.com (10.46.141.250) To nalasex01a.na.qualcomm.com (10.47.209.196) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 7/30/2022 6:40 PM, kernel test robot wrote: > Hi Akhil, > > Thank you for the patch! Perhaps something to improve: > > [auto build test WARNING on clk/clk-next] > [also build test WARNING on robh/for-next drm-misc/drm-misc-next drm-tip/drm-tip linus/master v5.19-rc8 next-20220728] > [If your patch is applied to the wrong git tree, kindly drop us a note. > And when submitting patch, we suggest to use '--base' as documented in > https://git-scm.com/docs/git-format-patch#_base_tree_information] > > url: https://github.com/intel-lab-lkp/linux/commits/Akhil-P-Oommen/clk-qcom-Support-gdsc-collapse-polling-using-reset-inteface/20220730-171922 > base: https://git.kernel.org/pub/scm/linux/kernel/git/clk/linux.git clk-next > config: ia64-randconfig-r031-20220729 (https://download.01.org/0day-ci/archive/20220730/202207302137.mPbHPaHz-lkp@intel.com/config) > compiler: ia64-linux-gcc (GCC) 12.1.0 > reproduce (this is a W=1 build): > wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross > chmod +x ~/bin/make.cross > # https://github.com/intel-lab-lkp/linux/commit/971a03493e9854ff4a227ee4d80b533997959891 > git remote add linux-review https://github.com/intel-lab-lkp/linux > git fetch --no-tags linux-review Akhil-P-Oommen/clk-qcom-Support-gdsc-collapse-polling-using-reset-inteface/20220730-171922 > git checkout 971a03493e9854ff4a227ee4d80b533997959891 > # save the config file > mkdir build_dir && cp config build_dir/.config > COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-12.1.0 make.cross W=1 O=build_dir ARCH=ia64 SHELL=/bin/bash drivers/clk/qcom/ > > If you fix the issue, kindly add following tag where applicable > Reported-by: kernel test robot > > All warnings (new ones prefixed by >>): > > drivers/clk/qcom/reset.c: In function 'qcom_reset': >>> drivers/clk/qcom/reset.c:17:9: warning: ISO C90 forbids mixed declarations and code [-Wdeclaration-after-statement] > 17 | const struct qcom_reset_map *map = &rst->reset_map[id]; > | ^~~~~ > > > vim +17 drivers/clk/qcom/reset.c > > 13 > 14 static int qcom_reset(struct reset_controller_dev *rcdev, unsigned long id) > 15 { > 16 struct qcom_reset_controller *rst = to_qcom_reset_controller(rcdev); > > 17 const struct qcom_reset_map *map = &rst->reset_map[id]; > 18 > 19 if (map->op) > 20 return map->op(map); > 21 > 22 rcdev->ops->assert(rcdev, id); > 23 udelay(1); > 24 rcdev->ops->deassert(rcdev, id); > 25 return 0; > 26 } > 27 > Will fix this and send another version of this patch. Please let me know if there is any feedback to the whole series. -Akhil. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 949B9C19F2A for ; Mon, 1 Aug 2022 15:20:59 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 947D290465; Mon, 1 Aug 2022 15:20:53 +0000 (UTC) Received: from alexa-out-sd-01.qualcomm.com (alexa-out-sd-01.qualcomm.com [199.106.114.38]) by gabe.freedesktop.org (Postfix) with ESMTPS id E10398F579; Mon, 1 Aug 2022 15:20:43 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=quicinc.com; i=@quicinc.com; q=dns/txt; s=qcdkim; t=1659367244; x=1690903244; h=message-id:date:mime-version:subject:to:cc:references: from:in-reply-to:content-transfer-encoding; bh=2DXcIe7hUnldJ+7bWfHGOv4iXtFwQUzM3UzzWrBzOUs=; b=yZ4GimpjRY+D5M1e5o39grHkSvXksZRDmEE99Zlt3FQyd4ynxwphp+mm JSstcFeTghu8ei6mLqZcqraaepeEPHPfaDSOdk9+FhcoqE7bor49WbLYJ W74TbtKk6eSr4Iv8ZfEy1SwFkh5mXDhhiKkBJnRliQwQ449yD83JgW7+M I=; Received: from unknown (HELO ironmsg04-sd.qualcomm.com) ([10.53.140.144]) by alexa-out-sd-01.qualcomm.com with ESMTP; 01 Aug 2022 08:20:43 -0700 X-QCInternal: smtphost Received: from nasanex01c.na.qualcomm.com ([10.47.97.222]) by ironmsg04-sd.qualcomm.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 01 Aug 2022 08:20:42 -0700 Received: from nalasex01a.na.qualcomm.com (10.47.209.196) by nasanex01c.na.qualcomm.com (10.47.97.222) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.22; Mon, 1 Aug 2022 08:20:42 -0700 Received: from [10.216.14.65] (10.80.80.8) by nalasex01a.na.qualcomm.com (10.47.209.196) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.22; Mon, 1 Aug 2022 08:20:35 -0700 Message-ID: Date: Mon, 1 Aug 2022 20:50:29 +0530 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.3.2 Subject: Re: [Freedreno] [PATCH 2/5] clk: qcom: Allow custom reset ops Content-Language: en-US To: kernel test robot , freedreno , , , Rob Clark , "Bjorn Andersson" , Stephen Boyd References: <20220730144713.2.I4b69f984a97535179acd9637426a1331f84f6646@changeid> <202207302137.mPbHPaHz-lkp@intel.com> From: Akhil P Oommen In-Reply-To: <202207302137.mPbHPaHz-lkp@intel.com> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [10.80.80.8] X-ClientProxiedBy: nasanex01b.na.qualcomm.com (10.46.141.250) To nalasex01a.na.qualcomm.com (10.47.209.196) X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: kbuild-all@lists.01.org, Michael Turquette , Konrad Dybcio , Douglas Anderson , linux-kernel@vger.kernel.org, Andy Gross , linux-clk@vger.kernel.org Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On 7/30/2022 6:40 PM, kernel test robot wrote: > Hi Akhil, > > Thank you for the patch! Perhaps something to improve: > > [auto build test WARNING on clk/clk-next] > [also build test WARNING on robh/for-next drm-misc/drm-misc-next drm-tip/drm-tip linus/master v5.19-rc8 next-20220728] > [If your patch is applied to the wrong git tree, kindly drop us a note. > And when submitting patch, we suggest to use '--base' as documented in > https://git-scm.com/docs/git-format-patch#_base_tree_information] > > url: https://github.com/intel-lab-lkp/linux/commits/Akhil-P-Oommen/clk-qcom-Support-gdsc-collapse-polling-using-reset-inteface/20220730-171922 > base: https://git.kernel.org/pub/scm/linux/kernel/git/clk/linux.git clk-next > config: ia64-randconfig-r031-20220729 (https://download.01.org/0day-ci/archive/20220730/202207302137.mPbHPaHz-lkp@intel.com/config) > compiler: ia64-linux-gcc (GCC) 12.1.0 > reproduce (this is a W=1 build): > wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross > chmod +x ~/bin/make.cross > # https://github.com/intel-lab-lkp/linux/commit/971a03493e9854ff4a227ee4d80b533997959891 > git remote add linux-review https://github.com/intel-lab-lkp/linux > git fetch --no-tags linux-review Akhil-P-Oommen/clk-qcom-Support-gdsc-collapse-polling-using-reset-inteface/20220730-171922 > git checkout 971a03493e9854ff4a227ee4d80b533997959891 > # save the config file > mkdir build_dir && cp config build_dir/.config > COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-12.1.0 make.cross W=1 O=build_dir ARCH=ia64 SHELL=/bin/bash drivers/clk/qcom/ > > If you fix the issue, kindly add following tag where applicable > Reported-by: kernel test robot > > All warnings (new ones prefixed by >>): > > drivers/clk/qcom/reset.c: In function 'qcom_reset': >>> drivers/clk/qcom/reset.c:17:9: warning: ISO C90 forbids mixed declarations and code [-Wdeclaration-after-statement] > 17 | const struct qcom_reset_map *map = &rst->reset_map[id]; > | ^~~~~ > > > vim +17 drivers/clk/qcom/reset.c > > 13 > 14 static int qcom_reset(struct reset_controller_dev *rcdev, unsigned long id) > 15 { > 16 struct qcom_reset_controller *rst = to_qcom_reset_controller(rcdev); > > 17 const struct qcom_reset_map *map = &rst->reset_map[id]; > 18 > 19 if (map->op) > 20 return map->op(map); > 21 > 22 rcdev->ops->assert(rcdev, id); > 23 udelay(1); > 24 rcdev->ops->deassert(rcdev, id); > 25 return 0; > 26 } > 27 > Will fix this and send another version of this patch. Please let me know if there is any feedback to the whole series. -Akhil. From mboxrd@z Thu Jan 1 00:00:00 1970 Content-Type: multipart/mixed; boundary="===============7695933091230028693==" MIME-Version: 1.0 From: Akhil P Oommen To: kbuild-all@lists.01.org Subject: Re: [Freedreno] [PATCH 2/5] clk: qcom: Allow custom reset ops Date: Mon, 01 Aug 2022 20:50:29 +0530 Message-ID: In-Reply-To: <202207302137.mPbHPaHz-lkp@intel.com> List-Id: --===============7695933091230028693== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable On 7/30/2022 6:40 PM, kernel test robot wrote: > Hi Akhil, > > Thank you for the patch! Perhaps something to improve: > > [auto build test WARNING on clk/clk-next] > [also build test WARNING on robh/for-next drm-misc/drm-misc-next drm-tip/= drm-tip linus/master v5.19-rc8 next-20220728] > [If your patch is applied to the wrong git tree, kindly drop us a note. > And when submitting patch, we suggest to use '--base' as documented in > https://git-scm.com/docs/git-format-patch#_base_tree_information] > > url: https://github.com/intel-lab-lkp/linux/commits/Akhil-P-Oommen/clk= -qcom-Support-gdsc-collapse-polling-using-reset-inteface/20220730-171922 > base: https://git.kernel.org/pub/scm/linux/kernel/git/clk/linux.git clk= -next > config: ia64-randconfig-r031-20220729 (https://download.01.org/0day-ci/ar= chive/20220730/202207302137.mPbHPaHz-lkp(a)intel.com/config) > compiler: ia64-linux-gcc (GCC) 12.1.0 > reproduce (this is a W=3D1 build): > wget https://raw.githubusercontent.com/intel/lkp-tests/master/sb= in/make.cross -O ~/bin/make.cross > chmod +x ~/bin/make.cross > # https://github.com/intel-lab-lkp/linux/commit/971a03493e9854ff= 4a227ee4d80b533997959891 > git remote add linux-review https://github.com/intel-lab-lkp/lin= ux > git fetch --no-tags linux-review Akhil-P-Oommen/clk-qcom-Support= -gdsc-collapse-polling-using-reset-inteface/20220730-171922 > git checkout 971a03493e9854ff4a227ee4d80b533997959891 > # save the config file > mkdir build_dir && cp config build_dir/.config > COMPILER_INSTALL_PATH=3D$HOME/0day COMPILER=3Dgcc-12.1.0 make.cr= oss W=3D1 O=3Dbuild_dir ARCH=3Dia64 SHELL=3D/bin/bash drivers/clk/qcom/ > > If you fix the issue, kindly add following tag where applicable > Reported-by: kernel test robot > > All warnings (new ones prefixed by >>): > > drivers/clk/qcom/reset.c: In function 'qcom_reset': >>> drivers/clk/qcom/reset.c:17:9: warning: ISO C90 forbids mixed declarati= ons and code [-Wdeclaration-after-statement] > 17 | const struct qcom_reset_map *map =3D &rst->reset_map[= id]; > | ^~~~~ > > > vim +17 drivers/clk/qcom/reset.c > > 13 = > 14 static int qcom_reset(struct reset_controller_dev *rcdev, unsigne= d long id) > 15 { > 16 struct qcom_reset_controller *rst =3D to_qcom_reset_controller(r= cdev); > > 17 const struct qcom_reset_map *map =3D &rst->reset_map[id]; > 18 = > 19 if (map->op) > 20 return map->op(map); > 21 = > 22 rcdev->ops->assert(rcdev, id); > 23 udelay(1); > 24 rcdev->ops->deassert(rcdev, id); > 25 return 0; > 26 } > 27 = > Will fix this and send another version of this patch. Please let me know = if there is any feedback to the whole series. -Akhil. --===============7695933091230028693==--