From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.5 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CF61AC2B9F4 for ; Thu, 17 Jun 2021 17:48:16 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 9B7B5613CE for ; Thu, 17 Jun 2021 17:48:16 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232645AbhFQRuW (ORCPT ); Thu, 17 Jun 2021 13:50:22 -0400 Received: from foss.arm.com ([217.140.110.172]:57196 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231249AbhFQRuV (ORCPT ); Thu, 17 Jun 2021 13:50:21 -0400 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 771F513D5; Thu, 17 Jun 2021 10:48:13 -0700 (PDT) Received: from [10.57.9.136] (unknown [10.57.9.136]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id A1CF13F694; Thu, 17 Jun 2021 10:48:12 -0700 (PDT) Subject: Re: [PATCH] perf/arm-cmn: Fix invalid pointer when access dtc object sharing the same IRQ number To: Tuan Phan Cc: Will Deacon , Mark Rutland , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org References: <1623946129-3290-1-git-send-email-tuanphan@os.amperecomputing.com> From: Robin Murphy Message-ID: Date: Thu, 17 Jun 2021 18:48:06 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; rv:78.0) Gecko/20100101 Thunderbird/78.10.1 MIME-Version: 1.0 In-Reply-To: <1623946129-3290-1-git-send-email-tuanphan@os.amperecomputing.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-GB Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2021-06-17 17:08, Tuan Phan wrote: > When multiple dtcs share the same IRQ number, the irq_friend which > used to refer to dtc object gets calculated incorrect which leads > to invalid pointer. Oops, indeed this is supposed to be a forward offset *from* the previous match *to* the current dtc. It's almost as if I never managed to test it... :) Reviewed-by: Robin Murphy > Fixes: 0ba64770a2f2 ("perf: Add Arm CMN-600 PMU driver") > > Signed-off-by: Tuan Phan > --- > drivers/perf/arm-cmn.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/perf/arm-cmn.c b/drivers/perf/arm-cmn.c > index 56a5c35..49016f2 100644 > --- a/drivers/perf/arm-cmn.c > +++ b/drivers/perf/arm-cmn.c > @@ -1212,7 +1212,7 @@ static int arm_cmn_init_irqs(struct arm_cmn *cmn) > irq = cmn->dtc[i].irq; > for (j = i; j--; ) { > if (cmn->dtc[j].irq == irq) { > - cmn->dtc[j].irq_friend = j - i; > + cmn->dtc[j].irq_friend = i - j; > goto next; > } > } > From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.7 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 54DAEC2B9F4 for ; Thu, 17 Jun 2021 17:49:50 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 1392C613CB for ; Thu, 17 Jun 2021 17:49:50 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 1392C613CB Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=arm.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: Content-Transfer-Encoding:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date:Message-ID:From: References:Cc:To:Subject:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=WUrTfza50+cpZKKolgmaqloASAYqiE3jO1VxY4tIhSE=; b=FnA2E0q/oEg5ZT0TFItTua3G9H +o44yo52CdqqpROuE7WBOse+iOSF4NDMoRaUW27JBTv+KCGwh20HLW8c9Ubh64PJs8/7/nAySHQmE NVu9ze/jkR0Dbw9F59lvS0pAfDV8H/5NIZYtDoj3Su/bEV19PvTw1WaHzV+AZ16DA2Bfywd0X7ddJ A9ejoaJeYN/8AswIRqETAL5w2mqYHQAhhYZj6kMas+W1GgVKVrlcCALk0lXEF5BV+8RZTPoj3CpYh xIWQCo0nxpZ39elQlB3C2C90i2EzlAY8cY/mx0a4DUh3JU0mUBfuIOdpZwTuZtCBXxpkeZAThFpRd A7dFX7vA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1ltw7p-00BHGh-Fp; Thu, 17 Jun 2021 17:48:21 +0000 Received: from foss.arm.com ([217.140.110.172]) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1ltw7l-00BHG3-TN for linux-arm-kernel@lists.infradead.org; Thu, 17 Jun 2021 17:48:19 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 771F513D5; Thu, 17 Jun 2021 10:48:13 -0700 (PDT) Received: from [10.57.9.136] (unknown [10.57.9.136]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id A1CF13F694; Thu, 17 Jun 2021 10:48:12 -0700 (PDT) Subject: Re: [PATCH] perf/arm-cmn: Fix invalid pointer when access dtc object sharing the same IRQ number To: Tuan Phan Cc: Will Deacon , Mark Rutland , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org References: <1623946129-3290-1-git-send-email-tuanphan@os.amperecomputing.com> From: Robin Murphy Message-ID: Date: Thu, 17 Jun 2021 18:48:06 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; rv:78.0) Gecko/20100101 Thunderbird/78.10.1 MIME-Version: 1.0 In-Reply-To: <1623946129-3290-1-git-send-email-tuanphan@os.amperecomputing.com> Content-Language: en-GB X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210617_104818_049284_1C146043 X-CRM114-Status: GOOD ( 17.64 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 2021-06-17 17:08, Tuan Phan wrote: > When multiple dtcs share the same IRQ number, the irq_friend which > used to refer to dtc object gets calculated incorrect which leads > to invalid pointer. Oops, indeed this is supposed to be a forward offset *from* the previous match *to* the current dtc. It's almost as if I never managed to test it... :) Reviewed-by: Robin Murphy > Fixes: 0ba64770a2f2 ("perf: Add Arm CMN-600 PMU driver") > > Signed-off-by: Tuan Phan > --- > drivers/perf/arm-cmn.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/perf/arm-cmn.c b/drivers/perf/arm-cmn.c > index 56a5c35..49016f2 100644 > --- a/drivers/perf/arm-cmn.c > +++ b/drivers/perf/arm-cmn.c > @@ -1212,7 +1212,7 @@ static int arm_cmn_init_irqs(struct arm_cmn *cmn) > irq = cmn->dtc[i].irq; > for (j = i; j--; ) { > if (cmn->dtc[j].irq == irq) { > - cmn->dtc[j].irq_friend = j - i; > + cmn->dtc[j].irq_friend = i - j; > goto next; > } > } > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel