From: Guenter Roeck <linux@roeck-us.net>
To: "Łukasz Majczak" <lma@chromium.org>
Cc: Gwendal Grignou <gwendal@chromium.org>,
Tzung-Bi Shih <tzungbi@kernel.org>,
Radoslaw Biernacki <biernacki@google.com>,
Wim Van Sebroeck <wim@linux-watchdog.org>,
Lee Jones <lee@kernel.org>, Benson Leung <bleung@chromium.org>,
Guenter Roeck <groeck@chromium.org>,
Krzysztof Kozlowski <krzk@kernel.org>,
linux-watchdog@vger.kernel.org, linux-kernel@vger.kernel.org,
chrome-platform@lists.linux.dev
Subject: Re: [PATCH v3 0/3] Introduce EC-based watchdog
Date: Fri, 19 Jan 2024 06:42:58 -0800 [thread overview]
Message-ID: <b65b46a7-c65d-49bc-a5ce-5085da2fc112@roeck-us.net> (raw)
In-Reply-To: <CAE5UKNrU9YHoCQr8HLFf9-T4-NobQ4jWtryVqq9okFz8nVezgQ@mail.gmail.com>
On 1/19/24 06:10, Łukasz Majczak wrote:
> On Fri, Jan 19, 2024 at 1:50 PM Guenter Roeck <linux@roeck-us.net> wrote:
>>
>> On 1/19/24 00:43, Lukasz Majczak wrote:
>>> Chromeos devices are equipped with the embedded controller (EC)
>>> that can be used as a watchdog. The following patches
>>> updates the structures and definitions required to
>>> communicate with EC-based watchdog and implements the
>>> driver itself.
>>>
>>> The previous version of this patch was sent here:
>>> https://patchwork.kernel.org/project/linux-watchdog/list/?series=817925
>>>
>>> Changelog
>>> V2->V3:
>>> * drop "-drv" from driver name
>>> * use format #define<space>NAME<tab>value
>>>
>>
>> I am a bit lost here. You dropped my Reviewed-by: tags, even though
>> I specifically said that they applied with those changes made.
>> Also, according to the above patch 1/3 was not changed at all.
>>
>> What else did you change that warrants dropping the tags ?
>>
>> Guenter
>>
> The "-drv" change was related to patch 2 and 3, and I have used
> "format #define<space>NAME<tab>value" only in patch 3 (as
> ec_commands.h is mixing those)
> Sorry for dropping your "Reviewed-by" tag :( I've assumed (wrong) that
> I cannot take it for granted sending V3.
From Documentation/process/submitting-patches.rst:
Both Tested-by and Reviewed-by tags, once received on mailing list from tester
or reviewer, should be added by author to the applicable patches when sending
next versions. However if the patch has changed substantially in following
version, these tags might not be applicable anymore and thus should be removed.
Usually removal of someone's Tested-by or Reviewed-by tags should be mentioned
in the patch changelog (after the '---' separator).
> Alos in such a case if there are changes in patch 2 and 3 and 1
> remains untouched shall I send only 2 and 3 in the next version ?
>
Again, from Documentation/process/submitting-patches.rst:
... the patch (series) and its description should be self-contained.
This benefits both the maintainers and reviewers. Some reviewers
probably didn't even receive earlier versions of the patch.
Note that the same document also says:
Wait for a minimum of one week before resubmitting or pinging reviewers
- possibly longer during busy times like merge windows.
I could just send another series of Reviewed-by: tags, but quite frankly
by now I am wary that you might drop those again, so I guess I'll wait
a while to see if there is another version of the series.
Guenter
next prev parent reply other threads:[~2024-01-19 14:43 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-19 8:43 [PATCH v3 0/3] Introduce EC-based watchdog Lukasz Majczak
2024-01-19 8:43 ` [PATCH v3 1/3] platform/chrome: Update binary interface for " Lukasz Majczak
2024-01-19 8:43 ` [PATCH v3 2/3] watchdog: Add ChromeOS EC-based watchdog driver Lukasz Majczak
2024-01-22 10:31 ` Krzysztof Kozlowski
2024-01-22 15:09 ` Łukasz Majczak
2024-01-19 8:43 ` [PATCH v3 3/3] mfd: cros_ec: Register EC-based watchdog subdevice Lukasz Majczak
2024-01-25 13:37 ` (subset) " Lee Jones
2024-01-25 13:55 ` Łukasz Majczak
2024-01-26 9:07 ` Lee Jones
2024-01-19 12:50 ` [PATCH v3 0/3] Introduce EC-based watchdog Guenter Roeck
2024-01-19 14:10 ` Łukasz Majczak
2024-01-19 14:42 ` Guenter Roeck [this message]
2024-01-19 14:50 ` Łukasz Majczak
2024-01-19 15:10 ` Łukasz Majczak
2024-03-25 1:54 ` patchwork-bot+chrome-platform
2024-03-25 2:13 ` patchwork-bot+chrome-platform
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b65b46a7-c65d-49bc-a5ce-5085da2fc112@roeck-us.net \
--to=linux@roeck-us.net \
--cc=biernacki@google.com \
--cc=bleung@chromium.org \
--cc=chrome-platform@lists.linux.dev \
--cc=groeck@chromium.org \
--cc=gwendal@chromium.org \
--cc=krzk@kernel.org \
--cc=lee@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-watchdog@vger.kernel.org \
--cc=lma@chromium.org \
--cc=tzungbi@kernel.org \
--cc=wim@linux-watchdog.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.