From: Andrzej Hajda <andrzej.hajda@intel.com>
To: Tapas Rana <tapas.rana@intel.com>, intel-gfx@lists.freedesktop.org
Subject: Re: [Intel-gfx] [PATCH] Fixes KW issues for NULL pointer dereference
Date: Thu, 11 Aug 2022 18:40:53 +0200 [thread overview]
Message-ID: <b6e37502-af46-38ba-20d0-07f37b28d6b4@intel.com> (raw)
In-Reply-To: <20220811112802.4167768-1-tapas.rana@intel.com>
On 11.08.2022 13:28, Tapas Rana wrote:
I guess even for trivial patches rules should be followed - subject
should describe what has changed, commit message should describe why.
> ---
> drivers/gpu/drm/i915/gem/i915_gem_ttm_move.c | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/drivers/gpu/drm/i915/gem/i915_gem_ttm_move.c b/drivers/gpu/drm/i915/gem/i915_gem_ttm_move.c
> index 9a7e50534b84..0bbf44c34cff 100644
> --- a/drivers/gpu/drm/i915/gem/i915_gem_ttm_move.c
> +++ b/drivers/gpu/drm/i915/gem/i915_gem_ttm_move.c
> @@ -435,6 +435,9 @@ i915_ttm_memcpy_work_arm(struct i915_ttm_memcpy_work *work,
> static bool i915_ttm_memcpy_allowed(struct ttm_buffer_object *bo,
> struct ttm_resource *dst_mem)
> {
> + if(!bo)
> + return NULL;
I guess it should be "return false"
Regards
Andrzej
> +
> if (i915_gem_object_needs_ccs_pages(i915_ttm_to_gem(bo)))
> return false;
>
prev parent reply other threads:[~2022-08-11 16:41 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-11 11:28 [Intel-gfx] [PATCH] Fixes KW issues for NULL pointer dereference Tapas Rana
2022-08-11 12:00 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for " Patchwork
2022-08-11 12:23 ` [Intel-gfx] ✗ Fi.CI.BAT: failure " Patchwork
2022-08-11 16:40 ` Andrzej Hajda [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b6e37502-af46-38ba-20d0-07f37b28d6b4@intel.com \
--to=andrzej.hajda@intel.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=tapas.rana@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.