From: Heinrich Schuchardt <xypron.glpk@gmx.de>
To: Simon Glass <sjg@chromium.org>
Cc: "Ilias Apalodimas" <ilias.apalodimas@linaro.org>,
"Pali Rohár" <pali@kernel.org>,
"Mark Kettenis" <mark.kettenis@xs4all.nl>,
"U-Boot Mailing List" <u-boot@lists.denx.de>,
"Tom Rini" <trini@konsulko.com>
Subject: Re: [PATCH v2 8/9] Add an option for EBBR
Date: Thu, 29 Jul 2021 02:12:19 +0200 [thread overview]
Message-ID: <b84b4121-2b81-7caf-9bdb-78a14332114f@gmx.de> (raw)
In-Reply-To: <20210702183620.1542680-5-sjg@chromium.org>
On 7/2/21 8:36 PM, Simon Glass wrote:
> Add a new Kconfig option for EBBR so that the naming is more explicit.
> Make it select EFI_LOADER which is required for EBBR to work.
>
> Copy over the same 'default' setting so that there is no change in
> which boards enable it.
>
> Signed-off-by: Simon Glass <sjg@chromium.org>
> ---
>
> Changes in v2:
> - Split out new patch to create an option for EBBR
>
> common/Kconfig.boot | 16 ++++++++++++++++
> lib/efi_loader/Kconfig | 1 -
> 2 files changed, 16 insertions(+), 1 deletion(-)
>
> diff --git a/common/Kconfig.boot b/common/Kconfig.boot
> index 89a3161f1fa..111032e1202 100644
> --- a/common/Kconfig.boot
> +++ b/common/Kconfig.boot
> @@ -300,6 +300,22 @@ config LEGACY_IMAGE_FORMAT
> loaded. If a board needs the legacy image format support in this
> case, enable it here.
>
> +config EBBR
> + bool "Enable support for Embeeded Boot Base Requirements (EBBR)"
> + select EFI_LOADER
> + default y if !ARM || SYS_CPU = armv7 || SYS_CPU = armv8
This won't work. You cannot have UEFI neither on big-endian systems nor
on any other architecture not mentioned in the UEFI specification.
Why do you want to exclude arm1136 and arm1176?
> + help
> + Enable this to support ARM's EBBR boot method. This bases everything
> + on UEFI protocols.´
EBBR is explitely not ARM specific. EBBR is not a boot method but a
subset of the UEFI specification.
> +
> + This Embedded Base Boot Requirements (EBBR) specification defines an
> + interface between platform firmware and an operating system that is
> + suitable for embedded platforms. EBBR-compliant platforms present a
> + consistent interface that will boot an EBBR-compliant operating
> + system without any custom tailoring required. For example, an Arm
> + A-class embedded platform will benefit from a standard interface that
> + supports features such as secure boot and firmware update.
Which user will ever have heard of the EBBR specification? Referencing
it in Kconfig will lead to confusion.
This new symbol is redundant. If you think that a better name for
EFI_LOADER is needed, please suggest one.
Best regards
Heinrich
> +
> config SUPPORT_RAW_INITRD
> bool "Enable raw initrd images"
> help
> diff --git a/lib/efi_loader/Kconfig b/lib/efi_loader/Kconfig
> index 466abfed300..bc5fb3f5e03 100644
> --- a/lib/efi_loader/Kconfig
> +++ b/lib/efi_loader/Kconfig
> @@ -10,7 +10,6 @@ config EFI_LOADER
> depends on !EFI_STUB || !X86_64 || EFI_STUB_64BIT
> # We need EFI_STUB_32BIT to be set on x86_32 with EFI_STUB
> depends on !EFI_STUB || !X86 || X86_64 || EFI_STUB_32BIT
> - default y if !ARM || SYS_CPU = armv7 || SYS_CPU = armv8
> select LIB_UUID
> select HAVE_BLOCK_DEVICE
> select REGEX
>
next prev parent reply other threads:[~2021-07-29 0:12 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-02 18:36 [PATCH v2 0/9] efi: Various tidy-ups and drop the default Simon Glass
2021-07-02 18:36 ` [PATCH v2 1/9] configs: Resync with savedefconfig Simon Glass
2021-07-02 18:36 ` [PATCH v2 2/9] Makefile: Drop include/asm directory as well as symlink Simon Glass
2021-07-28 22:56 ` Tom Rini
2021-07-02 18:36 ` [PATCH v2 3/9] disk: Tidy up #ifdefs in part_efi Simon Glass
2021-07-28 22:56 ` Tom Rini
2021-07-28 23:21 ` Heinrich Schuchardt
2021-07-02 18:36 ` [PATCH v2 4/9] Use LIB_UUID with ACPIGEN and FS_BTRFS Simon Glass
2021-07-28 22:56 ` Tom Rini
2021-07-02 18:36 ` [PATCH v2 5/9] Allow efi_loader header to be included always Simon Glass
2021-07-28 22:56 ` Tom Rini
2021-07-02 18:36 ` [PATCH v2 6/9] lib: Create a new Kconfig option for charset conversion Simon Glass
2021-07-28 22:57 ` Tom Rini
2021-07-02 18:36 ` [PATCH v2 7/9] Make EFI_LOADER depend on DM and OF_CONTROL Simon Glass
2021-07-26 22:07 ` Tom Rini
2021-07-28 23:45 ` Heinrich Schuchardt
2021-07-28 23:55 ` Tom Rini
2021-07-29 1:44 ` Simon Glass
2021-07-29 13:52 ` Tom Rini
2021-07-30 19:02 ` Simon Glass
2021-07-30 21:33 ` Tom Rini
2021-07-30 21:48 ` Simon Glass
2021-07-30 22:08 ` Tom Rini
2022-03-28 6:35 ` Simon Glass
2022-03-28 14:15 ` Tom Rini
2021-07-02 18:36 ` [PATCH v2 8/9] Add an option for EBBR Simon Glass
2021-07-29 0:12 ` Heinrich Schuchardt [this message]
2021-07-29 0:40 ` Tom Rini
2021-07-02 18:36 ` [PATCH v2 9/9] efi: Make EBBR optional Simon Glass
2021-07-02 20:11 ` Tom Rini
2021-07-02 20:38 ` Simon Glass
2021-07-29 0:35 ` Heinrich Schuchardt
2021-07-02 19:50 ` [PATCH v2 0/9] efi: Various tidy-ups and drop the default Mark Kettenis
2021-07-02 20:04 ` Simon Glass
2021-07-02 20:19 ` Tom Rini
2021-07-02 20:50 ` Simon Glass
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b84b4121-2b81-7caf-9bdb-78a14332114f@gmx.de \
--to=xypron.glpk@gmx.de \
--cc=ilias.apalodimas@linaro.org \
--cc=mark.kettenis@xs4all.nl \
--cc=pali@kernel.org \
--cc=sjg@chromium.org \
--cc=trini@konsulko.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.