From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8EC7FC4332F for ; Fri, 14 Jan 2022 10:56:07 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S240585AbiANK4F (ORCPT ); Fri, 14 Jan 2022 05:56:05 -0500 Received: from 113.196.136.162.ll.static.sparqnet.net ([113.196.136.162]:34630 "EHLO mg.sunplus.com" rhost-flags-OK-FAIL-OK-FAIL) by vger.kernel.org with ESMTP id S240580AbiANK4D (ORCPT ); Fri, 14 Jan 2022 05:56:03 -0500 X-MailGates: (flag:3,DYNAMIC,RELAY,NOHOST:PASS)(compute_score:DELIVER,40 ,3) Received: from 172.17.9.202 by mg01.sunplus.com with MailGates ESMTP Server V5.0(23023:0:AUTH_RELAY) (envelope-from ); Fri, 14 Jan 2022 18:56:16 +0800 (CST) Received: from sphcmbx02.sunplus.com.tw (172.17.9.112) by sphcmbx01.sunplus.com.tw (172.17.9.202) with Microsoft SMTP Server (TLS) id 15.0.1497.26; Fri, 14 Jan 2022 18:56:11 +0800 Received: from sphcmbx02.sunplus.com.tw ([fe80::fd3d:ad1a:de2a:18bd]) by sphcmbx02.sunplus.com.tw ([fe80::fd3d:ad1a:de2a:18bd%14]) with mapi id 15.00.1497.026; Fri, 14 Jan 2022 18:56:11 +0800 From: =?utf-8?B?V2VsbHMgTHUg5ZGC6Iqz6aiw?= To: Andy Shevchenko CC: Wells Lu , Linus Walleij , "open list:GPIO SUBSYSTEM" , "Linux Kernel Mailing List" , Rob Herring , devicetree , linux-arm Mailing List , "dvorkin@tibbo.com" Subject: RE: [PATCH v5 2/2] pinctrl: Add driver for Sunplus SP7021 Thread-Topic: [PATCH v5 2/2] pinctrl: Add driver for Sunplus SP7021 Thread-Index: AQHX+JsJQRl6kRXEwk+dQHdfPj/+4axC0feAgAMwBYCAFioXgIAEjh2ggAAegACAARLWMP//9D8AgACSwAA= Date: Fri, 14 Jan 2022 10:56:10 +0000 Message-ID: References: <1640331779-18277-1-git-send-email-wellslutw@gmail.com> <1640331779-18277-3-git-send-email-wellslutw@gmail.com> <9e15ccc8ee844f1eab320001bc8bc235@sphcmbx02.sunplus.com.tw> In-Reply-To: Accept-Language: zh-TW, en-US Content-Language: zh-TW X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-exchange-transport-fromentityheader: Hosted x-originating-ip: [172.25.108.39] Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org PiAuLi4NCj4gDQo+ID4gPiA+ID4gPiA+ID4gKyAgICAgICBib29sICJTdW5wbHVzIFNQNzAyMSBQ aW5NdXggYW5kIEdQSU8gZHJpdmVyIg0KPiA+ID4gPiA+ID4gPg0KPiA+ID4gPiA+ID4gPiBXaHkg Ym9vbCBhbmQgbm90IHRyaXN0YXRlPw0KPiA+ID4gPiA+ID4NCj4gPiA+ID4gPiA+IFBpbmN0cmwg ZHJpdmVyIGlzIHNlbGVjdGVkIGJ5IG1hbnkgZHJpdmVycyBpbiBTUDcwMjEgcGxhdGZvcm0uDQo+ ID4gPiA+ID4gPiBXZSBuZXZlciBidWlsZCBpdCBhcyBhIG1vZHVsZSwgYnV0IGJ1aWxkLWluIHRv IGtlcm5lbC4NCj4gPiA+ID4gPiA+IFNvIHdlIHVzZSAiYm9vbCIuDQo+ID4gPiA+ID4gPg0KPiA+ ID4gPiA+ID4gU2hvdWxkIHdlIHNldCBpdCB0byB0cmlzdGF0ZT8NCj4gPiA+ID4gPg0KPiA+ID4g PiA+IFlvdSBzdGlsbCBoYXZlbid0IGFuc3dlcmVkICJ3aHkiLCBzbyBJIGNhbid0IHRlbGwgeW91 Lg0KPiA+ID4gPg0KPiA+ID4gPiBJIGFtIHB1enpsZWQgYmVjYXVzZSBJIHRoaW5rIEkgaGF2ZSBh bnN3ZXJlZCAid2h5Ii4NCj4gPiA+DQo+ID4gPiBOb3BlLiA6LSkNCj4gPiA+DQo+ID4gPiA+IEJl Y2F1c2UgUGluY3RybCBkcml2ZXIgaXMgbmVjZXNzYXJ5IGZvciBhbGwgU1A3MDIxLWJhc2VkIHBs YXRmb3Jtcy4NCj4gPiA+DQo+ID4gPiAiV2h5PyIgV2h5IGlzIGl0IG5lY2Vzc2FyeSAodG8gYmUg YnVpbHQtaW4pPw0KPiA+DQo+ID4gUGluY3RybCBpcyBuZWNlc3NhcnkgdG8gYmUgYnVpbHQtaW4g YmVjYXVzZSBkcml2ZXJzIG9mIGJvb3QtZGV2aWNlLA0KPiA+IGxpa2UgZU1NQywgU0QgY2FyZCwg TkFORCBmbGFzaCwgYW5kIE5PUiBmbGFzaCBkcml2ZXJzLCBuZWVkIGl0Lg0KPiA+DQo+ID4gU1A3 MDIxIHN1cHBvcnRzIGJvb3RpbmcgZnJvbSBlTU1DLCBTRCBjYXJkLCBOQU5EIGZsYXNoIGFuZCBO T1IgZmxhc2gNCj4gPiBkZXZpY2VzLiBUaGVpciBkcml2ZXJzIG5lZWQgUGluY3RybCBkcml2ZXIg cHJvYmVzIGluIGFkdmFuY2UuDQo+IA0KPiBPbiB4ODYgcGxhdGZvcm1zLCBmb3IgZXhhbXBsZSwg Ym9vdGluZyBmcm9tIGVNTUMgYW5kIFNEIGNhcmQgZG9lcyBub3QgcmVxdWlyZSBhIHBpbg0KPiBj b250cm9sIGRyaXZlciB0byBiZSBidWlsdC1pbi4gV2h5IGlzIHRoaXMgcmVxdWlyZW1lbnQgZm9y IFNQIHBsYXRmb3Jtcz8NCj4gDQo+IC0tDQo+IFdpdGggQmVzdCBSZWdhcmRzLA0KPiBBbmR5IFNo ZXZjaGVua28NCg0KQmVjYXVzZSBhbGwgcGlucyBvZiBib290LWRldmljZSBtdWx0aXBsZXggd2l0 aCBHUElPIHBpbnMuDQoNClNQNzAyMSBwbGF0Zm9ybXMgc3VwcG9ydCBtdWx0aSBib290IGRldmlj ZXMsIGluY2x1ZGluZyBlTU1DLCBTRCBjYXJkLA0KU1BJLU5PUiBmbGFzaCwgU1BJLU5BTkQgZmxh c2guIEVhY2ggYm9vdCBkZXZpY2UgaGFzIGNvbnRyb2wtYml0KHMpIA0KdG8gZW5hYmxlIGl0Lg0K DQpGb3IgZXhhbXBsZSAjMSwgaWYgY29udHJvbC1iaXRzIG9mIFNQSS1OT1IgZmxhc2ggaXMgc2V0 IDEsDQpHUElPIDgzLCA4NCwgODYsIDg3IGFyZSBjb25uZWN0ZWQgdG8gU1BJLU5PUiBmbGFzaC4N CklmIGNvbnRyb2wtYml0cyBvZiBTUEktTk9SIGZsYXNoIGlzIHNldCAyLA0KR1BJTyA3NiwgNzgs IDc5LCA4MSBhcmUgY29ubmVjdGVkIHRvIFNQSS1OT1IgZmxhc2guDQpJZiBjb250cm9sLWJpdHMg b2YgU1BJLU5PUiBmbGFzaCBpcyBzZXQgMCwgbm8gcGluIGlzIA0KY29ubmVjdGVkIFNQSS1OT1Ig Zmxhc2guDQoNCkZvciBleGFtcGxlICMyLCBpZiBjb250cm9sLWJpdHMgb2YgZU1NQyBkZXZpY2Ug aXMgc2V0IDEsDQpHUElPIDcyLCA3MywgNzQsIDc1LCA3NiwgNzcsIDc4LCA3OSwgODAsIDgxIGFy ZSBjb25uZWN0ZWQgdG8NCmVNTUMgZGV2aWNlLg0KSWYgY29udHJvbC1iaXRzIG9mIGVNTUMgZGV2 aWNlIGlzIHNldCAwLCBubyBwaW4gaXMgY29ubmVjdGVkIA0KZU1NQyBkZXZpY2UuDQoNCkZvciBl eGFtcGxlICMzLCBpZiBjb250cm9sLWJpdHMgb2YgU0RDYXJkIGRldmljZSBpcyBzZXQgMSwNCkdQ SU8gNjUsIDY2LCA2NywgNjgsIDY5LCA3MCBhcmUgY29ubmVjdGVkIHRvIFNEIENhcmQgZGV2aWNl Lg0KSWYgY29udHJvbC1iaXRzIG9mIFNEQ2FyZCBkZXZpY2UgaXMgc2V0IDAsIG5vIHBpbiBpcyBj b25uZWN0ZWQgDQpTRENhcmQgZGV2aWNlLg0KDQpOb3RlIHRoYXQgYWxsIHBpbnMgbXVsdGlwbGV4 IHdpdGggR1BJTyBwaW5zLg0KDQpOb3JtYWxseSwgb25seSBhIGJvb3QtZGV2aWNlIGlzIGVuYWJs ZWQuIEFsbCBvdGhlciBHUElPIHBpbnMNCmFyZSByZWxlYXNlZCBmb3IgcGVyaXBoZXJhbHMgKGNv bnRyb2xsZWQgYnkgZnVsbHktcGlubXV4DQpPciBncm91cCBwaW5tdXgpIG9yIElPIHByb2Nlc3Nv cg0KDQpQaW5jdHJsIGRyaXZlciBpcyByZXNwb25zaWJsZSBmb3Igc2V0dXAgdGhlIHBpbnMuDQpJ ZiBQaW5jdHJsIGZhaWxzIHRvIHByb2JlLCBib290LWRldmljZSBhbHNvIGZhaWxzIHRvIHByb2Jl Lg0KDQoNCkJlc3QgcmVnYXJkcywNCldlbGxzIEx1DQo= From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id DFA8CC433F5 for ; Fri, 14 Jan 2022 10:57:32 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:In-Reply-To:References: Message-ID:Date:Subject:CC:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=3HOgszwGb/nfY9XWe3hLDHGe2wHaW0lldIffDG+hloo=; b=rpEtuc6z7TX2sn T88LBT+zsKOIIq+NNdjUaNrR/xSGYvyhTwdR6uQX23u7WkJCrYuH2Y+aUny9jMZoiF1D+gZSgn22t UQb4FBDJSTm6m/ZNR9iPfjaARRTnghCKsmrKulLOxm3XZSD36rx5cjFOKJGIbxmIw+AyX0SwFYvuX LaMPTI1dCxbavfpV8WxZbatHlhI01HrXhWK60wDpVIa3qlKFQ12aBcPIAqP2LhV6BO4Bl9EujvGY6 POLhXObuRiDDjTaKuzYGrpg6qs68qdduXFGJnHvj7DQc8eNp3H1MaC70+PRsnVINF257qBOpG9Xjy 1Ye+T+JG9G2SJSZRc8jg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1n8KFl-008nrS-M3; Fri, 14 Jan 2022 10:56:17 +0000 Received: from [113.196.136.162] (helo=mg.sunplus.com) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1n8KFg-008nqA-QA for linux-arm-kernel@lists.infradead.org; Fri, 14 Jan 2022 10:56:16 +0000 X-MailGates: (flag:3,DYNAMIC,RELAY,NOHOST:PASS)(compute_score:DELIVER,40 ,3) Received: from 172.17.9.202 by mg01.sunplus.com with MailGates ESMTP Server V5.0(23023:0:AUTH_RELAY) (envelope-from ); Fri, 14 Jan 2022 18:56:16 +0800 (CST) Received: from sphcmbx02.sunplus.com.tw (172.17.9.112) by sphcmbx01.sunplus.com.tw (172.17.9.202) with Microsoft SMTP Server (TLS) id 15.0.1497.26; Fri, 14 Jan 2022 18:56:11 +0800 Received: from sphcmbx02.sunplus.com.tw ([fe80::fd3d:ad1a:de2a:18bd]) by sphcmbx02.sunplus.com.tw ([fe80::fd3d:ad1a:de2a:18bd%14]) with mapi id 15.00.1497.026; Fri, 14 Jan 2022 18:56:11 +0800 From: =?utf-8?B?V2VsbHMgTHUg5ZGC6Iqz6aiw?= To: Andy Shevchenko CC: Wells Lu , Linus Walleij , "open list:GPIO SUBSYSTEM" , "Linux Kernel Mailing List" , Rob Herring , devicetree , linux-arm Mailing List , "dvorkin@tibbo.com" Subject: RE: [PATCH v5 2/2] pinctrl: Add driver for Sunplus SP7021 Thread-Topic: [PATCH v5 2/2] pinctrl: Add driver for Sunplus SP7021 Thread-Index: AQHX+JsJQRl6kRXEwk+dQHdfPj/+4axC0feAgAMwBYCAFioXgIAEjh2ggAAegACAARLWMP//9D8AgACSwAA= Date: Fri, 14 Jan 2022 10:56:10 +0000 Message-ID: References: <1640331779-18277-1-git-send-email-wellslutw@gmail.com> <1640331779-18277-3-git-send-email-wellslutw@gmail.com> <9e15ccc8ee844f1eab320001bc8bc235@sphcmbx02.sunplus.com.tw> In-Reply-To: Accept-Language: zh-TW, en-US Content-Language: zh-TW X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-exchange-transport-fromentityheader: Hosted x-originating-ip: [172.25.108.39] MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220114_025613_157807_E1865B74 X-CRM114-Status: GOOD ( 20.73 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org > ... > > > > > > > > > + bool "Sunplus SP7021 PinMux and GPIO driver" > > > > > > > > > > > > > > Why bool and not tristate? > > > > > > > > > > > > Pinctrl driver is selected by many drivers in SP7021 platform. > > > > > > We never build it as a module, but build-in to kernel. > > > > > > So we use "bool". > > > > > > > > > > > > Should we set it to tristate? > > > > > > > > > > You still haven't answered "why", so I can't tell you. > > > > > > > > I am puzzled because I think I have answered "why". > > > > > > Nope. :-) > > > > > > > Because Pinctrl driver is necessary for all SP7021-based platforms. > > > > > > "Why?" Why is it necessary (to be built-in)? > > > > Pinctrl is necessary to be built-in because drivers of boot-device, > > like eMMC, SD card, NAND flash, and NOR flash drivers, need it. > > > > SP7021 supports booting from eMMC, SD card, NAND flash and NOR flash > > devices. Their drivers need Pinctrl driver probes in advance. > > On x86 platforms, for example, booting from eMMC and SD card does not require a pin > control driver to be built-in. Why is this requirement for SP platforms? > > -- > With Best Regards, > Andy Shevchenko Because all pins of boot-device multiplex with GPIO pins. SP7021 platforms support multi boot devices, including eMMC, SD card, SPI-NOR flash, SPI-NAND flash. Each boot device has control-bit(s) to enable it. For example #1, if control-bits of SPI-NOR flash is set 1, GPIO 83, 84, 86, 87 are connected to SPI-NOR flash. If control-bits of SPI-NOR flash is set 2, GPIO 76, 78, 79, 81 are connected to SPI-NOR flash. If control-bits of SPI-NOR flash is set 0, no pin is connected SPI-NOR flash. For example #2, if control-bits of eMMC device is set 1, GPIO 72, 73, 74, 75, 76, 77, 78, 79, 80, 81 are connected to eMMC device. If control-bits of eMMC device is set 0, no pin is connected eMMC device. For example #3, if control-bits of SDCard device is set 1, GPIO 65, 66, 67, 68, 69, 70 are connected to SD Card device. If control-bits of SDCard device is set 0, no pin is connected SDCard device. Note that all pins multiplex with GPIO pins. Normally, only a boot-device is enabled. All other GPIO pins are released for peripherals (controlled by fully-pinmux Or group pinmux) or IO processor Pinctrl driver is responsible for setup the pins. If Pinctrl fails to probe, boot-device also fails to probe. Best regards, Wells Lu _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel