From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,NICE_REPLY_A, SPF_HELO_NONE,SPF_PASS,URIBL_RED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2E548C48BE5 for ; Thu, 17 Jun 2021 02:37:07 +0000 (UTC) Received: from smtp1.osuosl.org (smtp1.osuosl.org [140.211.166.138]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id CDC3E613E2 for ; Thu, 17 Jun 2021 02:37:06 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org CDC3E613E2 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=virtualization-bounces@lists.linux-foundation.org Received: from localhost (localhost [127.0.0.1]) by smtp1.osuosl.org (Postfix) with ESMTP id 9002E83D12; Thu, 17 Jun 2021 02:37:06 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp1.osuosl.org ([127.0.0.1]) by localhost (smtp1.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id NUuDZoH0u4Uf; Thu, 17 Jun 2021 02:37:05 +0000 (UTC) Received: from lists.linuxfoundation.org (lf-lists.osuosl.org [IPv6:2605:bc80:3010:104::8cd3:938]) by smtp1.osuosl.org (Postfix) with ESMTPS id 479D1839D8; Thu, 17 Jun 2021 02:37:05 +0000 (UTC) Received: from lf-lists.osuosl.org (localhost [127.0.0.1]) by lists.linuxfoundation.org (Postfix) with ESMTP id EFB03C000E; Thu, 17 Jun 2021 02:37:04 +0000 (UTC) Received: from smtp1.osuosl.org (smtp1.osuosl.org [IPv6:2605:bc80:3010::138]) by lists.linuxfoundation.org (Postfix) with ESMTP id 1F812C000B for ; Thu, 17 Jun 2021 02:37:04 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp1.osuosl.org (Postfix) with ESMTP id 0760983C8B for ; Thu, 17 Jun 2021 02:37:04 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp1.osuosl.org ([127.0.0.1]) by localhost (smtp1.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id wFtbDgTFEVsZ for ; Thu, 17 Jun 2021 02:37:03 +0000 (UTC) X-Greylist: domain auto-whitelisted by SQLgrey-1.8.0 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by smtp1.osuosl.org (Postfix) with ESMTPS id ED39B839D8 for ; Thu, 17 Jun 2021 02:37:02 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1623897421; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=z5SUgRme5vfSn2M+kLpJuyGRMNfwStTHpMTYk3YD170=; b=azGhS5y2Ka9+eGXOz5c7OVVX4zyxo+f/GtqYgXsMwG1ClW4V9/kGvlscZT7k1jLzeArCdd Gurw9CjRnUuBpgZ+ly4AwJ2iUM/QdgFis6bbteff7doqFRxIQKx+sp1TLIe3I3yGnvW2a9 d7yCn54DKbuGiWUN/nId2+tBqPpmK48= Received: from mail-pg1-f198.google.com (mail-pg1-f198.google.com [209.85.215.198]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-160-ccZH72yJPm6jA-585QQvVw-1; Wed, 16 Jun 2021 22:36:58 -0400 X-MC-Unique: ccZH72yJPm6jA-585QQvVw-1 Received: by mail-pg1-f198.google.com with SMTP id t28-20020a63461c0000b0290221e90ef795so2813459pga.6 for ; Wed, 16 Jun 2021 19:36:58 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-transfer-encoding :content-language; bh=z5SUgRme5vfSn2M+kLpJuyGRMNfwStTHpMTYk3YD170=; b=UPQWgmDEH66SUszizMQqADNRjjq2EQFzOPv1/z/J1lBB5vnkdk5CjIxSsh2wMK7E3y QYO9VViqkzSyXpyBA0KZ15YSJT0kPlivdBSjktFIvLplAPDdzvYAQ2fFbYytOlpLw8m6 A386c/qO1tR4CTJrOyR+9Q6Ib+OZhIs/R0EY3afYAo/I1ruFKPvCJEFJbEzj/2/TjA7T XHmFFmcdZYMuSVq30eNfCGODdIx9aJ8ZZEUdl2PA6O6WP6ijNorlrlp1YQzTYEc/NKAG pDGdrXQ5JV5t/JI9shKhE5bDLFn9Mh+hQvKDx+oiKPetp3ft1i0slTpZEMsQYeZg6wM1 PXcQ== X-Gm-Message-State: AOAM532t9IExR3cqFMySWjmmirofuMtGYSDITb/20GhfTz15qsV6uSSD a47JybAvNSxmv3H52BK7BhsT8r2rwVUQtXJ3+PyvKGYd+o19F6QdFvnYAJNGwm4ZttuyIB27nVg zm251c+5EXeaB2oTjkpTFGX7AqV10A+yaqjXeZ4ucAw== X-Received: by 2002:aa7:8886:0:b029:2fe:8eee:4a69 with SMTP id z6-20020aa788860000b02902fe8eee4a69mr1172975pfe.73.1623897417215; Wed, 16 Jun 2021 19:36:57 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzJlUPCOW72eixcxEQwNs9jI/9nypgEKYTM8JVt54OOata6jZKvX0oDhYusW5wvm4F8OwAFgw== X-Received: by 2002:aa7:8886:0:b029:2fe:8eee:4a69 with SMTP id z6-20020aa788860000b02902fe8eee4a69mr1172955pfe.73.1623897416935; Wed, 16 Jun 2021 19:36:56 -0700 (PDT) Received: from wangxiaodeMacBook-Air.local ([209.132.188.80]) by smtp.gmail.com with ESMTPSA id b1sm3342472pjh.4.2021.06.16.19.36.51 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 16 Jun 2021 19:36:56 -0700 (PDT) Subject: Re: [PATCH net-next v5 12/15] virtio-net: support AF_XDP zc tx To: Xuan Zhuo References: <1623848265.175296-1-xuanzhuo@linux.alibaba.com> From: Jason Wang Message-ID: Date: Thu, 17 Jun 2021 10:36:49 +0800 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:78.0) Gecko/20100101 Thunderbird/78.11.0 MIME-Version: 1.0 In-Reply-To: <1623848265.175296-1-xuanzhuo@linux.alibaba.com> Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=jasowang@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Cc: Song Liu , Martin KaFai Lau , Jesper Dangaard Brouer , Daniel Borkmann , "Michael S. Tsirkin" , Yonghong Song , John Fastabend , Alexei Starovoitov , Andrii Nakryiko , netdev@vger.kernel.org, =?UTF-8?B?QmrDtnJuIFTDtnBlbA==?= , "dust.li" , Jonathan Lemon , KP Singh , Jakub Kicinski , bpf@vger.kernel.org, virtualization@lists.linux-foundation.org, "David S. Miller" , Magnus Karlsson X-BeenThere: virtualization@lists.linux-foundation.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: Linux virtualization List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: base64 Content-Type: text/plain; charset="utf-8"; Format="flowed" Errors-To: virtualization-bounces@lists.linux-foundation.org Sender: "Virtualization" CuWcqCAyMDIxLzYvMTYg5LiL5Y2IODo1NywgWHVhbiBaaHVvIOWGmemBkzoKPiBPbiBXZWQsIDE2 IEp1biAyMDIxIDIwOjUxOjQxICswODAwLCBKYXNvbiBXYW5nIDxqYXNvd2FuZ0ByZWRoYXQuY29t PiB3cm90ZToKPj4g5ZyoIDIwMjEvNi8xNiDkuIvljYg2OjE5LCBYdWFuIFpodW8g5YaZ6YGTOgo+ Pj4+PiArICogSW4gdGhpcyB3YXksIGV2ZW4gaWYgeHNrIGhhcyBiZWVuIHVuYnVuZGxlZCB3aXRo IHJxL3NxLCBvciBhIG5ldyB4c2sgYW5kCj4+Pj4+ICsgKiBycS9zcSAgYXJlIGJvdW5kLCBhbmQg YSBuZXcgdmlydG5ldF94c2tfY3R4X2hlYWQgaXMgY3JlYXRlZC4gSXQgd2lsbCBub3QKPj4+Pj4g KyAqIGFmZmVjdCB0aGUgb2xkIHZpcnRuZXRfeHNrX2N0eCB0byBiZSByZWN5Y2xlZC4gQW5kIGZy ZWUgYWxsIGhlYWQgYW5kIGN0eCB3aGVuCj4+Pj4+ICsgKiByZWYgaXMgMC4KPj4+PiBUaGlzIGxv b2tzIGNvbXBsaWNhdGVkIGFuZCBpdCB3aWxsIGluY3JlYXNlIHRoZSBmb290cHJpbnQuIENvbnNp ZGVyIHRoZQo+Pj4+IHBlcmZvcm1hbmNlIHBlbmFsdHkgYW5kIHRoZSBjb21wbGV4aXR5LCBJIHdv dWxkIHN1Z2dlc3QgdG8gdXNlIHJlc2V0Cj4+Pj4gaW5zdGVhZC4KPj4+Pgo+Pj4+IFRoZW4gd2Ug ZG9uJ3QgbmVlZCB0byBpbnRyb2R1Y2Ugc3VjaCBjb250ZXh0Lgo+Pj4gSSBkb24ndCBsaWtlIHRo aXMgZWl0aGVyLiBJdCBpcyBiZXN0IGlmIHdlIGNhbiByZXNldCB0aGUgcXVldWUsIGJ1dCB0aGVu LAo+Pj4gYWNjb3JkaW5nIHRvIG15IHVuZGVyc3RhbmRpbmcsIHRoZSBiYWNrZW5kIHNob3VsZCBh bHNvIGJlIHN1cHBvcnRlZAo+Pj4gc3luY2hyb25vdXNseSwgc28gaWYgeW91IGRvbid0IHVwZGF0 ZSB0aGUgYmFja2VuZCBzeW5jaHJvbm91c2x5LCB5b3UgY2FuJ3QgdXNlCj4+PiB4c2suCj4+Cj4+ IFllcywgYWN0dWFsbHksIHZob3N0LW5ldCBzdXBwb3J0IHBlciB2cSBzdXNwZW5kaW5nLiBUaGUg cHJvYmxlbSBpcyB0aGF0Cj4+IHdlJ3JlIGxhY2tpbmcgYSBwcm9wZXIgQVBJIGF0IHZpcnRpbyBs ZXZlbC4KPj4KPj4gVmlydGlvLXBjaSBoYXMgcXVldWVfZW5hYmxlIGJ1dCBpdCBmb3JiaWRzIHdy aXRpbmcgemVybyB0byB0aGF0Lgo+Pgo+Pgo+Pj4gSSBkb27igJl0IHRoaW5rIHJlc2V0dGluZyB0 aGUgZW50aXJlIGRldiBpcyBhIGdvb2Qgc29sdXRpb24uIElmIHlvdSB3YW50IHRvIGJpbmQKPj4+ IHhzayB0byAxMCBxdWV1ZXMsIHlvdSBtYXkgaGF2ZSB0byByZXNldCB0aGUgZW50aXJlIGRldmlj ZSAxMCB0aW1lcy4gSSBkb27igJl0Cj4+PiB0aGluayB0aGlzIGlzIGEgZ29vZCB3YXkuIEJ1dCB0 aGUgY3VycmVudCBzcGVjIGRvZXMgbm90IHN1cHBvcnQgcmVzZXQgc2luZ2xlCj4+PiBxdWV1ZSwg c28gSSBjaG9zZSB0aGUgY3VycmVudCBzb2x1dGlvbi4KPj4+Cj4+PiBKYXNvbiwgd2hhdCBkbyB5 b3UgdGhpbmsgd2UgYXJlIGdvaW5nIHRvIGRvPyBSZWFsaXplIHRoZSByZXNldCBmdW5jdGlvbiBv ZiBhCj4+PiBzaW5nbGUgcXVldWU/Cj4+Cj4+IFllcywgaXQncyB0aGUgYmVzdCB3YXkuIERvIHlv dSB3YW50IHRvIHdvcmsgb24gdGhhdD8KPiBPZiBjb3Vyc2UsIEkgYW0gdmVyeSB3aWxsaW5nIHRv IGNvbnRpbnVlIHRoaXMgd29yay4gQWx0aG91Z2ggdXNlcnMgbXVzdCB1cGdyYWRlCj4gdGhlIGJh Y2tlbmQgdG8gdXNlIHZpcnRpby1uZXQgKyB4c2sgaW4gdGhlIGZ1dHVyZSwgdGhpcyBtYWtlcyB0 aGUgc2l0dWF0aW9uIGEKPiBiaXQgdHJvdWJsZXNvbWUuCj4KPiBJIHdpbGwgY29tcGxldGUgdGhl IGtlcm5lbCBtb2RpZmljYXRpb24gYXMgc29vbiBhcyBwb3NzaWJsZSwgYnV0IEkgYW0gbm90Cj4g ZmFtaWxpYXIgd2l0aCB0aGUgcHJvY2VzcyBvZiBzdWJtaXR0aW5nIHRoZSBzcGVjIHBhdGNoLiBD YW4geW91IGdpdmUgbWUgc29tZQo+IGd1aWRhbmNlIGFuZCB3aGVyZSBzaG91bGQgSSBzZW5kIHRo ZSBzcGVjIHBhdGNoLgoKClN1YnNjcmliZSB0aGUgdmlydGlvIGRldiBtYWlsaW5nIGxpc3QgWzFd IGFuZCBzZW5kIHRoZSBzcGVjIHBhdGggdGhlcmUuCgpUaGFua3MKClsxXSAKaHR0cHM6Ly93d3cu b2FzaXMtb3Blbi5vcmcvY29tbWl0dGVlcy90Y19ob21lLnBocD93Z19hYmJyZXY9dmlydGlvI2Zl ZWRiYWNrCgoKPgo+IFRoYW5rcy4KPgo+PiBXZSBjYW4gc3RhcnQgZnJvbSB0aGUgc3BlYyBwYXRj aCwgYW5kIGludHJvZHVjZSBpdCBhcyBiYXNpYyBmYWNpbGl0eSBhbmQKPj4gaW1wbGVtZW50IGl0 IGluIHRoZSBQQ0kgdHJhbnNwb3J0IGZpcnN0Lgo+Pgo+PiBUaGFua3MKPj4KPj4KPj4+IExvb2tp bmcgZm9yd2FyZCB0byB5b3VyIHJlcGx5ISEhCj4+Pgo+Pj4gVGhhbmtzCj4+PgoKX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KVmlydHVhbGl6YXRpb24gbWFp bGluZyBsaXN0ClZpcnR1YWxpemF0aW9uQGxpc3RzLmxpbnV4LWZvdW5kYXRpb24ub3JnCmh0dHBz Oi8vbGlzdHMubGludXhmb3VuZGF0aW9uLm9yZy9tYWlsbWFuL2xpc3RpbmZvL3ZpcnR1YWxpemF0 aW9u From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.6 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4F691C48BE5 for ; Thu, 17 Jun 2021 02:37:02 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 1EF3860FDC for ; Thu, 17 Jun 2021 02:37:02 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230028AbhFQCjH (ORCPT ); Wed, 16 Jun 2021 22:39:07 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]:27408 "EHLO us-smtp-delivery-124.mimecast.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229992AbhFQCjH (ORCPT ); Wed, 16 Jun 2021 22:39:07 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1623897419; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=z5SUgRme5vfSn2M+kLpJuyGRMNfwStTHpMTYk3YD170=; b=RwE/c0gI1mkLVXS/GciwpxzCEpKi+KCtN/n9ObhGxTpF62jT2ck21C/u1w75kNKNvjdOCr WPpr84qIfCcZS/M6RThRnBiKU8ZbvEmkQgcb0S3HgUsmd51MqYvm9mJNkCla87QI+4SUCc Pp7dMKTHIduO1S5Ko8CbvdKfymleKCU= Received: from mail-pl1-f199.google.com (mail-pl1-f199.google.com [209.85.214.199]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-576-NhjatiijNoeKlH9-9MRPsA-1; Wed, 16 Jun 2021 22:36:58 -0400 X-MC-Unique: NhjatiijNoeKlH9-9MRPsA-1 Received: by mail-pl1-f199.google.com with SMTP id p8-20020a1709028a88b029011c6ee150f3so1101002plo.1 for ; Wed, 16 Jun 2021 19:36:58 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-transfer-encoding :content-language; bh=z5SUgRme5vfSn2M+kLpJuyGRMNfwStTHpMTYk3YD170=; b=WvmU+75ZdB6kNGFSwqg1gH6FdTUcPyRD/foDI8VP8PIwbrk4vbT/P1fZci2lZjyiKF mNZnwxHXiMrHBqn39g8hH3hDKAe9HegnWkptHHEeLDDPJTZT2NNDsNIc4DsNHi77yCdo siDt1EOwTU3oIWGJUgHv2OX5lfX7vkQLrr5FheSY7S7ltj5OHNztE/ojjd4vHyUAn1fS mJR1rlnAUx3QST7yWxTlC7J1/EchQihEKanH5Ae+dfrpRnoj2gXbeXWCVR19Sn2NH2Go XBwt/8MkO4y8y+jeJbt4f7/4oOfm9SmjGDnboT0/vO0B+leu3uYP6kK94EIB2zbWB6TC 35xg== X-Gm-Message-State: AOAM530K9YAYak6S/+q733AS29RhJFpwHtt4Tra89C2NyRgX3nNa7nel 5nrZ2jdpBxUg8pBH2aJdBHYyzZVayiUeRcvvO0q/4b2o6Y8Psafx7SfOgpfrNDfUeROmyxmk8o7 7gT/uQNh2GZhF X-Received: by 2002:aa7:8886:0:b029:2fe:8eee:4a69 with SMTP id z6-20020aa788860000b02902fe8eee4a69mr1172977pfe.73.1623897417215; Wed, 16 Jun 2021 19:36:57 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzJlUPCOW72eixcxEQwNs9jI/9nypgEKYTM8JVt54OOata6jZKvX0oDhYusW5wvm4F8OwAFgw== X-Received: by 2002:aa7:8886:0:b029:2fe:8eee:4a69 with SMTP id z6-20020aa788860000b02902fe8eee4a69mr1172955pfe.73.1623897416935; Wed, 16 Jun 2021 19:36:56 -0700 (PDT) Received: from wangxiaodeMacBook-Air.local ([209.132.188.80]) by smtp.gmail.com with ESMTPSA id b1sm3342472pjh.4.2021.06.16.19.36.51 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 16 Jun 2021 19:36:56 -0700 (PDT) Subject: Re: [PATCH net-next v5 12/15] virtio-net: support AF_XDP zc tx To: Xuan Zhuo Cc: "David S. Miller" , Jakub Kicinski , "Michael S. Tsirkin" , =?UTF-8?B?QmrDtnJuIFTDtnBlbA==?= , Magnus Karlsson , Jonathan Lemon , Alexei Starovoitov , Daniel Borkmann , Jesper Dangaard Brouer , John Fastabend , Andrii Nakryiko , Martin KaFai Lau , Song Liu , Yonghong Song , KP Singh , virtualization@lists.linux-foundation.org, bpf@vger.kernel.org, "dust.li" , netdev@vger.kernel.org References: <1623848265.175296-1-xuanzhuo@linux.alibaba.com> From: Jason Wang Message-ID: Date: Thu, 17 Jun 2021 10:36:49 +0800 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:78.0) Gecko/20100101 Thunderbird/78.11.0 MIME-Version: 1.0 In-Reply-To: <1623848265.175296-1-xuanzhuo@linux.alibaba.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Content-Language: en-US Precedence: bulk List-ID: X-Mailing-List: bpf@vger.kernel.org 在 2021/6/16 下午8:57, Xuan Zhuo 写道: > On Wed, 16 Jun 2021 20:51:41 +0800, Jason Wang wrote: >> 在 2021/6/16 下午6:19, Xuan Zhuo 写道: >>>>> + * In this way, even if xsk has been unbundled with rq/sq, or a new xsk and >>>>> + * rq/sq are bound, and a new virtnet_xsk_ctx_head is created. It will not >>>>> + * affect the old virtnet_xsk_ctx to be recycled. And free all head and ctx when >>>>> + * ref is 0. >>>> This looks complicated and it will increase the footprint. Consider the >>>> performance penalty and the complexity, I would suggest to use reset >>>> instead. >>>> >>>> Then we don't need to introduce such context. >>> I don't like this either. It is best if we can reset the queue, but then, >>> according to my understanding, the backend should also be supported >>> synchronously, so if you don't update the backend synchronously, you can't use >>> xsk. >> >> Yes, actually, vhost-net support per vq suspending. The problem is that >> we're lacking a proper API at virtio level. >> >> Virtio-pci has queue_enable but it forbids writing zero to that. >> >> >>> I don’t think resetting the entire dev is a good solution. If you want to bind >>> xsk to 10 queues, you may have to reset the entire device 10 times. I don’t >>> think this is a good way. But the current spec does not support reset single >>> queue, so I chose the current solution. >>> >>> Jason, what do you think we are going to do? Realize the reset function of a >>> single queue? >> >> Yes, it's the best way. Do you want to work on that? > Of course, I am very willing to continue this work. Although users must upgrade > the backend to use virtio-net + xsk in the future, this makes the situation a > bit troublesome. > > I will complete the kernel modification as soon as possible, but I am not > familiar with the process of submitting the spec patch. Can you give me some > guidance and where should I send the spec patch. Subscribe the virtio dev mailing list [1] and send the spec path there. Thanks [1] https://www.oasis-open.org/committees/tc_home.php?wg_abbrev=virtio#feedback > > Thanks. > >> We can start from the spec patch, and introduce it as basic facility and >> implement it in the PCI transport first. >> >> Thanks >> >> >>> Looking forward to your reply!!! >>> >>> Thanks >>>