From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 5F732C10F15 for ; Thu, 25 Apr 2024 06:29:47 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rzsbM-00066O-1s; Thu, 25 Apr 2024 02:29:00 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rzsbG-000661-Vu; Thu, 25 Apr 2024 02:28:55 -0400 Received: from rev.ng ([5.9.113.41]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rzsbF-0006eY-AE; Thu, 25 Apr 2024 02:28:54 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=rev.ng; s=dkim; h=In-Reply-To:Content-Transfer-Encoding:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive:List-Unsubscribe:List-Unsubscribe-Post: List-Help; bh=5QMD6OT4/QN/tvMX/7HwcVotZ4cCQJVV7+QfBX/IXgc=; b=VS8TNiuP7OgPdUJ QEV8fRLGE0wAPkCR6SlJs5Fu9RLITCHipuNzZbfe2ZbTDRmrQEOqZIrPGP1RN/D8Ec5xr+jZZ1anB /oFJ+9cQQNSj3gMdhcenLgNyrVHLAMTED0n505jZtd+03ADjnOGjfVvEnsTc8Jr3fHE3Mf2nbkJQT Vs=; Date: Thu, 25 Apr 2024 08:29:40 +0200 To: Philippe =?utf-8?Q?Mathieu-Daud=C3=A9?= Cc: qemu-devel@nongnu.org, Paolo Bonzini , Richard Henderson , qemu-arm@nongnu.org, qemu-ppc@nongnu.org, qemu-riscv@nongnu.org, David Hildenbrand , Alex =?utf-8?Q?Benn=C3=A9e?= , Eduardo Habkost , Marcel Apfelbaum , Yanan Wang , Peter Maydell , Nicholas Piggin , Daniel Henrique Barboza , Palmer Dabbelt , Alistair Francis , Bin Meng , Weiwei Li , Liu Zhiwei Subject: Re: [PATCH 02/24] exec: Declare CPUBreakpoint/CPUWatchpoint type in 'breakpoint.h' header Message-ID: References: <20240418192525.97451-1-philmd@linaro.org> <20240418192525.97451-3-philmd@linaro.org> <09dd8fe2-29ec-4099-9746-70fe8665b3dd@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <09dd8fe2-29ec-4099-9746-70fe8665b3dd@linaro.org> Received-SPF: pass client-ip=5.9.113.41; envelope-from=anjo@rev.ng; helo=rev.ng X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-to: Anton Johansson From: Anton Johansson via Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org On 18/04/24, Philippe Mathieu-Daudé wrote: > On 18/4/24 21:25, Philippe Mathieu-Daudé wrote: > > The CPUBreakpoint and CPUWatchpoint structures are declared > > in "hw/core/cpu.h", which contains declarations related to > > CPUState and CPUClass. Some source files only require the > > BP/WP definitions and don't need to pull in all CPU* API. > > In order to simplify, create a new "exec/breakpoint.h" header. > > > > Signed-off-by: Philippe Mathieu-Daudé > > --- > > include/exec/breakpoint.h | 23 +++++++++++++++++++++++ > > include/hw/core/cpu.h | 16 +--------------- > > target/arm/internals.h | 1 + > > target/ppc/internal.h | 1 + > > target/riscv/debug.h | 2 ++ > > 5 files changed, 28 insertions(+), 15 deletions(-) > > create mode 100644 include/exec/breakpoint.h Reviewed-by: Anton Johansson From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 00753C10F1A for ; Thu, 25 Apr 2024 06:29:23 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rzsbT-00069S-40; Thu, 25 Apr 2024 02:29:08 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rzsbG-000661-Vu; Thu, 25 Apr 2024 02:28:55 -0400 Received: from rev.ng ([5.9.113.41]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rzsbF-0006eY-AE; Thu, 25 Apr 2024 02:28:54 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=rev.ng; s=dkim; h=In-Reply-To:Content-Transfer-Encoding:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive:List-Unsubscribe:List-Unsubscribe-Post: List-Help; bh=5QMD6OT4/QN/tvMX/7HwcVotZ4cCQJVV7+QfBX/IXgc=; b=VS8TNiuP7OgPdUJ QEV8fRLGE0wAPkCR6SlJs5Fu9RLITCHipuNzZbfe2ZbTDRmrQEOqZIrPGP1RN/D8Ec5xr+jZZ1anB /oFJ+9cQQNSj3gMdhcenLgNyrVHLAMTED0n505jZtd+03ADjnOGjfVvEnsTc8Jr3fHE3Mf2nbkJQT Vs=; Date: Thu, 25 Apr 2024 08:29:40 +0200 To: Philippe =?utf-8?Q?Mathieu-Daud=C3=A9?= Cc: qemu-devel@nongnu.org, Paolo Bonzini , Richard Henderson , qemu-arm@nongnu.org, qemu-ppc@nongnu.org, qemu-riscv@nongnu.org, David Hildenbrand , Alex =?utf-8?Q?Benn=C3=A9e?= , Eduardo Habkost , Marcel Apfelbaum , Yanan Wang , Peter Maydell , Nicholas Piggin , Daniel Henrique Barboza , Palmer Dabbelt , Alistair Francis , Bin Meng , Weiwei Li , Liu Zhiwei Subject: Re: [PATCH 02/24] exec: Declare CPUBreakpoint/CPUWatchpoint type in 'breakpoint.h' header Message-ID: References: <20240418192525.97451-1-philmd@linaro.org> <20240418192525.97451-3-philmd@linaro.org> <09dd8fe2-29ec-4099-9746-70fe8665b3dd@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <09dd8fe2-29ec-4099-9746-70fe8665b3dd@linaro.org> Received-SPF: pass client-ip=5.9.113.41; envelope-from=anjo@rev.ng; helo=rev.ng X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-riscv@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-to: Anton Johansson From: Anton Johansson via Errors-To: qemu-riscv-bounces+qemu-riscv=archiver.kernel.org@nongnu.org Sender: qemu-riscv-bounces+qemu-riscv=archiver.kernel.org@nongnu.org On 18/04/24, Philippe Mathieu-Daudé wrote: > On 18/4/24 21:25, Philippe Mathieu-Daudé wrote: > > The CPUBreakpoint and CPUWatchpoint structures are declared > > in "hw/core/cpu.h", which contains declarations related to > > CPUState and CPUClass. Some source files only require the > > BP/WP definitions and don't need to pull in all CPU* API. > > In order to simplify, create a new "exec/breakpoint.h" header. > > > > Signed-off-by: Philippe Mathieu-Daudé > > --- > > include/exec/breakpoint.h | 23 +++++++++++++++++++++++ > > include/hw/core/cpu.h | 16 +--------------- > > target/arm/internals.h | 1 + > > target/ppc/internal.h | 1 + > > target/riscv/debug.h | 2 ++ > > 5 files changed, 28 insertions(+), 15 deletions(-) > > create mode 100644 include/exec/breakpoint.h Reviewed-by: Anton Johansson