From: bugzilla@dpdk.org
To: dev@dpdk.org
Subject: [DPDK/other Bug 1418] ice: no way to disable lsc-interrupts
Date: Tue, 23 Apr 2024 11:08:22 +0000 [thread overview]
Message-ID: <bug-1418-3@http.bugs.dpdk.org/> (raw)
[-- Attachment #1: Type: text/plain, Size: 1815 bytes --]
https://bugs.dpdk.org/show_bug.cgi?id=1418
Bug ID: 1418
Summary: ice: no way to disable lsc-interrupts
Product: DPDK
Version: 24.03
Hardware: x86
OS: Linux
Status: UNCONFIRMED
Severity: normal
Priority: Normal
Component: other
Assignee: dev@dpdk.org
Reporter: robin@jarry.cc
CC: ktraynor@redhat.com
Target Milestone: ---
Hi all,
Apparently, the ice driver does not allow disabling lsc interrupts. Starting
testpmd with --no-lsc-interrupt gives this in the console:
testpmd> ice_interrupt_handler(): OICR: link state change event
Port 0: link state change event
ice_interrupt_handler(): OICR: link state change event
Port 1: link state change event
I tested with version 22.11 which seems not to have the issue. I found a
suspicious commit introduced in 24.03 which may be the culprit:
commit 4e5dc111464e83e9a55fa466d8f682f0027b721e
Author: Qi Zhang <qi.z.zhang@intel.com>
Date: Thu Dec 14 03:40:54 2023 -0500
net/ice: fix link update
The ice_aq_get_link_info function is not thread-safe. However,
it is possible to simultaneous invocations during both the dev_start
and the LSC interrupt handler, potentially leading to unexpected adminq
errors. This patch addresses the issue by introducing a thread-safe
wrapper that utilizes a spinlock.
Fixes: cf911d90e366 ("net/ice: support link update")
Cc: stable@dpdk.org
Signed-off-by: Qi Zhang <qi.z.zhang@intel.com>
Acked-by: Qiming Yang <qiming.yang@intel.com>
https://git.dpdk.org/dpdk/commit/?id=4e5dc111464e83e9a55fa466d8f682f0027b721e
--
You are receiving this mail because:
You are the assignee for the bug.
[-- Attachment #2: Type: text/html, Size: 4068 bytes --]
reply other threads:[~2024-04-23 11:08 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bug-1418-3@http.bugs.dpdk.org/ \
--to=bugzilla@dpdk.org \
--cc=dev@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.