From mboxrd@z Thu Jan 1 00:00:00 1970 From: bugzilla-daemon-CC+yJ3UmIYqDUpFQwHEjaQ@public.gmane.org Subject: [Bug 90887] PhiMovesPass in register allocator broken Date: Thu, 20 Aug 2015 20:20:19 +0000 Message-ID: References: Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============0044782173==" Return-path: In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: nouveau-bounces-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org Sender: "Nouveau" To: nouveau-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org List-Id: nouveau.vger.kernel.org --===============0044782173== Content-Type: multipart/alternative; boundary="1440102018.eaaA2.1835"; charset="UTF-8" --1440102018.eaaA2.1835 Date: Thu, 20 Aug 2015 20:20:18 +0000 MIME-Version: 1.0 Content-Type: text/plain; charset="UTF-8" https://bugs.freedesktop.org/show_bug.cgi?id=90887 --- Comment #23 from jr --- (In reply to Ilia Mirkin from comment #22) > (In reply to jr from comment #21) > > Created attachment 117077 [details] [review] [review] > > Prototype of a more highlevel graph modification api > > > > ... > > Hrm, I was about to (try to) push this out, but it doesn't seem to work. I > made a few local adjustments, like > > RegAlloc::PhiMovesPass::isCriticalEdge(BasicBlock *b, BasicBlock *p) > { > return b->cfg.incidentCount() > 1 && p->cfg.outgoingCount() > 1; > } > > ... > > > where did BB:4 go? poof. not great :( this is with piglit's > tests/shaders/ssa/fs-critical-edge.shader_test > > I guess I'll go with either your or my first patches. Want to get this fixed > for Mesa 11, which is going to get branched off some time tomorrow. Sorry, most probably my prototype code is crap. I'll have an hour now to look at it. I'll let you know if I find something. Otherwise I'm fine with your first patch. -- You are receiving this mail because: You are the QA Contact for the bug. You are the assignee for the bug. --1440102018.eaaA2.1835 Date: Thu, 20 Aug 2015 20:20:18 +0000 MIME-Version: 1.0 Content-Type: text/html; charset="UTF-8"

Comment # 23 on bug 90887 from 
(In reply to Ilia Mirkin from comment #22)
> (In reply to jr from comment #21)
> > Created attachment 117077 [details] [review] [review] [review]
> > Prototype of a more highlevel graph modification api
> > 
> > ...
> 
> Hrm, I was about to (try to) push this out, but it doesn't seem to work. I
> made a few local adjustments, like
> 
> RegAlloc::PhiMovesPass::isCriticalEdge(BasicBlock *b, BasicBlock *p)
> {
>    return b->cfg.incidentCount() > 1 && p->cfg.outgoingCount() > 1;
> }
> 
> ...
> 
> 
> where did BB:4 go? poof. not great :( this is with piglit's
> tests/shaders/ssa/fs-critical-edge.shader_test
> 
> I guess I'll go with either your or my first patches. Want to get this fixed
> for Mesa 11, which is going to get branched off some time tomorrow.

Sorry, most probably my prototype code is crap. I'll have an hour now to look
at it. I'll let you know if I find something. Otherwise I'm fine with your
first patch.

You are receiving this mail because:
  • You are the QA Contact for the bug.
  • You are the assignee for the bug.
--1440102018.eaaA2.1835-- --===============0044782173== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Content-Disposition: inline X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KTm91dmVhdSBt YWlsaW5nIGxpc3QKTm91dmVhdUBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0cDovL2xpc3RzLmZy ZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL25vdXZlYXUK --===============0044782173==--