From mboxrd@z Thu Jan 1 00:00:00 1970 From: bugzilla-daemon-CC+yJ3UmIYqDUpFQwHEjaQ@public.gmane.org Subject: [Bug 90887] PhiMovesPass in register allocator broken Date: Fri, 21 Aug 2015 21:53:14 +0000 Message-ID: References: Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============1279461316==" Return-path: In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: nouveau-bounces-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org Sender: "Nouveau" To: nouveau-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org List-Id: nouveau.vger.kernel.org --===============1279461316== Content-Type: multipart/alternative; boundary="1440193994.66c3DAB2.17416"; charset="UTF-8" --1440193994.66c3DAB2.17416 Date: Fri, 21 Aug 2015 21:53:14 +0000 MIME-Version: 1.0 Content-Type: text/plain; charset="UTF-8" https://bugs.freedesktop.org/show_bug.cgi?id=90887 --- Comment #32 from jr --- (In reply to Ilia Mirkin from comment #31) > Really if I could understand wtf the needNewElseBlock logic was trying to > do, and could construct a test shader to hit this in *regular* scenarios, > not just the lowered output of TXL, that would make me a lot more > comfortable with any approach that we pick. Looking at the TGSI->IR translation I'd guess that needNewElseBlock is trying to detect the edge from the 'bare' unconditional jump in an if without else, seemingly because adding the new moves is not allowed (though I'm not sure why). At least it seems to be the only construct creating a graph satisfying the condition, AFAICT. -- You are receiving this mail because: You are the QA Contact for the bug. You are the assignee for the bug. --1440193994.66c3DAB2.17416 Date: Fri, 21 Aug 2015 21:53:14 +0000 MIME-Version: 1.0 Content-Type: text/html; charset="UTF-8"

Comment # 32 on bug 90887 from 
(In reply to Ilia Mirkin from comment #31)
> Really if I could understand wtf the needNewElseBlock logic was trying to
> do, and could construct a test shader to hit this in *regular* scenarios,
> not just the lowered output of TXL, that would make me a lot more
> comfortable with any approach that we pick.

Looking at the TGSI->IR translation I'd guess that needNewElseBlock is trying
to detect the edge from the 'bare' unconditional jump in an if without else,
seemingly because adding the new moves is not allowed (though I'm not sure
why). At least it seems to be the only construct creating a graph satisfying
the condition, AFAICT.

You are receiving this mail because:
  • You are the QA Contact for the bug.
  • You are the assignee for the bug.
--1440193994.66c3DAB2.17416-- --===============1279461316== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Content-Disposition: inline X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KTm91dmVhdSBt YWlsaW5nIGxpc3QKTm91dmVhdUBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0cDovL2xpc3RzLmZy ZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL25vdXZlYXUK --===============1279461316==--