* [MPTCP] Re: [PATCH 0/3] mptcp: fix for ipv6-related oops
@ 2019-11-21 14:15 Matthieu Baerts
0 siblings, 0 replies; 3+ messages in thread
From: Matthieu Baerts @ 2019-11-21 14:15 UTC (permalink / raw
To: mptcp
[-- Attachment #1: Type: text/plain, Size: 939 bytes --]
Hi Paolo,
On 21/11/2019 13:25, Paolo Abeni wrote:
> We need to allocate a larger struct sock for mptcp v6 master sockets,
> otherwise inet6_sk() will access mptcp related data instead of
> struct ipv6_pinfo.
>
> This should fix the crash reported by Matt.
Thank you for the quick fix!
> The protocol.c code changes are split in 2 patches to simplify the
> squashing.
> (yep, I know we somewhat agreed to big giant rebase, but this specific
> should be trivial).
That's a good idea because for the moment, the CI is notifying me each
time that the kselftests are failing (when testing the commit
introducing them)!
> Additionally adds some fixlet for the ipv6 tests
I have a few questions in the 2 first patches.
Cheers,
Matt
--
Matthieu Baerts | R&D Engineer
matthieu.baerts(a)tessares.net
Tessares SA | Hybrid Access Solutions
www.tessares.net
1 Avenue Jean Monnet, 1348 Louvain-la-Neuve, Belgium
^ permalink raw reply [flat|nested] 3+ messages in thread
* [MPTCP] Re: [PATCH 0/3] mptcp: fix for ipv6-related oops
@ 2019-11-21 15:58 Matthieu Baerts
0 siblings, 0 replies; 3+ messages in thread
From: Matthieu Baerts @ 2019-11-21 15:58 UTC (permalink / raw
To: mptcp
[-- Attachment #1: Type: text/plain, Size: 1122 bytes --]
Hi Paolo,
On 21/11/2019 16:41, Paolo Abeni wrote:
> We need to allocate a larger struct sock for mptcp v6 master sockets,
> otherwise inet6_sk() will access mptcp related data instead of
> struct ipv6_pinfo.
>
> This should fix the crash reported by Matt.
>
> The protocol.c code changes are split in 2 patches to simplify the
> squashing.
> (yep, I know we somewhat agreed to big giant rebase, but this specific
> should be trivial).
>
> Additionally adds some fixlet for the ipv6 tests
>
> v1 -> v2:
> - address Matt feedback on patches 1 && 2
> - add missing mptcp_v6 proto registration (I don't know why the previous
> iteration of these patches did not explode without that!!! :(((
Thank you for the new version and good catch for the proto registration!
The new version looks good to me. I am going to apply it if there is no
objections (post fixes are still possible of course).
Cheers,
Matt
--
Matthieu Baerts | R&D Engineer
matthieu.baerts(a)tessares.net
Tessares SA | Hybrid Access Solutions
www.tessares.net
1 Avenue Jean Monnet, 1348 Louvain-la-Neuve, Belgium
^ permalink raw reply [flat|nested] 3+ messages in thread
* [MPTCP] Re: [PATCH 0/3] mptcp: fix for ipv6-related oops
@ 2019-11-21 16:44 Matthieu Baerts
0 siblings, 0 replies; 3+ messages in thread
From: Matthieu Baerts @ 2019-11-21 16:44 UTC (permalink / raw
To: mptcp
[-- Attachment #1: Type: text/plain, Size: 1736 bytes --]
Hi Paolo,
On 21/11/2019 16:58, Matthieu Baerts wrote:
> Hi Paolo,
>
> On 21/11/2019 16:41, Paolo Abeni wrote:
>> We need to allocate a larger struct sock for mptcp v6 master sockets,
>> otherwise inet6_sk() will access mptcp related data instead of
>> struct ipv6_pinfo.
>>
>> This should fix the crash reported by Matt.
>>
>> The protocol.c code changes are split in 2 patches to simplify the
>> squashing.
>> (yep, I know we somewhat agreed to big giant rebase, but this specific
>> should be trivial).
>>
>> Additionally adds some fixlet for the ipv6 tests
>>
>> v1 -> v2:
>> - address Matt feedback on patches 1 && 2
>> - add missing mptcp_v6 proto registration (I don't know why the
>> previous
>> iteration of these patches did not explode without that!!! :(((
>
> Thank you for the new version and good catch for the proto registration!
>
> The new version looks good to me. I am going to apply it if there is no
> objections (post fixes are still possible of course).
Again thank you for the patches!
- 2a2dd30dbd33: "squashed" patch 1/3 in "mptcp: add basic kselftest for
mptcp"
- 39d0ec7ab1eb..432a009dc917: result
- 4bf7842874f1: "squashed" patch 2/3 in "mptcp: Add MPTCP socket stubs"
- 3d4407546cc9: conflict in t/mptcp-Associate-MPTCP-context-with-TCP-socket
- 432a009dc917..458c883a09f8: result
- 972a3aab48ac: "squashed" patch 3/3 in "mptcp: Add key generation and
token tree"
- 458c883a09f8..9dde928ded79: result
Tests are now OK again! Thanks for the fix!
Cheers,
Matt
--
Matthieu Baerts | R&D Engineer
matthieu.baerts(a)tessares.net
Tessares SA | Hybrid Access Solutions
www.tessares.net
1 Avenue Jean Monnet, 1348 Louvain-la-Neuve, Belgium
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2019-11-21 16:44 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-11-21 16:44 [MPTCP] Re: [PATCH 0/3] mptcp: fix for ipv6-related oops Matthieu Baerts
-- strict thread matches above, loose matches on Subject: below --
2019-11-21 15:58 Matthieu Baerts
2019-11-21 14:15 Matthieu Baerts
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.